1 2007-06-18 Murray Cumming <murrayc@murrayc.com>
3 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
5 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
6 for Mameo Bora, to fix the build.
8 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
11 Fixed build with hildon < 0.99
13 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
14 Check if the selected account is busy instead of checking all accounts
16 * src/modest-account-mgr-priv.h:
17 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
18 (modest_account_mgr_init), (compare_account_name),
19 (modest_account_mgr_set_account_busy),
20 (modest_account_mgr_account_is_busy):
21 * src/modest-account-mgr.h:
22 Added busy information to the account manager. It possible to
23 set an account to busy or not busy now.
25 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
26 (modest_mail_operation_update_account),
27 (modest_mail_operation_notify_end):
28 Set the account to busy/not busy depending on the operation state.
30 * src/widgets/modest-account-view.c:
31 (modest_account_view_finalize), (get_last_updated_string),
32 (update_account_view), (on_account_busy_changed), (init_view):
33 Show string "Refreshing..." if the account is currently busy.
35 All this fixes projects.maemo.org bug NB#59711
37 2007-06-14 Armin Burgmeier <armin@openismus.com>
39 * src/widgets/modest-attachments-view.h:
40 * src/widgets/modest-attachments-view.c: Added
41 modest_attachments_view_has_attachments() and fixed coordinate
42 transformation in get_att_view_at_coords(). This fixes attachment
45 * src/widgets/modest-msg-view.c: Make use of
46 modest_attachments_view_has_attachments() to decide whether to show
47 attachments in the header.
49 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
51 * src/maemo/modest-connection-specific-smtp-edit-window.c:
52 (on_change), (on_combo_security_changed),
53 (modest_connection_specific_smtp_edit_window_init),
54 (modest_connection_specific_smtp_edit_window_set_connection),
55 (modest_connection_specific_smtp_edit_window_is_dirty):
56 * src/maemo/modest-connection-specific-smtp-edit-window.h:
57 * src/maemo/modest-connection-specific-smtp-window.c:
60 Show an comfirmation dialog for the smpt-edit-window if there are
61 unsaved changes and the user hits cancel.
62 (projects.maemo.org bug NB#60479)
64 2007-06-14 Armin Burgmeier <armin@openismus.com>
66 * src/maemo/easysetup/modest-easysetup-wizard.c:
67 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
68 address" info in banner instead of node, and select all the text as
69 per UI spec. This fixes projects.maemo.org bug NB#60550.
71 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
73 reviewed by: <delete if not using a buddy>
75 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
76 * src/modest-ui-actions.c: (folder_refreshed_cb):
78 2007-06-14 Murray Cumming <murrayc@murrayc.com>
80 * src/widgets/modest-folder-view.c: (filter_row):
81 Explictly filter out the per-account outbox accounts. I don't know why
82 these only sometimes show up, but now they should never show up in the UI.
83 This should fix projects.maemo.org bug NB#60160.
85 2007-06-14 Murray Cumming <murrayc@murrayc.com>
87 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
88 when the toolbar does not exist yet.
89 * src/modest-widget-memory.c: (save_settings_header_view):
90 Added g_warnings() to help us to discover when we are trying to set
91 an empty columns list in gconf.
93 2007-06-14 Murray Cumming <murrayc@murrayc.com>
97 Added modest_init_get_default_header_view_column_ids().
99 * src/modest-widget-memory.c: (restore_settings_header_view):
100 Use the new function to get defaults, if the gconf key is empty,
101 instead of not creating any columns. This seems to fix the
102 empty right-hand pane problems.
104 * src/widgets/modest-header-view.h: Improved documentation.
106 2007-06-13 Murray Cumming <murrayc@murrayc.com>
108 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
109 Revert the use of the display name as the account name, because this
110 is generally wrong and would break the code that follows.
112 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
114 * src/maemo/easysetup/modest-easysetup-wizard.c:
115 (check_for_supported_auth_methods), (on_before_next),
118 More correct fix for projects.maemo.org bug NB# 58991
119 Do not longer accept AUTH_PASSWORD as secure method and choose
120 correct method when creating the account.
122 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
124 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
125 Fixed projects.maemo.org bug NB# 58991
127 2007-06-13 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-init.c: (modest_init_init_core),
130 (modest_init_local_folders): Fixed compilation errors.
132 2007-06-13 Murray Cumming <murrayc@murrayc.com>
134 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
135 Remove unnecessary lib/include, though it is good in principle when needed.
137 * src/modest-init.c: (modest_init_one_local_folder),
138 (modest_init_local_folders):
139 * src/modest-init.h: Initialize the .modest library for memory cards,
140 instead of just doing nothing for them. This should allow us to create
141 folders there, fixing projects.maemo.org bug NB#59297.
143 2007-06-13 Murray Cumming <murrayc@murrayc.com>
145 * libmodest-dbus-client/libmodest-dbus-client.c:
146 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
147 (libmodest_dbus_client_compose_mail),
148 (libmodest_dbus_client_open_message),
149 (libmodest_dbus_client_send_and_receive),
150 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
152 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
153 (on_idle_open_message), (modest_dbus_req_handler),
154 (search_result_to_message), (modest_dbus_req_filter):
155 * src/modest-search.c: (add_hit), (modest_search_folder),
156 (modest_search_all_accounts): Improved debug messages.
158 * tests/dbus_api/test_open_message.c: (main): Improved comments.
160 * src/modest-tny-account-store.c:
161 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
164 2007-06-13 Murray Cumming <murrayc@murrayc.com>
167 2007-06-12 Murray Cumming <murrayc@murrayc.com>
169 * src/modest-tny-account-store.c: (get_server_accounts):
170 Call modest_tny_local_folders_account_add_merged_outbox_folders()
171 even when there are no accounts, so that the Outbox folder is always
172 visible. This fixes projects.maemo.org bug NB#60158.
174 2007-06-12 Murray Cumming <murrayc@murrayc.com>
176 * src/maemo/modest-main-window.c: (create_details_widget):
177 Use the mcen_va_never logical ID.
179 2007-06-12 Murray Cumming <murrayc@murrayc.com>
181 * src/dbus_api/modest-dbus-api.h:
182 * src/dbus_api/modest-dbus-callbacks.c:
183 (on_idle_open_default_inbox), (on_open_default_inbox),
184 (modest_dbus_req_handler):
185 Added a new OpenDefaultInbox method.
187 * libmodest-dbus-client/libmodest-dbus-client.h:
188 * libmodest-dbus-client/libmodest-dbus-client.c:
189 Added libmodest_dbus_client_open_default_inbox() to call the new
190 dbus method. This should be useful to projects.maemo.org bug NB#57214,
191 though it should maybe be used by a new osso-email-interface function.
193 * tests/dbus_api/Makefile.am:
194 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
197 2007-06-12 Murray Cumming <murrayc@murrayc.com>
199 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
200 NULL, so that the signals get all the keys. This should not actually
201 change any behaviour because we currently update everything when anything
204 2007-06-12 Murray Cumming <murrayc@murrayc.com>
206 * src/widgets/modest-folder-view.c: (text_cell_data),
207 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
208 (find_inbox_iter): If tinymail tells us that the folder is
209 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
210 This causes the inbox to be selected at startup, fixing part of
211 projects.maemo.org bug NB#56305.
213 * src/modest-ui-dimming-rules.c:
214 (modest_ui_dimming_rules_on_tools_smtp_servers):
215 * src/modest-ui-dimming-rules.h: Added a callback function to dim
216 the SMTP servers menu item.
217 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
218 that the SMTP Servers menu item is dimmed when there are no accounts,
219 as a future version of the UI spec will require. This fixes
220 projects.maemo.org bug NB#56305.
222 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
224 * src/maemo/modest-maemo-utils.c:
225 (modest_maemo_utils_get_supported_secure_authentication_methods):
226 Added label to dialog instead of unreadable title
228 * src/maemo/modest-main-window.c: (sync_accounts_cb),
229 (modest_main_window_new):
230 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
233 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
234 * src/modest-account-mgr.h:
235 Added method to avoid code duplication
237 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
238 (modest_ui_actions_on_send_receive):
239 Use modest_account_mgr_has_accounts
241 2007-06-11 Murray Cumming <murrayc@murrayc.com>
243 * src/maemo/easysetup/modest-presets.c:
244 (modest_presets_get_info_server_security): Do not report secure auth
246 * src/modest-protocol-info.c: Use the defines for the gconf key names
247 for secure authentication. This was not working because we were writing
248 Password and reading password, and the check was case sensitive.
249 With this, gmail now works for receiving and sending when created via
252 2007-06-11 Murray Cumming <murrayc@murrayc.com>
254 * src/maemo/easysetup/modest-presets.c:
255 (modest_presets_get_info_server_security): Correct the key name for
256 SecureSmtp, because it seems to be case-sensitive.
257 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
258 Do not try to get the 0th notebook page if there are 0 pages, to
261 2007-06-11 Murray Cumming <murrayc@murrayc.com>
263 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
264 Prevent use of the new notification feature for now, because it currently
265 shows one dialog for each new email, which is annoying.
267 2007-06-11 Murray Cumming <murrayc@murrayc.com>
269 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
270 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
271 when no country was selected, so that we show the global ones.
272 * src/maemo/easysetup/modest-presets.c:
273 (modest_presets_get_providers): Return only the global providers, not
274 all providers when mmc=0 was requested.
276 2007-06-11 Murray Cumming <murrayc@murrayc.com>
278 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
279 (easysetup_provider_combo_box_fill): Remove debug code that showed the
280 provider ID in the combo.
282 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
283 Do not show the page numbers, because it would be confusing when we add
284 the 2 extra pages for the custom setup, when the user chooses the "Other"
285 provider. This fixes projects.maemo.org bug NB#59028
287 * src/modest-init.c: (modest_init_init_core),
288 (modest_init_local_folders):
290 * src/modest-tny-account.c:
291 (modest_tny_account_new_for_local_folders): Do not create default folders
292 for the memory card. This should fix projects.maemo.org bug NB#59328.
294 2007-06-11 Murray Cumming <murrayc@murrayc.com>
296 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
297 Free the changed_conf_keys string items. They are already freed in the
298 idle handler if that runs first.
300 2007-06-11 Murray Cumming <murrayc@murrayc.com>
302 * src/modest-ui-actions.c:
303 (modest_ui_actions_on_password_requested): Check that the server name
304 is not NULL, because I just saw a password dialog with (null) as the
307 * src/modest-tny-folder.[h|c]: Added
308 modest_tny_folder_is_memory_card_folder().
309 * src/modest-ui-dimming-rules.c:
310 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
311 menu item for memory cards, as per the UI spec (section 7.4). This should
312 fix projects.maemo.org bug NB#59297.
314 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
316 * src/maemo/modest-main-window.c: (sync_accounts_cb):
317 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
318 is another problem with the code, see Murray's comment at line 772)
320 2007-06-08 Murray Cumming <murrayc@murrayc.com>
322 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
323 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
324 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
325 (load_from_file), (easysetup_country_combo_box_init),
326 (easysetup_country_combo_box_get_active_country_ids),
327 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
328 instead of just one ID, to avoid duplicate country names in the UI.
330 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
331 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
332 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
333 a single ID, avoiding duplicate providers.
334 * src/maemo/easysetup/modest-easysetup-wizard.c:
335 (on_combo_account_country): Adapt to use a list.
337 2007-06-08 Murray Cumming <murrayc@murrayc.com>
339 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
340 keys changed in the last X seconds.
342 * src/modest-account-mgr.h:
343 * src/modest-account-mgr.c: (on_timeout_notify_changes),
344 (on_key_change), (modest_account_mgr_class_init),
345 (modest_account_mgr_init), (modest_account_mgr_finalize):
346 As the keys are changed, save them in a GSList* and signal that GSList*
347 further every X seconds, to batch changes, to allow us to do just one
348 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
349 bug NB#56941 and other (UI-blocking) delays when changing account settings.
351 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
352 changed signal signature.
354 * src/modest-conf.c: (modest_conf_set_list),
355 (modest_conf_on_change): Reenable notification.
357 (modest_conf_maemo_fake_on_change): Comment out the hack that
358 notified immediately instead of asynchronously.
360 * src/widgets/modest-account-view.h:
361 * src/widgets/modest-account-view.c:
362 (update_account_view): Select the previously-selected account ID,
363 if possible. This fixes projects.maemo.org bug NB#56933.
365 (on_account_changed), (on_account_removed),
366 (modest_account_view_select_account):
368 Remove the block/unblock functions
369 because they were not useful.
371 * src/maemo/modest-account-view-window.c:
372 (on_delete_button_clicked), (on_edit_button_clicked),
373 (on_new_button_clicked): Remove the use of the non-working block/unblock.
375 2007-06-08 Murray Cumming <murrayc@murrayc.com>
377 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
378 Improve the error dialog to show Incorrect Account Settings, which seems
379 clearer, and say that the internal error message (to be removed from the
380 dialog later) is often misleading.
381 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
383 * src/modest-tny-account.c:
384 (modest_tny_account_new_from_server_account): Uncomment the printf of the
385 URL because this is so useful for debugging on the device.
387 * src/widgets/modest-serversecurity-combo-box.c:
388 (modest_serversecurity_combo_box_fill): Correct a logical ID.
390 2007-06-08 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-mail-operation.c:
393 (modest_mail_operation_send_new_mail):
394 Added a comment about a nasty but apparently harmless message. Details
395 added to the wiki g_warnings() page.
397 2007-06-08 Murray Cumming <murrayc@murrayc.com>
399 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
400 (modest_tny_send_queue_class_init):
401 Do not use the priv struct because it is empty, to avoid g_warnings
402 about a non-existant priv struct.
404 * src/modest-tny-account-store.c:
405 (modest_tny_account_store_get_server_account),
406 (modest_tny_account_store_get_transport_account_for_open_connection
407 ): Do not try to get transport server accounts for local folders,
408 because they don't have any. This avoids a g_warning().
410 * src/maemo/modest-main-window.c:
411 (modest_main_window_notify_send_receive_initied),
412 (on_configuration_key_changed):
413 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
415 * src/modest-mail-operation.c:
416 (modest_mail_operation_update_account):
417 * src/modest-tny-account-store.h:
418 * src/modest-tny-account.c:
419 (modest_tny_account_get_special_folder),
420 (modest_tny_account_new_for_local_folders),
421 (modest_tny_account_new_for_per_account_local_outbox_folder):
422 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
423 * src/modest-tny-local-folders-account.c:
424 (add_account_folders_to_merged_folder):
425 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
426 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
427 (modest_ui_actions_on_send):
428 * src/widgets/modest-folder-view.c: (update_model):
429 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
430 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
431 modest_tny_account_store_get_tny_account_by_account() to
432 modest_tny_account_store_get_server_account() to make the code clearer.
434 2007-06-07 Marcus Bauer <marcusb@openismus.com>
436 * src/dbus_api/modest-dbus-api.h:
437 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
438 * src/maemo/modest-msg-edit-window.c:
439 (modest_msg_edit_window_attach_file_noninteractive):
440 added g_warning in case the file to be attached does not exist
441 * tests/dbus_api/test_compose_mail.c: (main):
442 removed obsolete comment, added generic files as test case
444 2007-06-07 Murray Cumming <murrayc@murrayc.com>
446 * src/modest-tny-account-store.c: (get_server_accounts):
447 Create the local folders account only once, not once for each outbox, and
448 not only when there are some outboxes.
450 2007-06-07 Murray Cumming <murrayc@murrayc.com>
452 * src/widgets/modest-folder-view.c: (update_model): Comment out some
453 code that is causing a crash at startup. Sergio says that he is fixing this.
455 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
457 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
458 * src/maemo/modest-account-settings-dialog.c:
459 (create_page_outgoing),
460 (modest_account_settings_dialog_set_account_name),
461 (save_configuration):
462 - Fixed handling of the "Use secure authentication" toggle to comply with
463 the ui specification. See also projects.maemo.org bug NB#58400
465 - Restore the Secure connection setting combo correctly when loading
468 * src/maemo/modest-maemo-utils.c:
469 (on_camel_account_get_supported_secure_authentication),
470 (modest_maemo_utils_get_supported_secure_authentication_methods):
471 Fixed a crasher if operation is canceled
473 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
474 (modest_protocol_info_auth_is_secure):
475 * src/modest-protocol-info.h:
477 Added two new methods to determine if a protocol/auth method is secure/encrypted in
478 the sense of the "Use secure authentication" toggle.
480 2007-06-07 Murray Cumming <murrayc@murrayc.com>
482 * src/modest-tny-account-store.h:
483 * src/modest-tny-account-store.c:
484 Added modest_tny_account_store_get_local_folders_account().
486 * src/modest-tny-folder.h:
487 * src/modest-tny-folder.c:
488 (modest_tny_folder_get_account):
489 Added this replacement for tny_folder_get_account() which returns
490 the local-folders account for TnyMergeFolders, to avoid the
491 warning about the unimplemented get_account_func() vfunc().
493 (modest_tny_folder_get_rules),
494 * src/modest-ui-actions.c:
495 (modest_ui_actions_on_folder_selection_changed):
496 * src/modest-mail-operation.c:
497 (modest_mail_operation_remove_folder),
498 (modest_mail_operation_xfer_folder),
499 (modest_mail_operation_rename_folder),
500 (modest_mail_operation_get_msg),
501 (modest_mail_operation_get_msgs_full),
502 (modest_mail_operation_remove_msg),
503 (modest_mail_operation_xfer_msgs),
504 (modest_mail_operation_refresh_folder):
505 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
507 2007-06-07 Murray Cumming <murrayc@murrayc.com>
509 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
510 (modest_server_account_set_security):
511 * src/modest-defs.h: Add comments explaining that our
512 UI spec means TLS when it says Normal, so these do not look like errors.
514 * src/modest-tny-account.c:
515 (modest_tny_account_new_from_server_account): Use the new tinymail
516 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
517 for TLS. This should fix projects.maemo.org bug NB#58460.
519 2007-06-06 Murray Cumming <murrayc@murrayc.com>
521 * src/maemo/easysetup/modest-easysetup-wizard.c:
522 (create_account): Correct the position of the gconf sanity check warning.
523 (on_button_edit_advanced_settings): Show the dialog immediately, instead
524 of using the g_idle_add() hack, because this does not seem to be necessary
525 on osso 1.1. It might even work on Maemo Bora if the problems were actually
526 caused by something other than maemo's gconf.
527 This fixes projects.maemo.org bug #59022.
529 2007-06-06 Murray Cumming <murrayc@murrayc.com>
531 * src/modest-account-mgr-helpers.c:
532 (modest_account_mgr_get_default_account): Do not check that the account
533 exists if there is no default account (NULL), to fix a runtime warning.
535 2007-06-06 Murray Cumming <murrayc@murrayc.com>
537 * src/widgets/modest-folder-view.c: (update_model):
538 Do not unref the treemodel before we have finished with it.
539 This prevents a valgrind warning and an occasional crash at startup.
541 2007-06-06 Marcus Bauer <marcusb@openismus.com>
543 * libmodest-dbus-client/libmodest-dbus-client.h:
544 added libmodest_dbus_client_compose_mail()
545 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
547 added functions needed for SendAsMail() functionality
548 * src/maemo/modest-msg-edit-window.c:
549 (modest_msg_edit_window_attach_file_noninteractive):
550 non interactively attaching files to message edit window
551 * src/widgets/modest-msg-edit-window.h:
552 * tests/dbus_api/Makefile.am:
553 added test_compose_mail.c
554 * tests/dbus_api/test_compose_mail.c: (main):
556 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
558 * src/modest-account-view.c:
559 Fixed bug projects.maemo.org bug NB#59307
561 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
563 * src/maemo/easysetup/modest-easysetup-wizard.c:
564 (get_serverport_incoming), (on_before_next), (create_account):
565 * src/maemo/modest-account-settings-dialog.c:
566 (modest_account_settings_dialog_set_account_name):
567 * src/maemo/modest-maemo-utils.c:
568 (on_camel_account_get_supported_secure_authentication_status),
569 (on_camel_account_get_supported_secure_authentication),
570 (on_secure_auth_cancel),
571 (modest_maemo_utils_get_supported_secure_authentication_methods):
573 Implemented security authentication for settings and easysetup.
575 2007-06-05 Murray Cumming <murrayc@murrayc.com>
577 * src/maemo/modest-main-window.c: (create_details_widget):
578 Show the total size for memory card accounts too, instead of showing
579 the name again. Fixes bug projects.maemo.org bug NB#59307.
581 2007-06-05 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-tny-simple-folder-store.c:
585 * src/modest-tny-simple-folder-store.h: Removed.
587 * src/modest-tny-local-folders-account.h
588 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
589 for the local-folders maildir, with an extra TnyMergedFolder containing
590 the folders of the per-account outbox store accounts.
591 * src/modest-tny-account-store.c: (get_server_accounts):
592 Add the outboxes to the special local folders account after creating it.
594 * src/modest-tny-account.c:
595 (modest_tny_account_new_for_local_folders): Create the derived
596 account when creating the main local-folders account.
598 * src/maemo/modest-main-window.c: (create_details_widget),
599 (modest_main_window_set_contents_style):
600 Adapted to the use of the derived account instead of the folder store.
602 * src/modest-ui-actions.c:
603 (modest_ui_actions_on_folder_selection_changed):
604 * src/modest-ui-dimming-rules.c:
605 (modest_ui_dimming_rules_on_new_folder):
606 * src/widgets/modest-folder-view.c: (text_cell_data),
607 (icon_cell_data), (filter_row), (update_model),
608 (get_cmp_rows_type_pos):
611 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
612 Do not get the priv struct, because no priv struct has been set,
613 to avoid a runtime warning.
615 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
616 #ifelse with #else, to fix a warning, to fix the build.
619 2007-06-05 Christian Kellner <ckellner@openismus.com>
621 * libmodest-dbus-client/libmodest-dbus-client.c:
622 Fix small typo in doc (why do you always see them
623 AFTER committing stuff?)
626 2007-06-05 Christian Kellner <ckellner@openismus.com>
628 * libmodest-dbus-client/libmodest-dbus-client.c:
629 (libmodest_dbus_client_search):
630 Initialize hit list with NULL. Also set folder list
631 to "" if NULL was supplied.
634 2007-06-03 Christian Kellner <ckellner@openismus.com>
636 * libmodest-dbus-client/libmodest-dbus-client.c:
637 (modest_search_hit_list_free):
638 Make it save to call it with NULL.
640 * src/dbus_api/modest-dbus-callbacks.c:
641 * src/modest-search.c:
642 Return full ModestSearchHits as the search result list not TnyHeader
643 since can't be around withouth the correspoding TnyFolder.
645 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
647 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
648 Added currently commented code to check for secure auth
650 * src/maemo/modest-account-settings-dialog.c: (on_response),
651 (save_configuration), (show_ok):
652 Fixed projects.maemo.org bugs NB #59248 and #59251
654 * src/maemo/modest-maemo-utils.c:
655 (on_camel_account_get_supported_secure_authentication_status),
656 (on_camel_account_get_supported_secure_authentication),
657 (modest_maemo_utils_get_supported_secure_authentication_methods):
658 * src/maemo/modest-maemo-utils.h:
659 Moved get_supported_secure_authentication() method here to be able
660 to use it from easysetup wizard.
662 * src/modest-pair.c: (on_pair_compare_as_string):
663 Should compare string with first part of pair and not
664 strcmp pairs which will crash.
666 * src/modest-protocol-info.c:
667 (modest_protocol_info_protocol_is_store):
668 * src/modest-protocol-info.h:
669 Added modest_protocol_info_get_auth_protocol_name()
671 2007-06-03 Armin Burgmeier <armin@openismus.com>
673 * src/modest-mail-operation.c:
674 (modest_mail_operation_get_msgs_full): Set priv->account also when
675 only retrieving a single message. This avoids a crash when canceling
678 (modest_mail_operation_notify_end): Do not explicitely remove the
679 operation from the queue but only emit the progress_changed signal.
680 The queue itself listens to that signal to remove the operation when
681 it is finished. This reduces coupling and removes a potential deadlock
682 when modest_mail_operation_notify_end() is called from the queue
683 itself. If that is a problem performance-wise, I would suggest to
684 implement a status-changed signal or something.
686 * src/modest-mail-operation-queue.c: Make sure to never call a
687 function from another file while the queue is locked. This (hopefully)
688 fixes another deadlock when exiting the application while retrieving
691 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
693 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
694 Fixed build if libogs is not available
696 2007-06-03 Christian Kellner <ckellner@openismus.com>
698 * libmodest-dbus-client/libmodest-dbus-client.h:
699 * libmodest-dbus-client/libmodest-dbus-client.c:
700 (libmodest_dbus_client_delete_message):
701 Implement deletion of messages (Client side).
703 (modest_search_hit_free),
704 (modest_search_hit_list_free):
705 Utility functions to free the result hits.
707 * src/dbus_api/modest-dbus-api.h:
708 * src/dbus_api/modest-dbus-callbacks.c:
710 (modest_dbus_req_handler):
711 Implement deletion of messages (Server side).
713 * tests/dbus_api/test_search.c: (main):
716 * tests/dbus_api/Makefile.am:
717 * tests/dbus_api/test_delete_message:
718 Add little test for the message deletion logic
720 2007-06-03 Armin Burgmeier <armin@openismus.com>
722 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
723 when the operation queue was not empty. projects.maemo.org bug
726 2007-06-03 Armin Burgmeier <armin@openismus.com>
728 * src/widgets/modest-account-view.c
729 (on_account_default_toggled): Toggle default account column
730 explicitely instead of waiting for gconf notification (which is
731 currently ignored). This should fix projects.maemo.org bug NB#56910
732 for now. It should probably be removed when gconf notifications are
735 2007-06-03 Christian Kellner <ckellner@openismus.com>
737 * libmodest-dbus-client/libmodest-dbus-client.c:
738 Removed debugging spew.
740 * src/dbus_api/modest-dbus-callbacks.c:
741 Added debugging info.
743 * src/modest-search.c:
744 (modest_search_all_accounts):
745 Use tny_account_store_get_accounts () on the account store
746 to get all accounts which is the way to get all accounts.
748 * tests/dbus_api/test_search.c: (main):
749 Make it possible to supply the search term on the command line.
751 2007-06-03 Christian Kellner <ckellner@openismus.com>
753 * libmodest-dbus-client/libmodest-dbus-client.c:
754 * libmodest-dbus-client/libmodest-dbus-client.h:
755 Implement searching for mesages over raw dbus. (Client side)
757 * src/dbus_api/Makefile.am:
758 * src/dbus_api/modest-dbus-api.h:
759 * src/dbus_api/modest-dbus-callbacks.c:
760 * src/dbus_api/modest-dbus-callbacks.h:
761 Search framework (Server side). Also implement on_idle_open_message().
763 * src/maemo/modest-platform.c: (modest_platform_init):
764 Prepare for raw dbus/osso rpc interaction.
766 * src/modest-search.h:
767 Changed minsize from unspecific guint to guint32.
769 * src/modest-search.c:
771 Added strange hack which magically made tnymail work.
773 (modest_search_folder),
774 (modest_search_account),
775 (modest_search_all_accounts):
776 Implement helper functions to search all accounts, specific account
779 * tests/dbus_api/Makefile.am:
780 * tests/dbus_api/test_open_message.c:
781 Read url to open from commandline.
783 * tests/dbus_api/test_search.c:
784 Implement small test for dbus search stuff
786 2007-06-02 Armin Burgmeier <armin@openismus.com>
788 * src/maemo/modest-account-settings-dialog.c: Changed window title to
789 include account type and account title. This fixes projects.maemo.org
792 * src/maemo/modest-account-view-window.c: Set a title for the window.
794 2007-06-02 Armin Burgmeier <armin@openismus.com>
796 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
797 incoming and outgoing server name based on email address and server
798 types as long as the names have not been edited manually. This fixes
799 projects.maemo.org bug NB#58671.
801 2007-06-02 Armin Burgmeier <armin@openismus.com>
803 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
804 server type cannot be changed in future to the incoming details page
805 when creating an account. This fixes projects.maemo.org bug NB#59029.
807 2007-06-02 Armin Burgmeier <armin@openismus.com>
809 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
810 and assigned max width chars so that they wrap instead of being
811 truncated. Fixes projects.maemo.org bug NB#56126.
813 2007-06-02 Armin Burgmeier <armin@openismus.com>
815 * src/maemo/modest-connection-specific-smtp-window.c: Add an
816 introductory note to the connection specific smtp servers dialog, as
817 section 8.12 of the email UI specification requires. This fixes
818 projects.maemo.org bug NB#59212.
820 2007-06-01 Murray Cumming <murrayc@murrayc.com>
822 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
823 Check for running mail operations, and offer to cancel them, as per the UI
824 spec. This fixes projects.maemo.org bug NB#59041 .
825 However, I suspect that tinymail may still use the network connection
826 in ways that we cannot detect or cancel. But it should at least adapt to
829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
831 * src/modest-tny-account-store.c: (recreate_all_accounts),
832 (get_cached_accounts), (get_server_accounts): Do more sensible
833 ref-counting of the temporarily-cached outbox accounts list. This seems
834 to fix a crash when entering the password when the password was wrong.
836 2007-06-01 Murray Cumming <murrayc@murrayc.com>
838 * src/gnome/modest-main-window.c: (connect_signals):
839 * src/modest-tny-account-store.c: (get_password),
840 (modest_tny_account_store_alert): Added comments and clues and
841 commented-out code about how we currently fail to deal with connection
842 errors and wrong passwords, and how we should.
844 2007-06-01 Murray Cumming <murrayc@murrayc.com>
846 * src/widgets/modest-retrieve-combo-box.c:
847 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
848 This fixes projects.maemo.org bug NB#58472 .
850 2007-06-01 Murray Cumming <murrayc@murrayc.com>
852 * src/maemo/easysetup/modest-easysetup-wizard.c:
853 (create_page_complete_easysetup):
854 (create_page_complete_custom): Correct the last commit,
855 putting the correct sentences in the correct pages.
857 2007-06-01 Murray Cumming <murrayc@murrayc.com>
859 * src/maemo/easysetup/modest-easysetup-wizard.c:
860 (create_page_complete_custom): Show the second sentence of text
861 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
864 2007-06-01 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
867 Set the leave-on-server conf key by default. This fixes
868 projects.maemo.org bug NB#59258 .
870 2007-06-01 Murray Cumming <murrayc@murrayc.com>
872 * src/maemo/modest-account-view-window.c:
873 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
874 logical ID for the confirmation messages. Fixed projects.maemo.org bug
877 2007-06-01 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/easysetup/modest-easysetup-wizard.c:
880 (create_caption_new_with_asterisk):
881 * src/maemo/modest-account-settings-dialog.c:
882 (create_caption_new_with_asterisk):
883 Uncomment the code to add the asterisk, because they are no longer in the
884 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
885 (update_incoming_server_title): Add an asterisk here too.
887 2007-06-01 Murray Cumming <murrayc@murrayc.com>
889 * src/maemo/modest-maemo-global-settings-dialog.c:
890 (current_connection): Check that we are even connected before trying to
891 get the current connection name, to prevent a warning.
893 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
894 Change the comments because tny_maemo_conic_device_connect() is now meant to
896 * src/modest-mail-operation.c:
897 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
898 make sure we have a connection and fail if we can't connect.
900 2007-05-31 Murray Cumming <murrayc@murrayc.com>
902 * src/maemo/modest-main-window.c:
903 (on_account_store_connecting_finished): Do not try to get the
904 connection ID if we are not really connected. I am surprised that
905 this signal handler is called when we are not connected.
907 2007-05-31 Murray Cumming <murrayc@murrayc.com>
909 * src/modest-error.h:
910 * src/modest-ui-actions.c:
911 (modest_ui_actions_get_msgs_full_error_handler):
912 Renamed an enum, added comments, added an enum
913 for retrieve-limit errors.
915 * src/modest-mail-operation.c: (foreach_add_item),
916 (internal_folder_observer_update), (update_account_thread),
917 (modest_mail_operation_get_msgs_full):
918 (modest_mail_operation_update_account),
919 Added comments about how this works, and some code that should
920 (but does not) check the retrieve-limit. See the TODO comment.
922 2007-05-31 Murray Cumming <murrayc@murrayc.com>
924 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
925 Initialize help_id to fix the build. Warnings are good.
927 2007-05-31 Murray Cumming <murrayc@murrayc.com>
929 * src/widgets/modest-hbox-cell-renderer.c:
930 (modest_hbox_cell_renderer_append):
931 * src/widgets/modest-vbox-cell-renderer.c:
932 (modest_vbox_cell_renderer_append):
933 Fix the last commit by doing an extra ref.
935 2007-05-31 Murray Cumming <murrayc@murrayc.com>
937 * src/widgets/modest-hbox-cell-renderer.c:
938 (modest_hbox_cell_renderer_append):
939 * src/widgets/modest-vbox-cell-renderer.c:
940 (modest_vbox_cell_renderer_append):
941 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
942 to fix the build with Maemo Bora.
943 However, there seems to be a remaining crash, probably due to reference
946 2007-05-30 Murray Cumming <murrayc@murrayc.com>
948 * src/modest-tny-account.c:
949 (modest_tny_account_new_for_local_folders):
950 Use hildon_file_system_info_async_new() to get a better name for
951 the memory card account, setting it as the account name.
952 The timing seems to work, but this is probably
953 not the best place to do this. See the TODO comment.
954 * src/maemo/modest-main-window.c: (create_details_widget):
955 * src/widgets/modest-folder-view.c: (text_cell_data):
956 Use the tny account name instead of hardcoding a name.
958 2007-05-30 Christian Kellner <ckellner@openismus.com>
960 * src/modest-search.c: (modest_search):
961 Correctly set part_search_func even if we have already parsed
962 the query and thus a valid OgsTextSearcher object.
964 2007-05-30 Christian Kellner <ckellner@openismus.com>
967 Search and check for libogs.
970 Incooparte the ogs build env.
972 * src/modest-mime-part-search-stream.c:
973 * src/modest-mime-part-search-stream.h:
974 Removed since we do the real searching now in modest-search.c.
976 * src/modest-search.c:
977 * src/modest-search.h:
978 Implement support for ogs. We use that if available and requested
979 and fall back to modest_text_utils_utf8_strcmp (). The search logic
980 should now handle the corner case when the search term is spread
981 across multiple reads.
982 Also the logic in modest_search () was corrected to search all
983 requested fields until one is found.
985 2007-05-30 Murray Cumming <murrayc@murrayc.com>
987 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
990 * src/modest-init.c: Made modest_init_local_folders() take a
991 path and be public so we can iniitialize maildir folders on
994 * src/modest-local-folder-info.h:
995 * src/modest-local-folder-info.c:
996 (modest_local_folder_info_get_maildir_path): Add a path parameter.
998 * src/modest-tny-account.c:
999 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1000 still means the standard local-folders path on the local volume.
1002 * src/modest-tny-account-store.c:
1003 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1004 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1005 all accounts when that happens.
1006 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1007 this too, so it shows up in the treeview.
1009 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1011 * src/maemo/modest-maemo-global-settings-dialog.c:
1012 (current_connection):
1013 * src/widgets/modest-global-settings-dialog.c:
1014 (current_connection_default):
1015 Use the enum values instead of 0, 1 and -1,
1016 to make the code clearer.
1018 * src/modest-account-mgr-helpers.c:
1019 (modest_account_mgr_get_connection_specific_smtp): Make this code
1022 * src/modest-runtime.h:
1023 * src/modest-runtime.c:
1024 Added modest_runtime_remove_all_send_queues().
1025 * src/maemo/modest-main-window.c:
1026 (on_account_store_connecting_finished): Recreate the send queues,
1027 using the appropriate transport accounts for this new connection.
1028 Some futher adapting might be needed if the old send queues are not
1029 automatically stopped at this point.
1031 * src/modest-tny-account-store.c: (get_server_accounts):
1032 Create the connection-specific transport accounts, so that they can
1033 be found later by their ID.
1035 * src/modest-tny-account.h:
1036 * src/modest-tny-account.c:
1037 Added modest_tny_account_new_from_server_account_name().
1038 modest_tny_account_new_from_server_account(): Do not create the
1039 send queues here, because they will be
1040 recreated anyway when the connection changes for the first time.
1042 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1044 * src/modest-local-folder-info.h:
1045 * src/modest-local-folder-info.c:
1046 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1047 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1048 tbox_folder): Take a modest account name instead of a server TnyAccount,
1049 so we can have per-modest-account rather than per-transport-account
1051 We must make sure that we change or recreate the exisitng send queues
1052 when the connection changes for connection-specific transport accounts.
1054 * src/modest-tny-account-store.c:
1055 (create_per_account_local_outbox_folders): Create outboxed per modest
1056 account, not per transport account.
1058 * src/modest-tny-account.h:
1059 * src/modest-tny-account.c:
1060 (modest_tny_account_get_special_folder): For outboxes, get the
1061 parent modest account name. The account is ignored for other folders.
1062 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1063 modest account name rather than a server TnyAccount.
1065 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1067 * src/modest-tny-account.c:
1068 (modest_tny_account_new_from_server_account):
1069 Call modest_runtime_get_send_queue() immediately after creating transport
1070 accounts, so that they start trying to send email from the outbox as soon
1071 as possible at startup. This is probably what we want.
1073 * src/modest-mail-operation.c: (update_account_thread):
1074 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1075 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1076 * src/modest-tny-send-queue.h:
1077 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1078 (modest_ui_actions_on_send):
1079 Added comments about how sending works, though it needs some more work.
1081 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-tny-account.c:
1084 (modest_tny_account_get_special_folder): Add TODO because this fails when
1085 the network is busy.
1086 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1087 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1088 Do not try to show this window when there is no active account. The UI
1089 specs does not tell us what to do in this case.
1091 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1095 * src/maemo/Makefile.am:
1096 * src/widgets/Makefile.am: Some dist fixes.
1098 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1100 * src/maemo/modest-connection-specific-smtp-window.c:
1101 (on_button_edit): Make the code clearer, to prevent a double free.
1103 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1105 * src/maemo/modest-account-settings-dialog.c:
1106 (modest_account_settings_dialog_set_account_name),
1107 Check the connection-specific smtp servers checkbox if there are any.
1109 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1110 (modest_connection_specific_smtp_edit_window_init):
1111 Start with a suitable port number.
1113 * src/modest-account-mgr-helpers.h:
1114 * src/modest-account-mgr-helpers.c: Added
1115 modest_account_mgr_get_has_connection_specific_smtp().
1117 (modest_account_mgr_set_connection_specific_smtp),
1118 (modest_account_mgr_remove_connection_specific_smtp),
1119 (modest_account_mgr_get_has_connection_specific_smtp),
1120 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1121 connection-specific smtp server accounts in the account, rather than
1122 the server account conf dir.
1124 This fixes bug projects.maemo.org bug NB#58263 .
1126 * src/modest-tny-account-store.c:
1127 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1128 if there are no server accounts yet, to prevent an infinite loop when there
1129 are no accounts. Document that one must be called before the other.
1131 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1133 * src/modest-account-mgr-helpers.c:
1134 (modest_account_mgr_get_default_account): Make sure that at least
1135 one account is always the default, if there are any enabled accounts.
1136 This is just a sanity check that shouldn't be necessary.
1138 * src/modest-account-mgr-priv.c:
1139 (_modest_account_mgr_account_from_key): Unescape the conf key to
1140 get the real account name. For instance, this is an issue if a space
1141 was in the account name, which can happen because the account name
1142 is generated from the display name.
1143 (_modest_account_mgr_get_account_keyname): Always escape the
1145 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1146 Unescape the conf keys to get the real account names.
1148 For instance, previously the is-default radio button in the accounts
1149 list was not checked for any accounts at first. This fixes that,
1150 and might fix several similar bugs.
1152 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1155 Removed some debug printfs.
1157 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1159 Modest on-disk outbox directories are now here, for instance:
1160 $HOME/.modest/outboxes/<account-id-1>/outbox
1161 $HOME/.modest/outboxes/<account-id-2>/outbox
1163 $HOME/.modest/local-folders/outbox
1164 so we can have a separate outbox for each account.
1165 But they are shown as one outbox in the GtkTreeView, by using a
1166 TnyMergeFolder in a ModestTnySimpleFolderStore.
1169 * src/modest-tny-simple-folder-store.c:
1170 * src/modest-tny-simple-folder-store.h:
1171 Added ModestTnySimpleFolderStore, used to contain folders from
1172 other folder stores, such as other accounts.
1174 * src/modest-tny-outbox-account.h:
1175 * src/modest-tny-outbox-account.c:
1176 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1177 used for the per-account local outbox folders.
1179 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1180 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1181 only use this (internally) now for the non-outbox local folders.
1183 * src/modest-init.h:
1184 * src/modest-init.c: Added modest_init_one_local_folder(), for
1185 setting up the directory structure for each local folder.
1187 * src/modest-local-folder-info.c:
1188 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1189 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1191 * src/modest-local-folder-info.h:
1192 * src/modest-tny-account-store.c: (on_account_removed),
1193 (on_account_changed), (create_per_account_local_outbox_folders),
1194 (get_server_accounts), (modest_tny_account_store_get_accounts),
1195 (modest_tny_account_store_get_tny_account_by_account),
1196 (modest_tny_folder_store_is_virtual_local_folders):
1198 * src/modest-tny-account.h:
1199 * src/modest-tny-account.c:
1200 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1201 to create an on-disk per-account local outbox folder for each
1203 (create_per_account_local_outbox_folders): Create a local outbox folder
1204 for each transport account.
1205 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1206 for all local folders.
1208 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1209 instead of using g_object_get/set() directly. It is clearer.
1211 (modest_tny_folder_store_get_message_count),
1212 (modest_tny_folder_store_get_local_size
1213 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1214 because we now use these with non-acount folder stores.
1216 (modest_tny_account_get_special_folder),
1217 (modest_tny_account_new_from_server_account),
1218 (modest_tny_account_new_from_account):
1219 (recurse_folders): Adjust to the new outbox system.
1221 * src/modest-tny-folder.h:
1222 * src/modest-tny-folder.c:
1223 (modest_tny_folder_is_local_folder),
1224 (modest_tny_folder_get_local_folder_type),
1225 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1227 * src/widgets/modest-main-window.h:
1228 * src/maemo/modest-main-window.c: (create_details_widget),
1229 (modest_main_window_set_contents_style): Show details for any folder store,
1232 (modest_tny_folder_get_rules):
1233 Remove the const. C does not support constness enough for this.
1235 * src/modest-ui-actions.c:
1236 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1237 make all outboxes appear as one, in the usual local-folders tree node.
1239 (set_active_account_from_tny_account),
1240 (modest_ui_actions_on_folder_selection_changed):
1241 * src/widgets/modest-folder-view.c: (text_cell_data),
1242 (icon_cell_data), (filter_row),
1243 (add_account_folders_to_merged_folder),
1244 (add_account_folders_to_simple_folder_store), (),
1245 (get_cmp_rows_type_pos), (cmp_rows),
1246 (modest_folder_view_set_account_id_of_visible_server_account):
1247 Adjust to the new outbox system, using generic folder stores and folders
1248 in the GtkTreeModel.
1250 2007-05-23 Christian Kellner <ckellner@openismus.com>
1252 * src/modest-mail-operation.c:
1253 (modest_mail_operation_update_account):
1254 Use info->max_size instead of unintialized local var [small
1255 build fix]. (Added TODO to review that change since I don't
1258 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1260 * libmodest-dbus-client/libmodest-dbus-client.c:
1261 (libmodest_dbus_client_compose_mail): function added
1262 * src/dbus_api/modest-dbus-api.h:
1263 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1264 (on_compose_mail): Implementation of the SendAsMail functionality
1266 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1268 * src/modest-account-mgr.c:
1269 (modest_account_mgr_add_server_account): Set the secure-connection
1270 conf key for transport accounts as well as store accounts. I don't know
1271 why the if was there. For instance, this makes sure that we use SSL
1272 for the gmail preset from the easysetup wizard.
1274 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1276 * src/gnome/modest-main-window.c:
1277 (on_account_store_connecting_finished), (connect_signals):
1278 * src/maemo/modest-main-window.c:
1279 (on_account_store_connecting_finished), (connect_signals),
1280 (modest_main_window_new):
1281 Handle TnyAccountStore::connecting-finished instead of
1282 TnyDevice::connection-changed, because we cannot actually perform
1283 operations on accounts until TnyAccountStore has itself responded to
1284 the TnyDevice::connection-changed signal. This prevents a GError from
1286 Do not try to update at startup, because we (at least on scratchbox)
1287 already do an update at startup when the device goes online.
1288 This prevents a GError from tinymail.
1289 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1290 Added TODO about stopping simultaneous operations.
1292 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1295 * src/modest-mail-operation-queue.c:
1296 (modest_mail_operation_queue_remove):
1297 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1298 about where they happened.
1300 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-ui-actions.c:
1303 (modest_ui_actions_on_password_requested): Make sure that the remember
1304 output parameter is always TRUE.
1306 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1308 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1309 Show a OK/Cancel dialog if the error is a question, though we still do not
1310 know anything more about what we are asking the user.
1311 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1312 Fix an uninitialized variable (helper). This is a logic error, however.
1314 2007-05-21 Christian Kellner <ckellner@openismus.com>
1316 * src/modest-search.h:
1317 Correct bit shifting in the ModestSearchFlags enum.
1319 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1321 * src/modest-tny-account.c:
1322 (modest_tny_account_new_from_server_account): Do not use the lsub and
1323 check-all hard-coded IMAP options when using POP.
1325 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1327 * src/modest-tny-account.c:
1328 (modest_tny_account_new_from_server_account):
1329 Use NULL for the secure-auth method for POP when Password auth has been
1330 specified by the user, as we already do for IMAP. "auth=Login" causes
1331 an error from camel or the server.
1333 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-account-settings-dialog.c:
1336 (create_page_account_details),
1337 (modest_account_settings_dialog_set_account_name):
1338 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1339 for the leave-on-server checkbox, rathr than just the checkbox, when
1340 the protocol is not POP.
1342 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1344 * src/widgets/modest-account-view.c:
1345 * src/widgets/modest-account-view.h:
1346 Added modest_account_view_select_account() which will be useful later
1347 to asynchronously re-select the edited account.
1349 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1351 * src/maemo/modest-account-settings-dialog.c:
1352 (modest_account_settings_dialog_set_account_name):
1353 Automatically choose the port numbers based on the secure authentication
1354 methods, if they have not been chosen before.
1355 This fixes projects.maemo.org bug NB#56273 .
1357 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1359 * src/maemo/modest-main-window-ui.h:
1360 * src/modest-ui-actions.c:
1361 * src/modest-ui-actions.h:
1362 Connect the Tools/SMTP Servers menu item to
1363 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1364 SMTP servers dialog, as in the UI specification and saves changes when it
1365 is closed. This fixed projects.maemo.org bug NB#56305 .
1367 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1369 * src/maemo/modest-connection-specific-smtp-window.c:
1370 (modest_connection_specific_smtp_window_init):
1371 Use gtk_window_set_default_size() to make this window big enough, so
1372 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1374 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1376 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1377 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1378 (modest_connection_specific_smtp_edit_window_init),
1379 Do not try to connect to a combobox signal before the combobox exists.
1380 This fixes the cras in projects.maemo.org bug NB#56288 .
1381 (modest_connection_specific_smtp_edit_window_get_settings):
1382 Remove the server_account_name parameter which was being checked for NULL
1383 though it was not used.
1385 * src/maemo/modest-connection-specific-smtp-window.c:
1386 (modest_connection_specific_smtp_window_fill_with_connections),
1387 (on_button_edit), (modest_connection_specific_smtp_window_init):
1388 Correct the number of treemodel columns to prevent a warning.
1389 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1390 libconic does not work.
1392 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1394 * src/modest-tny-account.c:
1395 (modest_tny_account_new_from_server_account):
1396 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1397 SMTP when "None" was chosen by the user. However, with my SMTP server that
1398 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1401 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1404 to explain the memory management issue with the ID in the ModestPair.
1406 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1407 (add_sending_page), (modest_account_assistant_finalize):
1408 * src/gnome/modest-gnome-global-settings-dialog.c:
1409 (create_updating_page), (create_composing_page):
1410 * src/gnome/modest-msg-edit-window.c: (get_transports),
1411 (init_window), (modest_msg_edit_window_finalize),
1412 (modest_msg_edit_window_get_msg_data):
1413 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1414 * src/gnome/modest-transport-widget.c:
1415 (modest_transport_widget_finalize), (smtp_configuration):
1416 * src/maemo/modest-maemo-global-settings-dialog.c:
1417 (create_updating_page), (create_composing_page):
1418 * src/maemo/modest-msg-edit-window.c: (get_transports),
1419 (init_window), (modest_msg_edit_window_finalize),
1420 (modest_msg_edit_window_get_msg_data),
1421 (modest_msg_edit_window_free_msg_data):
1422 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1423 (modest_store_widget_finalize):
1424 * src/maemo/modest-transport-widget.c:
1425 (modest_transport_widget_finalize), (smtp_configuration):
1426 * src/modest-main.c: (send_mail):
1427 * src/widgets/modest-combo-box.h:
1428 * src/widgets/modest-global-settings-dialog-priv.h:
1429 * src/widgets/modest-global-settings-dialog.c:
1430 (modest_global_settings_dialog_finalize):
1431 * src/widgets/modest-msg-edit-window.h:
1432 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1433 as long as the combo box, to prevent use of freed memory for the ID.
1435 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1437 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1438 get_accounts(), to make this clearer. Do not check for the enabled gconf
1439 key, because we do not use this for server accounts (at least, not yet).
1440 This allows us to send email again.
1442 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/modest-platform.c:
1445 (on_modest_conf_update_interval_changed), (modest_platform_init):
1446 Only respond to this particular key change. All these strcmp()s cannot be
1449 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1451 * src/maemo/modest-maemo-global-settings-dialog.c:
1452 (current_connection): Prevent a crash in scratchbox when
1453 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1454 * src/maemo/modest-platform.c:
1455 (on_modest_conf_update_interval_changed), (modest_platform_init):
1456 Get the update interval from gconf and reset it when the gconf key changes.
1458 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1460 * src/modest-protocol-info.c:
1461 * src/modest-protocol-info.h: Adde enum-specific get functions,
1462 instead of using a ModestProtocolType enum parameter.
1464 * src/gnome/modest-account-assistant.c:
1465 * src/gnome/modest-store-widget.c:
1466 * src/gnome/modest-store-widget.h:
1467 * src/gnome/modest-transport-widget.c:
1468 * src/gnome/modest-transport-widget.h:
1469 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1470 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1471 * src/maemo/easysetup/modest-easysetup-wizard.c:
1472 * src/maemo/modest-account-settings-dialog.c:
1473 * src/maemo/modest-account-settings-dialog.h:
1474 * src/maemo/modest-store-widget.c:
1475 * src/maemo/modest-store-widget.h:
1476 * src/maemo/modest-transport-widget.c:
1477 * src/maemo/modest-transport-widget.h:
1478 * src/modest-account-mgr-helpers.c:
1479 * src/modest-account-mgr-helpers.h:
1480 * src/modest-account-mgr.c:
1481 * src/modest-account-mgr.h:
1482 * src/modest-tny-account.c:
1483 * src/modest-tny-folder.c:
1484 * src/widgets/modest-account-view.c:
1485 * src/widgets/modest-retrieve-combo-box.c:
1486 * src/widgets/modest-retrieve-combo-box.h:
1487 * src/widgets/modest-secureauth-combo-box.c:
1488 * src/widgets/modest-serversecurity-combo-box.c:
1489 * src/widgets/modest-serversecurity-combo-box.h:
1490 * tests/check_account-mgr.c:
1491 Use the specific functions, and use the re-renamed enum values for GNOME too.
1493 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1495 * src/modest-pair.h:
1496 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1497 so we can get the second based on the first.
1499 * src/maemo/modest-account-settings-dialog.h:
1500 * src/maemo/modest-account-settings-dialog.c:
1501 Added get_supported_secure_authentication_methods(), though it is mostly
1502 commented-out for now until the necessary API is committed to tinymail.
1503 (modest_account_settings_dialog_set_account_name),
1504 (save_configuration): Request the supported authentication methods from the
1505 server, so we can choose a working method.
1507 * src/modest-tny-account-store.h:
1508 * src/modest-tny-account-store.c:
1509 (modest_tny_account_store_get_session): Rename from
1510 tny_account_store_get_session().
1512 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-protocol-info.h: Split the ModestProtocol enum
1515 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1516 There was no need to have these unrelated values in one enum.
1518 * src/: many files: Adapted to changed enum. This makes the code a bit
1519 clearer, and the compiler could catch some errors.
1521 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1524 Show the detailed internal camel error message when an error happens
1525 during the configuration, so that our testers can give us more clues.
1526 For instance, in projects.maemo.org bug NB#56910 .
1528 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1530 * src/modest-tny-account.c:
1531 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1532 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1534 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1536 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1537 * src/maemo/modest-account-settings-dialog.c:
1538 (modest_account_settings_dialog_set_account_name),
1539 (save_configuration): For the incoming secure authentication checkbox,
1540 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1541 the UI specification. PLAIN does not seem to be supported for most IMAP
1542 servers anyway, and I am not sure what it would mean.
1543 However, we probably need to discover which of the secure-authentication
1544 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1545 * src/modest-account-mgr-helpers.c:
1546 (modest_account_mgr_get_server_account_data):
1548 * src/modest-tny-account.c:
1549 (modest_tny_account_new_from_server_account):
1550 Use tny_account_set_mech() to set secure-authentication methods,
1551 with some special-casing for IMAP, based on my observations of how
1554 * src/modest-account-mgr-helpers.h:
1555 * src/modest-account-mgr.c:
1556 * src/modest-defs.h: Comment that the URI is only used for local folders.
1558 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1560 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1561 parameter const, just to be neat.
1562 * src/modest-text-utils.c: (modest_text_utils_inline):
1563 End g_strconcat() with NULL, as its documentation says. This is almost
1564 certainly the cause of my crash at startup on the device. Interestingly,
1565 valgrind doesn't tell us about these errors.
1567 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1569 * scripts/build-packages: Added more precise comments about how to use
1570 this script, though I still get this error:
1571 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1572 error building tinymail
1574 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1576 * src/maemo/modest-main-window.c: (on_account_update):
1577 Very slight cleanup, hoping to make it simpler to discover what causes
1578 a crash here sometimes.
1580 * src/modest-tny-account.c:
1581 (modest_tny_account_new_from_server_account): Set the port. Added
1582 comments about the options and a TODO comment because I need to find out
1583 how to specify the secure authentication method.
1585 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1587 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1588 changed CFlags paths form modest to libmodest
1590 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-account-mgr-helpers.c:
1593 (modest_account_mgr_get_server_account_data),
1594 (modest_account_mgr_free_server_account_data):
1595 * src/modest-account-mgr-helpers.h:
1596 * src/modest-account-mgr.c:
1597 (modest_account_mgr_add_server_account):
1598 * src/modest-defs.h:
1599 * src/modest-tny-account.c:
1600 (modest_tny_account_new_from_server_account):
1601 Determine the options for tny_camel_account_add_option() here,
1602 based on the settings, rather than storing them directly in gconf.
1604 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1607 Show a more friendly error dialog now that we expect (from the tinymail
1608 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1610 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1612 * src/maemo/modest-main-window.c: (on_account_update): Check that
1613 account_name is not NULL, to prevent a crash at startup that I am
1614 seeing on the N800. I do wonder why it is NULL.
1616 * src/maemo/easysetup/modest-easysetup-wizard.c:
1617 (create_page_user_details):
1618 * src/maemo/modest-account-settings-dialog.c:
1619 (create_page_user_details), (create_page_outgoing):
1620 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1621 (modest_connection_specific_smtp_edit_window_init):
1622 * src/modest-ui-actions.c:
1623 (modest_ui_actions_on_password_requested):
1624 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1625 might do something useful with the on-screen keyboard.
1627 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1629 * src/maemo/modest-main-window.c: (on_account_update):
1630 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1631 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1633 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1635 * src/modest-tny-account-store.c: (on_account_changed):
1636 Correct the signature of this signal handler.
1638 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1640 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1641 Show a HildonNote instead of a GtkDialog for Maemo.
1643 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1645 * src/widgets/modest-account-view.h:
1646 * src/widgets/modest-account-view.c: (on_account_changed),
1647 (on_account_removed). Added a boolean flag, set/unset by
1648 modest_account_view_block_conf_updates(),
1649 modest_account_view_unblock_conf_updates() to prevent unnecessary
1650 updates, but this is not very useful because the gconf notifications are
1651 so delays (maybe only on Maemo Bora).
1652 So auto-updating is turned off, and these functions do an explicit
1653 update when necessary.
1654 However, something else is still doing too much work when adding/removing
1655 accounts, probably in another part of the application.
1657 * src/maemo/modest-account-view-window.c:
1658 (on_delete_button_clicked), (on_edit_button_clicked),
1659 (on_new_button_clicked): Use the new functions.
1661 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-account-mgr-helpers.c:
1664 (modest_account_mgr_set_first_account_as_default):
1665 Sort the list of names alphabetically-by-title, so we choose the first one
1667 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1668 alphabetically by the title.
1670 This fixes projects.maemo.org bug NB#56418 .
1672 * src/modest-account-mgr-priv.c:
1673 (_modest_account_mgr_account_from_key):
1674 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1675 avoid a valgrind error, and possible random behaviour.
1677 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1679 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1680 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1681 tinymail documentation to say that this can be expected.
1682 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1683 pretty, and should not happen, but I would prefer to know when it does.
1685 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1687 * configure.ac: When using the older hildon version, probably on Bora,
1688 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1690 * src/widgets/modest-attachment-view.c:
1691 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1694 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1696 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1697 Implemented the prototype. Can be tested with
1698 tests/dbus_api/test_open_message:
1700 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1702 * src/modest-tny-account-store.c:
1703 (modest_tny_account_store_instance_init), (get_password):
1704 * src/modest-ui-actions.c:
1705 (modest_ui_actions_on_password_requested):
1706 Do not store the password in gconf, because this function is called
1707 for non-remembered passwords. Actually use the cached (in the hash map)
1708 password instead of releasing it.
1709 The password will now not be remembered if it is asked via the protected
1710 password dialog, as per the UI spec.
1712 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-defs.h:
1715 * src/modest-account-mgr-helpers.h:
1716 * src/modest-account-mgr-helpers.c:
1717 Added modest_server_account_get_username_has_succeeded(),
1718 modest_server_account_set_username_has_succeeded().
1719 (modest_server_account_set_username),
1720 Reset the has-succeeded flag if the username changes.
1722 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1723 * src/maemo/modest-connection-specific-smtp-window.c:
1724 (modest_connection_specific_smtp_window_save_server_accounts):
1725 Use modest_server_account_set_username() instead of using
1726 modest_conf_set_string() directly, so that the has-succeeded flag is always
1729 * src/modest-ui-actions.c:
1730 (modest_ui_actions_on_password_requested): Dim the username entry if
1731 the username has ever worked, as per the UI spec.
1733 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1735 * src/modest-tny-account-store.c: (get_password):
1736 * src/modest-ui-actions.c:
1737 (modest_ui_actions_on_password_requested):
1738 Allow the username to be changed too, though there is more work to
1739 be done on exactly how this behaves.
1741 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1743 * src/modest-account-mgr-helpers.h:
1744 * src/modest-account-mgr-helpers.c:
1745 Added modest_account_mgr_get_display_name(),
1746 modest_server_account_get_username(),
1747 modest_server_account_set_username(),
1748 modest_server_account_set_password(),
1749 modest_server_account_get_hostname() functions so we do not need to
1750 use the conf API directly.
1752 * src/maemo/modest-main-window.c: (connect_signals):
1753 Actually connect ot the ModestAccountStore::request-password signal,
1754 so that we show the dialog when the password is requested by Tinymail,
1755 for isntance if it is empty.
1757 * src/modest-marshal.list:
1758 * src/modest-tny-account-store.c:
1759 (modest_tny_account_store_class_init), (get_password),
1760 (modest_tny_account_store_alert):
1761 * src/modest-tny-account-store.h:
1762 * src/modest-ui-actions.h:
1763 * src/modest-ui-actions.c:
1764 (modest_ui_actions_on_password_requested):
1765 Change the signal parameters, so it is obvious that we are providing
1766 the non human-readable server name, and receiving both the username
1767 and password, though changing of the username is not yet implemented.
1768 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1769 for the GNOME version.
1771 This should fix the projects.maemo.org bug NB#56209, though it does not
1772 work on Bora, because the gconf_client_get() for the password fails
1773 immediately after we save it with gconf_client_set().
1775 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1778 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1779 caused an undefined symbol error:
1780 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1782 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1784 * src/modest-tny-account-store.c:
1785 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1786 using a GError instead of a string message, so we can translate it in
1789 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1791 * src/maemo/modest-address-book.c:
1792 (modest_address_book_check_names):
1793 * src/maemo/modest-msg-view-window.c:
1794 (modest_msg_view_window_clipboard_owner_change):
1795 * src/modest-init.c: (modest_init_init_ui):
1796 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1797 (update_folders_cb), (modest_mail_operation_update_account):
1798 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1799 (modest_ui_actions_on_msg_attachment_clicked),
1800 (modest_ui_actions_on_msg_recpt_activated):
1801 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1802 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1803 (modest_msg_view_search_next):
1804 * src/widgets/modest-recpt-editor.c:
1805 (modest_recpt_editor_on_button_release_event),
1806 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1807 g_message(). At this point we should only be seeing interesting errors on
1808 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1810 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1812 (modest_wizard_dialog_force_title_update):
1813 * src/maemo/easysetup/modest-wizard-dialog.h:
1814 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1815 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1816 can update the title when appropriate. Otherwise the title is wrong if the
1817 pages are added after adding the notebook to the dialog.
1818 This must be a problem in HildonWizardDialog too.
1819 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1821 * src/maemo/easysetup/modest-easysetup-wizard.c:
1822 (create_subsequent_customsetup_pages),
1823 (create_subsequent_easysetup_pages):
1824 Call modest_wizard_dialog_force_title_update() so that the title is
1825 correct even with GTK+ < 2.10.
1826 This fixes projects.maemo.org bug NB#56145 .
1828 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1830 * src/maemo/modest-platform.c:
1831 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1832 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1835 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1837 * src/widgets/modest-window.h:
1838 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1839 and modest_window_save_state(), which invokes it.
1841 * src/widgets/modest-window-mgr.h:
1842 * src/widgets/modest-window-mgr.c:
1843 Added modest_window_mgr_save_state_for_all_windows(), which calls
1844 the save_state vfunc on all registered windows, if implemented.
1846 * src/gnome/modest-msg-edit-window.c:
1847 * src/gnome/modest-msg-view-window.c:
1848 * src/maemo/modest-msg-edit-window.c:
1849 * src/maemo/modest-msg-view-window.c:
1850 * src/maemo/modest-main-window.c:
1851 Specify the existing save_settings functions as implementations of
1852 ModestWindow::save_state_func().
1854 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1855 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1856 enabling hibernation, for instance.
1858 We may need to do the same thing for restoring settings.
1861 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1863 * src/widgets/modest-window-mgr.c:
1864 * src/widgets/modest-window-mgr.h:
1865 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1866 modest_window_mgr_get_hibernation_is_prevented().
1868 * src/maemo/modest-main-window.c:
1869 (on_hildon_program_is_topmost_notify): Prevent hibernation
1870 (possible when the application goes to the background in the WM),
1871 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1873 * src/maemo/easysetup/modest-easysetup-wizard.c:
1874 (modest_easysetup_wizard_dialog_init):
1875 * src/maemo/modest-account-settings-dialog.c:
1876 (modest_account_settings_dialog_init):
1877 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1878 (modest_connection_specific_smtp_edit_window_init):
1879 * src/maemo/modest-connection-specific-smtp-window.c:
1880 (modest_connection_specific_smtp_window_init):
1881 * src/maemo/modest-signature-editor-dialog.c:
1882 (modest_signature_editor_dialog_init):
1883 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1884 prevent hibernation while any of these account settings dialogs are open.
1886 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1888 * src/maemo/Makefile.am:
1889 * src/maemo/modest-osso-state-saving.c:
1890 * src/maemo/modest-osso-state-saving.h: Added
1891 modest_osso_load_state() and modest_osso_save_state() though they do
1892 nothing now. They should iterate through all the open windows and load/save
1894 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1895 save state when closing.
1897 * src/maemo/modest-main-window.c:
1898 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1899 Add a notification handler for the HildonProgram::is-topmost property,
1900 so we can allow hibernation when the application goes into the background.
1901 But we still need to detect when the accounts setup windows are open so
1902 we can stop hibernation when they are open.
1903 To do this, I also added the main window the HildonProgram. This might have
1904 other side-effects/benefits, and should maybe be done for other windows.
1906 * src/maemo/modest-osso-autosave-callbacks.h:
1907 * src/maemo/modest-osso-autosave-callbacks.c:
1908 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1909 though it does not do anything yet, and we might never need this to do
1910 anything. For instance, we already save drafts.
1912 * src/maemo/modest-platform.c: (modest_platform_init):
1913 Specify the libosso auto-save callback.
1915 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1917 * src/maemo/modest-platform.c:
1918 (modest_platform_set_update_interval):
1919 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1920 aparently stays valid between application instances, so we can use this
1921 to remove and reset it later. According to a maemo-developers email from
1924 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1926 * configure.ac: Depend on libalarm for Maemo.
1928 * src/dbus_api/modest-dbus-api.h:
1929 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1930 (on_send_receive), (modest_dbus_req_handler):
1931 Handle a SEND_RECEIVE D-Bus method.
1933 * libmodest-dbus-client/libmodest-dbus-client.c:
1934 (libmodest_dbus_client_send_and_receive):
1935 * libmodest-dbus-client/libmodest-dbus-client.h:
1936 Add C convenience functions for calling the new D-Bus method.
1938 * src/modest-platform.h:
1939 * src/gnome/modest-platform.c:
1940 * src/maemo/modest-platform.c:
1941 Added modest_platform_set_update_interval(), which uses the
1942 alarmd API on Maemo.
1943 (modest_platform_init),
1944 Call modest_platform_set_update_interval(), using a hard-coded
1945 interval for now (until the global settings dialog is implemented),
1946 though I am not sure that this makes sense yet.
1948 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1950 * src/dbus_api/modest-dbus-callbacks.c:
1951 (modest_osso_cb_hw_state_handler):
1952 * src/dbus_api/modest-dbus-callbacks.h:
1953 * src/maemo/modest-platform.c: (modest_platform_init):
1954 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1955 in case this has some effect on the ability for Maemo to ping the
1958 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1961 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1962 warning. It is probably a logic error, but I need to fix the build.
1964 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-account-mgr.h:
1967 * src/modest-account-mgr.c:
1968 (modest_account_mgr_account_names): Add a gboolean enabled_only
1969 parameter, so we can get lists of onlt the enabled accounts.
1971 (modest_account_mgr_add_account),,
1972 (modest_account_mgr_account_with_display_name_exists):
1973 * src/maemo/modest-msg-edit-window.c: (get_transports):
1974 * src/modest-account-mgr-helpers.c:
1975 (modest_account_mgr_set_first_account_as_default):
1976 * src/modest-init.c: (init_default_account_maybe):
1977 * src/modest-tny-account-store.c: (get_accounts):
1978 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1979 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1980 * tests/check_account-mgr.c: (START_TEST):
1981 Provide the extra parameter, as appropriate.
1983 * src/widgets/modest-account-view.c: (update_account_view):
1984 Do not show disabled accounts (meaning that there is no way to
1985 enable/disable accounts in the UI (the feature is not in our UI
1986 specification), so we can use this internally only to mark unfinished
1987 or temporary account data.
1989 * src/maemo/easysetup/modest-easysetup-wizard.c:
1990 (create_account): Add boolean enable parameter, so we can specify FALSE
1991 to create the temporary account.
1992 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1993 (on_before_next): When finishing, when there is a temporary account, just
1995 Also, use a timeout to delay the showing of the dialog until gconf is likely
1996 to return correct information, due to a maemo gconf bug that is fixed in
1997 osso 1.1, but not yet in Bora.
1998 However, the dialog stays on screen after it is destroyed.
2000 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2001 for invalid data when cancelling. Use a hildon note instead of a dialog
2002 to complain about invalid data. Do not show the account-saved note if the
2003 account is disabled (a temporary account that will not really be saved for use
2006 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-account-mgr-helpers.h:
2009 * src/modest-account-mgr-helpers.c:
2010 Added modest_account_mgr_unset_default_account(),
2011 Added modest_account_mgr_set_first_account_as_default().
2013 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2014 If it was the default account, unset the default account name.
2016 * src/maemo/modest-account-view-window.c:
2017 (on_delete_button_clicked): If it was the default account,
2018 set the first remaining account as the default instead.
2020 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2021 a NULL account or a NULL default account, to prevent a crash. This should
2022 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2025 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2027 * src/widgets/modest-recpt-editor.c:
2028 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2029 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2030 TODO comment for this. This fixes the build.
2032 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2033 be the best place for it. This will in future update all auto-update accounts,
2034 rather than just the current/default account, when that gconf key exists.
2035 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2036 if there are no accounts, before calling do_send_receive().
2037 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2039 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2040 * src/maemo/modest-main-window-ui.h:
2041 * src/maemo/modest-main-window.c: (on_connection_changed),
2042 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2043 directly, becaue the signal handler does more.
2045 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2047 * src/modest-account-mgr-helpers.c:
2048 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2049 for the case that the account does not exist.
2051 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2052 (equivalent to the modest account name) rather than the tinymail account name
2053 (equivalent to the modest account title - human readable) to get the account data.
2054 Check for null account data to prevent the crash, and add a TODO comment saying that
2055 this needs fixing because it is using the server account name instead of the account name.
2057 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2059 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2060 * src/maemo/modest-account-settings-dialog.c: (show_error),
2062 Use hildon_note_new_information() for informative and error messages,
2063 which seems to be expected for Maemo applications (no documentation that I know of
2064 says this). I am surprised that there is no distinction between info and error
2067 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2069 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2070 it is easy to find where this is used.
2072 * src/maemo/easysetup/modest-easysetup-wizard.c:
2073 (create_page_welcome), (create_page_account_details),
2074 (create_page_user_details), (create_page_complete_easysetup),
2075 (create_page_custom_incoming), (create_page_custom_outgoing),
2076 (create_page_complete_custom):
2077 * src/maemo/modest-account-settings-dialog.c:
2078 (create_page_account_details), (create_page_user_details),
2079 (create_page_incoming), (create_page_outgoing):
2080 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2081 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2082 (modest_connection_specific_smtp_edit_window_init):
2083 * src/maemo/modest-connection-specific-smtp-window.c:
2084 (modest_connection_specific_smtp_window_init):
2085 * src/maemo/modest-signature-editor-dialog.c:
2086 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2087 and scrolling policy as per the Email Application Layout Guide, if I have
2090 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2093 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2094 which were empty, because these vfuncs have been removed from TnyAccountStore.
2095 This fixes the build.
2097 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2099 * src/maemo/modest-main-window.c:
2100 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2101 showing/hiding it. Added TODO because it probably should not be NULL.
2102 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2103 because unnecessary g_warnings() make degugging difficult.
2105 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2107 * src/maemo/modest-msg-edit-window.c:
2108 (modest_msg_edit_window_select_color),
2109 (modest_msg_edit_window_select_background_color): 2 const corrections and
2110 moving 2 #endifs before closing brackets, to fix the build.
2112 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2114 * src/maemo/easysetup/modest-easysetup-wizard.h:
2115 * src/maemo/easysetup/modest-easysetup-wizard.c:
2116 (modest_easysetup_wizard_dialog_finalize),
2117 (on_button_edit_advanced_settings), (create_page_complete_custom),
2118 (on_response), (create_account):
2119 Implement the Advanced Settings edit button, by saving the account information,
2120 for the Advanded Settings dialog to use directly from gconf, and removing it
2121 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2122 Bug #5533 in the projects.maemo.org bugzilla.
2124 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2126 * src/maemo/modest-msg-view-window.c:
2127 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2128 when opening a message window.
2130 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2132 * src/maemo/easysetup/modest-easysetup-wizard.c:
2133 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2136 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2137 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2138 gconf settings. I probably added more checks than necessary, but that is safer.
2140 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2141 variable to fix the build, but this seems to be used when it is still NULL.
2143 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2145 * src/modest-platform.h:
2146 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2147 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2148 * src/modest-main.c: Implement this function so we can avoid using
2149 maemo-specific API from cross-platform code.
2151 * src/modest-tny-account-store.c:
2152 (get_smtp_specific_transport_account_for_open_connection):
2153 * src/modest-ui-actions.c: (check_for_connection),
2154 (modest_ui_actions_on_item_not_found):
2155 Use modest_platform_connect_and_wait() and put #idefs around other
2156 maemo-specific code, because only maemo currently has a way to
2157 identify connection names.
2159 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2161 * src/modest-tny-account-store.h:
2162 * src/modest-tny-account-store.c:
2163 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2164 the connection-specific SMTP server settings in the configuration.
2166 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2168 * src/maemo/modest-main-window.c: (on_connection_changed),
2170 * src/modest-main.c: (main), (start_ui), (send_mail):
2171 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2172 that is what is intended.
2174 * src/modest-ui-actions.c: (action_send), (action_receive),
2175 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2176 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2177 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2178 SMTP server is used when it is specified.
2180 (modest_ui_actions_on_send_receive):
2181 Check that a connection is open before proceeding.
2182 Receive and then send, instead of vice-versa, as per the specification.
2184 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2186 * src/modest-mail-operation.c:
2187 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2188 though I guess it should be something other than NULL.
2190 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2192 * src/maemo/easysetup/modest-easysetup-wizard.c:
2193 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2194 combo twice, to avoid an g_warning and to make it visible again.
2195 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2196 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2197 (already intended) dereference when detaching, because we then recreate the menu.
2198 But I am not sure why the warning was happening, and it is possible that this is a memory
2201 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2203 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2204 and uri_parse_mailto() utility functions.
2205 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2207 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2209 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2211 * src/dbus_api/modest-dbus-api.h:
2212 * src/dbus_api/modest-dbus-callbacks.c:
2213 Use an idle callback to execute the modest code in the application's own thread.
2214 Remove the helloworld example method.
2215 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2216 parsed, and the open-message method is not implemented because this is not yet implemented in
2218 * libmodest-dbus-client/libmodest-dbus-client.c:
2219 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2220 (libmodest_dbus_client_open_message):
2221 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2223 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2224 body without crashing.
2226 * tests/dbus_api/Makefile.am:
2227 * tests/dbus_api/test_mail_to.c:
2228 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2230 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2232 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2233 Added file to fix the build. Sorry.
2235 * src/dbus_api/Makefile.am:
2236 * src/dbus_api/modest-dbus-api.h:
2237 * src/dbus_api/modest-dbus-callbacks.h:
2238 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2239 (modest_dbus_req_handler):
2240 Put constants in a separate header so it can be reused by the
2241 client library, without duplication
2243 * libmodest-dbus-client/Makefile.am:
2244 * libmodest-dbus-client/libmodest-dbus-client.c:
2245 (libmodest_dbus_client_call_helloworld),
2246 (libmodfest_dbus_client_send_mail),
2247 (libmodfest_dbus_client_mailto),
2248 (libmodfest_dbus_client_open_message):
2249 * libmodest-dbus-client/libmodest-dbus-client.h:
2250 (Partly) Implement a send_mail D-Bus method.
2252 * tests/dbus_api/Makefile.am:
2253 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2254 the send_email D-Bus method.
2256 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2260 * libmodest-dbus-client/Makefile.am:
2261 * libmodest-dbus-client/libmodest-dbus-client.c:
2262 * libmodest-dbus-client/libmodest-dbus-client.h:
2263 * tests/dbus_api/Makefile.am:
2264 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2265 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2267 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2269 * src/maemo/easysetup/modest-easysetup-wizard.c:
2270 (create_page_account_details):
2271 * src/maemo/modest-account-settings-dialog.c:
2272 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2273 widgets, because this might not be the default in future versions of the Maemo GTK+.
2274 However, I can not not get capitalization to work even in a simple test case.
2276 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2278 * src/maemo/easysetup/modest-easysetup-wizard.c:
2279 (create_page_custom_incoming), (create_page_custom_outgoing):
2280 * src/maemo/modest-account-settings-dialog.c:
2281 (create_page_account_details), (create_page_incoming),
2282 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2283 instead of using gtk_check_button_with_label(), so they are aligned like the other
2284 widgets, as per the UI spec.
2286 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2288 * src/maemo/easysetup/modest-easysetup-wizard.c:
2289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2290 * src/widgets/modest-validating-entry.c:
2291 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2292 Modest prefix instead of an EasySetup prefix.
2294 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2296 * src/widgets/modest-validating-entry.h:
2297 * src/widgets/modest-validating-entry.c: (on_insert_text),
2298 Added easysetup_validating_entry_set_max_func(), used to set a callback
2299 to call when the max number of characters is reached. GtkEntry has a max-length
2300 already but is silent about it.
2302 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2303 (create_page_account_details), (create_page_user_details),
2305 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2306 (create_page_account_details), (create_page_user_details),
2307 (create_page_outgoing):
2308 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2309 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2310 the UI spec, when the user tries to enter more than the max number of characters.
2312 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2314 * src/maemo/easysetup/modest-easysetup-wizard.c:
2315 (create_page_user_details), (create_page_custom_incoming),
2316 (create_page_custom_outgoing):
2317 * src/maemo/modest-account-settings-dialog.c:
2318 (create_page_user_details), (create_page_incoming),
2319 (create_page_outgoing):
2320 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2321 (modest_connection_specific_smtp_edit_window_init):
2322 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2323 not appropriate. Bad Maemo-specific defaults!.
2325 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2328 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2329 (modest_signature_editor_dialog_set_settings):
2330 Disable the label and textview when the checkbox is disabled, and use the
2331 specified (UI spec) default signature text.
2333 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2335 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2336 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2338 * src/modest-defs.h:
2339 * src/modest-account-mgr-helpers.h:
2340 * src/modest-account-mgr-helpers.c:
2341 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2343 * src/maemo/Makefile.am:
2344 * src/maemo/modest-signature-editor-dialog.c:
2345 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2348 * src/maemo/modest-account-settings-dialog.h:
2349 * src/maemo/modest-account-settings-dialog.c:
2350 (modest_account_settings_dialog_finalize), (on_button_signature),
2351 (save_configuration): Use the new dialog when the Edit button is pressed, and
2352 save the changes if necessary, as per the UI spec.
2354 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2356 * src/maemo/Makefile.am:
2357 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2358 based on maemo-develoers email from Dirk.
2360 * src/maemo/easysetup/modest-easysetup-wizard.c:
2361 (create_page_welcome), (create_page_account_details),
2362 (create_page_user_details), (create_page_complete_easysetup),
2363 (create_page_custom_incoming), (create_page_custom_outgoing),
2364 (create_page_complete_custom),
2365 (modest_easysetup_wizard_dialog_init):
2366 * src/maemo/modest-account-settings-dialog.c:
2367 (create_page_account_details), (create_page_user_details),
2368 (create_page_incoming), (create_page_outgoing),
2369 (modest_account_settings_dialog_init):
2370 * src/maemo/modest-connection-specific-smtp-window.c:
2371 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2373 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2375 * src/maemo/easysetup/modest-easysetup-wizard.c:
2376 (create_page_account_details), (create_page_custom_outgoing),
2377 (create_page_complete_custom):
2378 * src/maemo/modest-account-settings-dialog.c:
2379 (create_page_user_details), (create_page_incoming),
2380 (create_page_outgoing):
2381 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2382 (modest_connection_specific_smtp_edit_window_init):
2383 Use the correct (UI spec) port min/max, and use horizontal separators,
2386 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2388 * src/maemo/easysetup/modest-easysetup-wizard.c:
2389 (set_default_custom_servernames):
2390 * src/maemo/modest-account-settings-dialog.c:
2391 (create_page_incoming), (on_combo_outgoing_security_changed),
2392 (on_combo_incoming_security_changed), (create_page_outgoing),
2393 (modest_account_settings_dialog_set_account_name),
2394 (save_configuration):
2395 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2396 (on_combo_security_changed),
2397 (modest_connection_specific_smtp_edit_window_init),
2398 (modest_connection_specific_smtp_edit_window_set_connection),
2399 (modest_connection_specific_smtp_edit_window_get_settings):
2400 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2403 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2406 * src/maemo/easysetup/modest-easysetup-wizard.c:
2407 (create_page_custom_outgoing), (create_page_complete_custom):
2408 * src/maemo/modest-account-settings-dialog.c:
2409 (create_page_user_details), (create_page_outgoing):
2410 * src/maemo/modest-account-view-window.c: (button_box_new):
2411 Use changed logical IDs as per the most recent UI spec:
2412 mcen_bd_emailsetup_edit -> mcen_bd_edit
2413 mcen_bd_emailsetup_delete -> mcen_bd_delete
2414 mcen_bd_emailsetup_close -> mcen_bd_close
2416 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2420 * src/dbus_api/Makefile.am:
2421 * src/dbus_api/modest-dbus-callbacks.c:
2422 * src/dbus_api/modest-dbus-callbacks.h:
2423 * src/maemo/modest-platform.c: (modest_platform_init):
2424 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2426 * tests/Makefile.am:
2427 * tests/dbus_api/Makefile.am:
2428 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2430 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2432 * src/maemo/modest-account-settings-dialog.c:
2433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2434 Removed unnecessary includes.
2436 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2438 * src/maemo/easysetup/modest-easysetup-wizard.c:
2439 * src/maemo/modest-account-settings-dialog.c:
2440 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2441 * src/widgets/Makefile.am:
2442 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2443 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2444 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2445 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2446 * src/widgets/modest-secureauth-combo-box.c:
2447 * src/widgets/modest-secureauth-combo-box.h:
2448 * src/widgets/modest-serversecurity-combo-box.c:
2449 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2450 made the GObject names more consistent with the rest of the Modest code.
2452 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2454 * src/maemo/easysetup/Makefile.am:
2455 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2456 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2457 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2458 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2459 * src/maemo/easysetup/modest-easysetup-wizard.c:
2460 * src/maemo/easysetup/modest-validating-entry.c:
2461 * src/maemo/easysetup/modest-validating-entry.h:
2462 * src/maemo/modest-account-settings-dialog.c:
2463 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2464 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2465 widgets/ because they are used outside of easysetup too. After checking in,
2466 svn will allow me to rename them too.
2468 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2470 * src/gnome/modest-msg-edit-window.c:
2471 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2472 linker error, to fix the build on the GNOME platform.
2473 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2474 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2475 ifdefed out to avoid a warning.
2477 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2479 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2480 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2481 some alternative for GTK+ 2.6.
2483 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2485 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2487 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2488 specified for EmailAccountsDialog in UI spec.
2490 * src/maemo/easysetup/modest-easysetup-wizard.c:
2491 * src/maemo/easysetup/modest-easysetup-wizard.h:
2492 * src/maemo/modest-account-settings-dialog.c:
2493 * src/maemo/modest-account-settings-dialog.h:
2494 Reuse a member window widget for the connection-specific SMTP server accounts,
2495 so we can tell it to create/save the accounts only if we actually save changes.
2497 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2498 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2499 (modest_connection_specific_smtp_edit_window_get_settings):
2500 Return a struct instance for temporarily remembering the entered data.
2502 * src/maemo/modest-connection-specific-smtp-window.h:
2503 * src/maemo/modest-connection-specific-smtp-window.c:
2504 (modest_connection_specific_smtp_window_finalize),
2505 (modest_connection_specific_smtp_window_fill_with_connections),
2507 (modest_connection_specific_smtp_window_save_server_accounts),
2508 (update_model_server_names): Do not actually save data until asked,
2509 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2511 (on_selection_changed),
2512 (modest_connection_specific_smtp_window_init): Disable the edit
2513 button when nothing is selected.
2515 * src/modest-account-mgr-helpers.c:
2516 * src/modest-account-mgr-helpers.h:
2517 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2520 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2522 * src/modest-account-mgr-helpers.h:
2523 * src/modest-account-mgr-helpers.c:
2524 (modest_account_mgr_get_unused_account_name),
2525 (modest_account_mgr_get_unused_account_display_name): Added these
2526 utility functions, to avoid code duplication.
2528 * src/maemo/easysetup/modest-easysetup-wizard.c:
2529 (create_page_account_details), (create_account):
2530 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2531 (on_combo_security_changed),
2532 (modest_connection_specific_smtp_edit_window_init),
2533 (modest_connection_specific_smtp_edit_window_save_settings):
2534 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2535 * src/maemo/modest-connection-specific-smtp-window.c:
2536 (modest_connection_specific_smtp_window_finalize),
2537 (modest_connection_specific_smtp_window_fill_with_connections),
2538 (on_button_edit), (modest_connection_specific_smtp_window_init):
2539 * src/maemo/modest-connection-specific-smtp-window.h:
2540 Implementing saving of connection-specific server accounts.
2542 But I need to refactor this so we can save the data for each
2543 possible connection-specific account and only actually create the server accounts
2544 when the easysetup finished, or the OK button is pressed on the account settings
2547 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2549 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2550 (on_combo_security_changed):
2551 (modest_connection_specific_smtp_edit_window_init):
2552 Auto-fill the port number as in the account settings.
2554 (modest_connection_specific_smtp_edit_window_set_connection):
2555 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2556 * src/maemo/modest-connection-specific-smtp-window.c:
2557 (fill_with_connections), (on_button_edit),
2558 (modest_connection_specific_smtp_window_init):
2559 Turn the edit window into a dialog to simplify the code, and
2560 set a WM hint as in a GtkDialog, because only a popup can be on top of
2561 another window in Maemo, and popups usually have no WM decoration.
2563 * src/modest-defs.h:
2564 * src/modest-account-mgr-helpers.c:
2565 (modest_account_mgr_set_connection_specific_smtp),
2566 (modest_account_mgr_remove_connection_specific_smtp),
2567 (modest_account_mgr_get_connection_specific_smtp):
2568 * src/modest-account-mgr-helpers.h: Some functions to write the
2569 connection-specific SMTP server information. Not yet used.
2572 * src/widgets/modest-folder-view.c: (text_cell_data):
2573 Fix a warning about an uninitialized variable.
2574 (on_configuration_key_changed): Put an #ifdef around the use
2575 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2577 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2579 * src/maemo/modest-account-settings-dialog.h:
2580 * src/maemo/modest-account-settings-dialog.c:
2581 Added connect_for_modified() utility function to mark the new modified boolean.
2583 (create_page_account_details), (create_page_user_details),
2584 (create_page_incoming), (create_page_outgoing), (on_response),
2585 (modest_account_settings_dialog_init),
2586 (modest_account_settings_dialog_set_account_name):
2587 Only warn about unsaved changes when there are actually unsaved changes.
2589 * src/modest-account-mgr-helpers.c:
2590 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2591 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2592 to get the data from there in future.
2594 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2596 * src/modest-defs.h:
2598 * src/modest-account-mgr-helpers.h:
2599 * src/modest-account-mgr-helpers.c:
2600 Store the security account setting in a single conf key instead of using
2601 the options list, so that the list is left for just the to-be-removed camel hack,
2602 and because gconf_client_set_list() is failing for some reason.
2604 * src/modest-account-mgr.c:
2605 (modest_account_mgr_add_server_account):
2606 * src/maemo/modest-account-settings-dialog.c:
2607 (modest_account_settings_dialog_set_account_name),
2608 (save_configuration): Use the renamed functions.
2611 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2613 * src/widgets/Makefile.am:
2614 * src/widgets/modest-limit-retrieve-combo-box.c:
2615 * src/widgets/modest-limit-retrieve-combo-box.h:
2616 * src/widgets/modest-retrieve-combo-box.c:
2617 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2618 the account settings dialog.
2620 * src/modest-defs.h:
2621 * src/modest-account-mgr-helpers.h:
2622 * src/modest-account-mgr-helpers.c:
2623 (modest_server_account_get_option_secure_auth),
2624 (modest_server_account_set_option_secure_auth):
2625 * src/modest-account-mgr.c:
2626 (modest_account_mgr_add_server_account):
2627 Use the existing AUTH_MECH conf key for the secure-auth setting,
2628 instead of putting it in the list options, because this was actually used already.
2630 * src/maemo/modest-account-settings-dialog.c:
2631 (create_page_account_details),
2632 (modest_account_settings_dialog_set_account_name),
2633 (save_configuration):
2634 * src/maemo/modest-account-settings-dialog.h:
2635 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2636 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2638 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2640 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2641 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2642 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2644 * src/modest-defs.h:
2645 * src/maemo/modest-account-settings-dialog.c:
2646 (create_page_incoming), (on_combo_outgoing_security_changed),
2647 (on_combo_incoming_security_changed), (create_page_outgoing),
2648 (modest_account_settings_dialog_set_account_name),
2649 (save_configuration): Load/Save the port number, and change it when the
2650 security combo changes, to suitable defaults.
2652 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2654 * src/modest-account-mgr.c:
2655 (modest_account_mgr_add_server_account): Set the security and secure-auth
2656 options, and add a comment saying that the other camel-specific options should be
2659 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2661 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2663 * src/modest-tny-account-store.c: (account_list_free),
2664 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2665 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2668 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2670 * src/modest-protocol-info.c:
2671 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2672 is required by our UI spec. Maybe something in our implementation will use this eventually.
2673 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2674 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2675 instead of the previous 0 placeholder.
2677 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2678 secure-auth settings.
2679 * src/modest-account-mgr-helpers.h:
2680 * src/modest-account-mgr-helpers.c:
2681 (modest_server_account_data_get_option_secure_auth),
2682 (modest_server_account_set_option_secure_auth),
2683 (modest_server_account_data_get_option_security),
2684 (modest_server_account_set_option_security): Added this API for getting and setting the security
2685 and secure-auth settings.
2687 * src/maemo/modest-account-settings-dialog.h:
2688 * src/maemo/modest-account-settings-dialog.c:
2689 (modest_account_settings_dialog_finalize), (check_data),
2690 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2691 about changing titles.
2692 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2693 (save_configuration): Save the security and secure-auth settings.
2695 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2696 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2698 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2700 * src/modest-defs.h:
2701 * src/modest-account-mgr.c:
2702 (modest_account_mgr_add_server_account):
2703 Added and used defines for the options key and value pair strings,
2704 that are used so far, though they do not seem to correspond to anything in our
2705 UI specs or ModestProtocol enum.
2707 * src/modest-account-mgr-helpers.h:
2708 * src/modest-account-mgr-helpers.c:
2709 (compare_option_strings_for_name),
2710 (modest_server_account_data_get_option_value),
2711 (modest_server_account_data_get_option_bool),
2712 (modest_account_mgr_get_server_account_option):
2713 Added helper functions for parsing the options GSList.
2715 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2717 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2718 display name is based on the supplied account name.
2719 * src/modest-account-mgr.c:
2720 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2721 with an inefficient, but good-enough, implementation.
2723 * src/maemo/easysetup/modest-easysetup-wizard.c:
2724 (create_page_account_details), (on_before_next), (create_account):
2725 Check for existing display names rather than (non-user-visible) account names, and just
2726 create and set a unique account name at the end.
2728 * src/maemo/modest-account-settings-dialog.c:
2729 (modest_account_settings_dialog_init),
2730 (modest_account_settings_dialog_set_account_name),
2731 (create_page_incoming): Show the display name, instead of the account name.
2732 (on_response): Do some (not all) extra checks, as in the UI spec.
2733 (save_configuration): Save the display name if it was changed.
2735 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2737 * po/en_GB.po: Added needed logical ID and translation.
2738 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2739 (init_view): Made the is-default column clicking work.
2741 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2744 * src/maemo/easysetup/Makefile.am:
2745 * src/maemo/easysetup/modest-easysetup-wizard.c:
2746 (modest_easysetup_wizard_dialog_init):
2747 * src/maemo/easysetup/provider-data-test.keyfile:
2748 * src/maemo/easysetup/provider-data.keyfile:
2749 Moved the provider data file to the new modest-providers-data package and used it from there.
2751 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2753 * src/modest-local-folder-info.c:
2754 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2755 N_() was already used on the static strings, but this just marks it for translation without
2756 using the translation.
2758 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/modest-account-settings-dialog.c:
2761 (create_page_incoming),
2762 (modest_account_settings_dialog_set_account_name):
2763 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2764 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2765 I will do this if nobody else gets there first.
2767 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2769 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2770 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2771 save the security stuff.
2773 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2775 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2776 Set the email address and user fullname, which I now see must be
2779 * src/maemo/modest-account-settings-dialog.h:
2780 * src/maemo/modest-account-settings-dialog.c:
2782 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2783 leave-on-server and authentication.
2784 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2787 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2790 * src/maemo/modest-account-settings-dialog.c:
2791 * src/maemo/modest-account-settings-dialog.h:
2792 Most (but not all) of the widgets are now present as specified by the UI spec.
2793 No changes are yet saved, and some details are not properly shown yet.
2795 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2797 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/Makefile.am:
2800 * src/maemo/modest-account-settings-dialog.c:
2801 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2802 an existing account. Doesn't do much yet.
2804 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2805 Open the accounts settings dialog when Edit is clicked.
2807 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2809 * src/maemo/easysetup/Makefile.am:
2810 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2812 * src/maemo/easysetup/modest-easysetup-wizard.c:
2813 (modest_easysetup_wizard_dialog_init):
2814 Try to get the source directory from the build system,
2815 instead of hard-coding "./" into the source code, when opening our local
2816 copies of the configuration files.
2817 But this still fails when opening the wizard from the Accounts window,
2818 maybe because the working directory seems to change at runtime.
2819 So the wizard will fail the second time unless you copy the files into their
2820 proper locations - see the stdout warnings for the paths.
2822 (create_page_account_details),(on_before_next):
2823 Check for existing non-server accounts instead of server accounts,
2824 so the default account name is useful again, and to prevent trying to
2827 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2828 Show the wizard when New is clicked.
2830 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2831 (init_view): Show the column headers, and show the columns that are
2832 specified in the UI specs. However, something in Maemo's GTK+ prevents
2833 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2834 change the default account. This is despite unsetting the special properties.
2836 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2838 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2839 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2840 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2841 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2842 to make that clearer.
2843 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2845 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2847 * src/maemo/modest-account-view-window.c:
2848 (modest_account_view_window_init),
2849 (modest_account_view_window_new):
2850 Use the same buttons as specified in the
2851 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2852 the existing widgets, which never had a chance of working.
2853 Put the ModestAccountView treeview in a scrolled window.
2854 Do not repeat the initialization in both _init() and _new().
2856 * src/widgets/modest-account-view.c: (update_account_view):
2857 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2858 this widget and window shows no accounts.
2860 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2862 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2864 * src/maemo/easysetup/modest-easysetup-wizard.c:
2865 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2866 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2867 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2870 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2871 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2872 accounts exist yet, as in the UI spec.
2874 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2876 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/Makefile.am:
2879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2880 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2881 New window for editing connection-specific smtp details.
2882 Not fully implemented.
2884 * src/maemo/modest-connection-specific-smtp-window.c:
2885 (modest_connection_specific_smtp_window_finalize) :
2886 unref the tree model.
2887 (on_button_edit): Show the edit window.
2889 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2891 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2894 * src/maemo/Makefile.am:
2895 * src/maemo/modest-connection-specific-smtp-window.c:
2896 * src/maemo/modest-connection-specific-smtp-window.h:
2897 New window for showing the list of connections, for connection-specific
2898 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2899 * src/maemo/easysetup/modest-easysetup-wizard.c:
2900 (create_page_custom_outgoing): Show the new window when the button is clicked.
2902 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2904 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2905 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2906 * src/maemo/modest-msg-edit-window.c:
2907 (modest_msg_edit_window_insert_image):
2908 * src/modest-conf.c: (modest_conf_key_escape):
2909 * src/modest-mail-operation.c:
2910 (modest_mail_operation_send_new_mail):
2911 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2912 (modest_ui_actions_on_new_account):
2913 * src/widgets/modest-attachment-view.c: (update_filename_request):
2914 * src/widgets/modest-mail-header-view.c:
2915 Corrected warnings that were breaking the build, by commenting out unused variables,
2916 and a function, and by including a header.
2918 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2920 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2921 so we can #ifdef around platform-specific code when necessary.
2922 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2923 to allow this to build for the GNOME platform too.
2925 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2927 * src/maemo/easysetup/modest-easysetup-wizard.c:
2928 Added util_increment_name() and used it in create_page_account_details()
2929 to make sure that the default account name is always a new name.
2931 (modest_easysetup_wizard_dialog_init),
2932 (set_default_custom_servernames): Some minor memory management fixes.
2934 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2938 * src/modest-runtime.c: (init_i18n): Restored the translation
2939 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2940 are defined in config.h, and the translations are installed.
2942 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2943 is defined for translation.
2945 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2947 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2949 * src/maemo/easysetup/modest-easysetup-wizard.c:
2950 (modest_easysetup_wizard_dialog_init):
2951 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2952 Use realistic paths (though they should use $prefix generically) to the
2953 mcc_mapping and provider-data.keyfile files which might work when they
2954 are installed by the future version of the operator-wizard package,
2955 and then fallback to paths in our source code, with an explanatory
2958 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2962 * src/maemo/Makefile.am:
2963 * src/maemo/easysetup/: Added files from the previously-exernal
2964 osso-modest-easysetup.
2965 * src/maemo/modest-main-window-ui.h:
2966 * src/modest-ui-actions.c:
2967 * src/modest-ui-actions.h:
2968 Added modest_ui_actions_on_new_account() as a signal handler for the
2969 New Account menu item. It shows the easysetup wizard.
2970 * po/en_GB.po: Added additional needed logical IDs and translations.
2972 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2973 Apparently ChangeLog is not used for some vague Nokia legal reasons.