1 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3 * src/modest-platform.h:
4 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
5 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
6 * src/modest-main.c: Implement this function so we can avoid using
7 maemo-specific API from cross-platform code.
9 * src/modest-tny-account-store.c:
10 (get_smtp_specific_transport_account_for_open_connection):
11 * src/modest-ui-actions.c: (check_for_connection),
12 (modest_ui_actions_on_item_not_found):
13 Use modest_platform_connect_and_wait() and put #idefs around other
14 maemo-specific code, because only maemo currently has a way to
15 identify connection names.
17 2007-04-27 Murray Cumming <murrayc@murrayc.com>
19 * src/modest-tny-account-store.h:
20 * src/modest-tny-account-store.c:
21 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
22 the connection-specific SMTP server settings in the configuration.
24 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
26 * src/maemo/modest-main-window.c: (on_connection_changed),
28 * src/modest-main.c: (main), (start_ui), (send_mail):
29 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
30 that is what is intended.
32 * src/modest-ui-actions.c: (action_send), (action_receive),
33 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
34 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
35 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
36 SMTP server is used when it is specified.
38 (modest_ui_actions_on_send_receive):
39 Check that a connection is open before proceeding.
40 Receive and then send, instead of vice-versa, as per the specification.
42 2007-04-26 Murray Cumming <murrayc@murrayc.com>
44 * src/modest-mail-operation.c:
45 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
46 though I guess it should be something other than NULL.
48 2007-04-26 Murray Cumming <murrayc@murrayc.com>
50 * src/maemo/easysetup/modest-easysetup-wizard.c:
51 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
52 combo twice, to avoid an g_warning and to make it visible again.
53 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
54 attached before detaching it, to avoid a g_warning, and add comment about the implicit
55 (already intended) dereference when detaching, because we then recreate the menu.
56 But I am not sure why the warning was happening, and it is possible that this is a memory
59 2007-04-25 Murray Cumming <murrayc@murrayc.com>
61 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
62 and uri_parse_mailto() utility functions.
63 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
65 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
67 2007-04-24 Murray Cumming <murrayc@murrayc.com>
69 * src/dbus_api/modest-dbus-api.h:
70 * src/dbus_api/modest-dbus-callbacks.c:
71 Use an idle callback to execute the modest code in the application's own thread.
72 Remove the helloworld example method.
73 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
74 parsed, and the open-message method is not implemented because this is not yet implemented in
76 * libmodest-dbus-client/libmodest-dbus-client.c:
77 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
78 (libmodest_dbus_client_open_message):
79 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
81 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
82 body without crashing.
84 * tests/dbus_api/Makefile.am:
85 * tests/dbus_api/test_mail_to.c:
86 * tests/dbus_api/test_open_message.c: New tests for the new methods.
88 2007-04-24 Murray Cumming <murrayc@murrayc.com>
90 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
91 Added file to fix the build. Sorry.
93 * src/dbus_api/Makefile.am:
94 * src/dbus_api/modest-dbus-api.h:
95 * src/dbus_api/modest-dbus-callbacks.h:
96 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
97 (modest_dbus_req_handler):
98 Put constants in a separate header so it can be reused by the
99 client library, without duplication
101 * libmodest-dbus-client/Makefile.am:
102 * libmodest-dbus-client/libmodest-dbus-client.c:
103 (libmodest_dbus_client_call_helloworld),
104 (libmodfest_dbus_client_send_mail),
105 (libmodfest_dbus_client_mailto),
106 (libmodfest_dbus_client_open_message):
107 * libmodest-dbus-client/libmodest-dbus-client.h:
108 (Partly) Implement a send_mail D-Bus method.
110 * tests/dbus_api/Makefile.am:
111 * tests/dbus_api/test_send_mail.c: (main): Added a test for
112 the send_email D-Bus method.
114 2007-04-24 Murray Cumming <murrayc@murrayc.com>
118 * libmodest-dbus-client/Makefile.am:
119 * libmodest-dbus-client/libmodest-dbus-client.c:
120 * libmodest-dbus-client/libmodest-dbus-client.h:
121 * tests/dbus_api/Makefile.am:
122 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
123 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
125 2007-04-24 Murray Cumming <murrayc@murrayc.com>
127 * src/maemo/easysetup/modest-easysetup-wizard.c:
128 (create_page_account_details):
129 * src/maemo/modest-account-settings-dialog.c:
130 (create_page_account_details): Explicitly set auto-capitalization mode for the title
131 widgets, because this might not be the default in future versions of the Maemo GTK+.
132 However, I can not not get capitalization to work even in a simple test case.
134 2007-04-24 Murray Cumming <murrayc@murrayc.com>
136 * src/maemo/easysetup/modest-easysetup-wizard.c:
137 (create_page_custom_incoming), (create_page_custom_outgoing):
138 * src/maemo/modest-account-settings-dialog.c:
139 (create_page_account_details), (create_page_incoming),
140 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
141 instead of using gtk_check_button_with_label(), so they are aligned like the other
142 widgets, as per the UI spec.
144 2007-04-24 Murray Cumming <murrayc@murrayc.com>
146 * src/maemo/easysetup/modest-easysetup-wizard.c:
147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
148 * src/widgets/modest-validating-entry.c:
149 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
150 Modest prefix instead of an EasySetup prefix.
152 2007-04-23 Murray Cumming <murrayc@murrayc.com>
154 * src/widgets/modest-validating-entry.h:
155 * src/widgets/modest-validating-entry.c: (on_insert_text),
156 Added easysetup_validating_entry_set_max_func(), used to set a callback
157 to call when the max number of characters is reached. GtkEntry has a max-length
158 already but is silent about it.
160 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
161 (create_page_account_details), (create_page_user_details),
163 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
164 (create_page_account_details), (create_page_user_details),
165 (create_page_outgoing):
166 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
167 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
168 the UI spec, when the user tries to enter more than the max number of characters.
170 2007-04-23 Murray Cumming <murrayc@murrayc.com>
172 * src/maemo/easysetup/modest-easysetup-wizard.c:
173 (create_page_user_details), (create_page_custom_incoming),
174 (create_page_custom_outgoing):
175 * src/maemo/modest-account-settings-dialog.c:
176 (create_page_user_details), (create_page_incoming),
177 (create_page_outgoing):
178 * src/maemo/modest-connection-specific-smtp-edit-window.c:
179 (modest_connection_specific_smtp_edit_window_init):
180 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
181 not appropriate. Bad Maemo-specific defaults!.
183 2007-04-23 Murray Cumming <murrayc@murrayc.com>
185 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
186 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
187 (modest_signature_editor_dialog_set_settings):
188 Disable the label and textview when the checkbox is disabled, and use the
189 specified (UI spec) default signature text.
191 2007-04-23 Murray Cumming <murrayc@murrayc.com>
193 * src/maemo/modest-connection-specific-smtp-edit-window.c:
194 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
197 * src/modest-account-mgr-helpers.h:
198 * src/modest-account-mgr-helpers.c:
199 Added modest_account_mgr_get/set_signature(), using new gconf keys.
201 * src/maemo/Makefile.am:
202 * src/maemo/modest-signature-editor-dialog.c:
203 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
206 * src/maemo/modest-account-settings-dialog.h:
207 * src/maemo/modest-account-settings-dialog.c:
208 (modest_account_settings_dialog_finalize), (on_button_signature),
209 (save_configuration): Use the new dialog when the Edit button is pressed, and
210 save the changes if necessary, as per the UI spec.
212 2007-04-23 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/Makefile.am:
215 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
216 based on maemo-develoers email from Dirk.
218 * src/maemo/easysetup/modest-easysetup-wizard.c:
219 (create_page_welcome), (create_page_account_details),
220 (create_page_user_details), (create_page_complete_easysetup),
221 (create_page_custom_incoming), (create_page_custom_outgoing),
222 (create_page_complete_custom),
223 (modest_easysetup_wizard_dialog_init):
224 * src/maemo/modest-account-settings-dialog.c:
225 (create_page_account_details), (create_page_user_details),
226 (create_page_incoming), (create_page_outgoing),
227 (modest_account_settings_dialog_init):
228 * src/maemo/modest-connection-specific-smtp-window.c:
229 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
231 2007-04-23 Murray Cumming <murrayc@murrayc.com>
233 * src/maemo/easysetup/modest-easysetup-wizard.c:
234 (create_page_account_details), (create_page_custom_outgoing),
235 (create_page_complete_custom):
236 * src/maemo/modest-account-settings-dialog.c:
237 (create_page_user_details), (create_page_incoming),
238 (create_page_outgoing):
239 * src/maemo/modest-connection-specific-smtp-edit-window.c:
240 (modest_connection_specific_smtp_edit_window_init):
241 Use the correct (UI spec) port min/max, and use horizontal separators,
244 2007-04-23 Murray Cumming <murrayc@murrayc.com>
246 * src/maemo/easysetup/modest-easysetup-wizard.c:
247 (set_default_custom_servernames):
248 * src/maemo/modest-account-settings-dialog.c:
249 (create_page_incoming), (on_combo_outgoing_security_changed),
250 (on_combo_incoming_security_changed), (create_page_outgoing),
251 (modest_account_settings_dialog_set_account_name),
252 (save_configuration):
253 * src/maemo/modest-connection-specific-smtp-edit-window.c:
254 (on_combo_security_changed),
255 (modest_connection_specific_smtp_edit_window_init),
256 (modest_connection_specific_smtp_edit_window_set_connection),
257 (modest_connection_specific_smtp_edit_window_get_settings):
258 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
261 2007-04-20 Murray Cumming <murrayc@murrayc.com>
264 * src/maemo/easysetup/modest-easysetup-wizard.c:
265 (create_page_custom_outgoing), (create_page_complete_custom):
266 * src/maemo/modest-account-settings-dialog.c:
267 (create_page_user_details), (create_page_outgoing):
268 * src/maemo/modest-account-view-window.c: (button_box_new):
269 Use changed logical IDs as per the most recent UI spec:
270 mcen_bd_emailsetup_edit -> mcen_bd_edit
271 mcen_bd_emailsetup_delete -> mcen_bd_delete
272 mcen_bd_emailsetup_close -> mcen_bd_close
274 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
278 * src/dbus_api/Makefile.am:
279 * src/dbus_api/modest-dbus-callbacks.c:
280 * src/dbus_api/modest-dbus-callbacks.h:
281 * src/maemo/modest-platform.c: (modest_platform_init):
282 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
285 * tests/dbus_api/Makefile.am:
286 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
288 2007-04-20 Murray Cumming <murrayc@murrayc.com>
290 * src/maemo/modest-account-settings-dialog.c:
291 * src/maemo/modest-connection-specific-smtp-edit-window.c:
292 Removed unnecessary includes.
294 2007-04-20 Murray Cumming <murrayc@murrayc.com>
296 * src/maemo/easysetup/modest-easysetup-wizard.c:
297 * src/maemo/modest-account-settings-dialog.c:
298 * src/maemo/modest-connection-specific-smtp-edit-window.c:
299 * src/widgets/Makefile.am:
300 * src/widgets/modest-easysetup-secureauth-combo-box.c:
301 * src/widgets/modest-easysetup-secureauth-combo-box.h:
302 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
303 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
304 * src/widgets/modest-secureauth-combo-box.c:
305 * src/widgets/modest-secureauth-combo-box.h:
306 * src/widgets/modest-serversecurity-combo-box.c:
307 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
308 made the GObject names more consistent with the rest of the Modest code.
310 2007-04-20 Murray Cumming <murrayc@murrayc.com>
312 * src/maemo/easysetup/Makefile.am:
313 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
314 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
315 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
316 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
317 * src/maemo/easysetup/modest-easysetup-wizard.c:
318 * src/maemo/easysetup/modest-validating-entry.c:
319 * src/maemo/easysetup/modest-validating-entry.h:
320 * src/maemo/modest-account-settings-dialog.c:
321 * src/maemo/modest-connection-specific-smtp-edit-window.c:
322 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
323 widgets/ because they are used outside of easysetup too. After checking in,
324 svn will allow me to rename them too.
326 2007-04-20 Murray Cumming <murrayc@murrayc.com>
328 * src/gnome/modest-msg-edit-window.c:
329 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
330 linker error, to fix the build on the GNOME platform.
331 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
332 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
333 ifdefed out to avoid a warning.
335 2007-04-20 Murray Cumming <murrayc@murrayc.com>
337 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
338 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
339 some alternative for GTK+ 2.6.
341 2007-04-19 Murray Cumming <murrayc@murrayc.com>
343 * src/maemo/modest-address-book.c: Added include to avoid a warning.
345 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
346 specified for EmailAccountsDialog in UI spec.
348 * src/maemo/easysetup/modest-easysetup-wizard.c:
349 * src/maemo/easysetup/modest-easysetup-wizard.h:
350 * src/maemo/modest-account-settings-dialog.c:
351 * src/maemo/modest-account-settings-dialog.h:
352 Reuse a member window widget for the connection-specific SMTP server accounts,
353 so we can tell it to create/save the accounts only if we actually save changes.
355 * src/maemo/modest-connection-specific-smtp-edit-window.h:
356 * src/maemo/modest-connection-specific-smtp-edit-window.c:
357 (modest_connection_specific_smtp_edit_window_get_settings):
358 Return a struct instance for temporarily remembering the entered data.
360 * src/maemo/modest-connection-specific-smtp-window.h:
361 * src/maemo/modest-connection-specific-smtp-window.c:
362 (modest_connection_specific_smtp_window_finalize),
363 (modest_connection_specific_smtp_window_fill_with_connections),
365 (modest_connection_specific_smtp_window_save_server_accounts),
366 (update_model_server_names): Do not actually save data until asked,
367 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
369 (on_selection_changed),
370 (modest_connection_specific_smtp_window_init): Disable the edit
371 button when nothing is selected.
373 * src/modest-account-mgr-helpers.c:
374 * src/modest-account-mgr-helpers.h:
375 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
378 2007-04-19 Murray Cumming <murrayc@murrayc.com>
380 * src/modest-account-mgr-helpers.h:
381 * src/modest-account-mgr-helpers.c:
382 (modest_account_mgr_get_unused_account_name),
383 (modest_account_mgr_get_unused_account_display_name): Added these
384 utility functions, to avoid code duplication.
386 * src/maemo/easysetup/modest-easysetup-wizard.c:
387 (create_page_account_details), (create_account):
388 * src/maemo/modest-connection-specific-smtp-edit-window.c:
389 (on_combo_security_changed),
390 (modest_connection_specific_smtp_edit_window_init),
391 (modest_connection_specific_smtp_edit_window_save_settings):
392 * src/maemo/modest-connection-specific-smtp-edit-window.h:
393 * src/maemo/modest-connection-specific-smtp-window.c:
394 (modest_connection_specific_smtp_window_finalize),
395 (modest_connection_specific_smtp_window_fill_with_connections),
396 (on_button_edit), (modest_connection_specific_smtp_window_init):
397 * src/maemo/modest-connection-specific-smtp-window.h:
398 Implementing saving of connection-specific server accounts.
400 But I need to refactor this so we can save the data for each
401 possible connection-specific account and only actually create the server accounts
402 when the easysetup finished, or the OK button is pressed on the account settings
405 2007-04-18 Murray Cumming <murrayc@murrayc.com>
407 * src/maemo/modest-connection-specific-smtp-edit-window.c:
408 (on_combo_security_changed):
409 (modest_connection_specific_smtp_edit_window_init):
410 Auto-fill the port number as in the account settings.
412 (modest_connection_specific_smtp_edit_window_set_connection):
413 * src/maemo/modest-connection-specific-smtp-edit-window.h:
414 * src/maemo/modest-connection-specific-smtp-window.c:
415 (fill_with_connections), (on_button_edit),
416 (modest_connection_specific_smtp_window_init):
417 Turn the edit window into a dialog to simplify the code, and
418 set a WM hint as in a GtkDialog, because only a popup can be on top of
419 another window in Maemo, and popups usually have no WM decoration.
422 * src/modest-account-mgr-helpers.c:
423 (modest_account_mgr_set_connection_specific_smtp),
424 (modest_account_mgr_remove_connection_specific_smtp),
425 (modest_account_mgr_get_connection_specific_smtp):
426 * src/modest-account-mgr-helpers.h: Some functions to write the
427 connection-specific SMTP server information. Not yet used.
430 * src/widgets/modest-folder-view.c: (text_cell_data):
431 Fix a warning about an uninitialized variable.
432 (on_configuration_key_changed): Put an #ifdef around the use
433 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
435 2007-04-18 Murray Cumming <murrayc@murrayc.com>
437 * src/maemo/modest-account-settings-dialog.h:
438 * src/maemo/modest-account-settings-dialog.c:
439 Added connect_for_modified() utility function to mark the new modified boolean.
441 (create_page_account_details), (create_page_user_details),
442 (create_page_incoming), (create_page_outgoing), (on_response),
443 (modest_account_settings_dialog_init),
444 (modest_account_settings_dialog_set_account_name):
445 Only warn about unsaved changes when there are actually unsaved changes.
447 * src/modest-account-mgr-helpers.c:
448 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
449 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
450 to get the data from there in future.
452 2007-04-18 Murray Cumming <murrayc@murrayc.com>
456 * src/modest-account-mgr-helpers.h:
457 * src/modest-account-mgr-helpers.c:
458 Store the security account setting in a single conf key instead of using
459 the options list, so that the list is left for just the to-be-removed camel hack,
460 and because gconf_client_set_list() is failing for some reason.
462 * src/modest-account-mgr.c:
463 (modest_account_mgr_add_server_account):
464 * src/maemo/modest-account-settings-dialog.c:
465 (modest_account_settings_dialog_set_account_name),
466 (save_configuration): Use the renamed functions.
469 2007-04-18 Murray Cumming <murrayc@murrayc.com>
471 * src/widgets/Makefile.am:
472 * src/widgets/modest-limit-retrieve-combo-box.c:
473 * src/widgets/modest-limit-retrieve-combo-box.h:
474 * src/widgets/modest-retrieve-combo-box.c:
475 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
476 the account settings dialog.
479 * src/modest-account-mgr-helpers.h:
480 * src/modest-account-mgr-helpers.c:
481 (modest_server_account_get_option_secure_auth),
482 (modest_server_account_set_option_secure_auth):
483 * src/modest-account-mgr.c:
484 (modest_account_mgr_add_server_account):
485 Use the existing AUTH_MECH conf key for the secure-auth setting,
486 instead of putting it in the list options, because this was actually used already.
488 * src/maemo/modest-account-settings-dialog.c:
489 (create_page_account_details),
490 (modest_account_settings_dialog_set_account_name),
491 (save_configuration):
492 * src/maemo/modest-account-settings-dialog.h:
493 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
494 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
496 2007-04-18 Murray Cumming <murrayc@murrayc.com>
498 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
499 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
500 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
503 * src/maemo/modest-account-settings-dialog.c:
504 (create_page_incoming), (on_combo_outgoing_security_changed),
505 (on_combo_incoming_security_changed), (create_page_outgoing),
506 (modest_account_settings_dialog_set_account_name),
507 (save_configuration): Load/Save the port number, and change it when the
508 security combo changes, to suitable defaults.
510 2007-04-17 Murray Cumming <murrayc@murrayc.com>
512 * src/modest-account-mgr.c:
513 (modest_account_mgr_add_server_account): Set the security and secure-auth
514 options, and add a comment saying that the other camel-specific options should be
517 2007-04-17 Murray Cumming <murrayc@murrayc.com>
519 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
521 * src/modest-tny-account-store.c: (account_list_free),
522 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
523 cursor->data after unreffing it. But there is some strange stuff there so it might not be
526 2007-04-17 Murray Cumming <murrayc@murrayc.com>
528 * src/modest-protocol-info.c:
529 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
530 is required by our UI spec. Maybe something in our implementation will use this eventually.
531 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
532 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
533 instead of the previous 0 placeholder.
535 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
536 secure-auth settings.
537 * src/modest-account-mgr-helpers.h:
538 * src/modest-account-mgr-helpers.c:
539 (modest_server_account_data_get_option_secure_auth),
540 (modest_server_account_set_option_secure_auth),
541 (modest_server_account_data_get_option_security),
542 (modest_server_account_set_option_security): Added this API for getting and setting the security
543 and secure-auth settings.
545 * src/maemo/modest-account-settings-dialog.h:
546 * src/maemo/modest-account-settings-dialog.c:
547 (modest_account_settings_dialog_finalize), (check_data),
548 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
549 about changing titles.
550 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
551 (save_configuration): Save the security and secure-auth settings.
553 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
554 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
556 2007-04-17 Murray Cumming <murrayc@murrayc.com>
559 * src/modest-account-mgr.c:
560 (modest_account_mgr_add_server_account):
561 Added and used defines for the options key and value pair strings,
562 that are used so far, though they do not seem to correspond to anything in our
563 UI specs or ModestProtocol enum.
565 * src/modest-account-mgr-helpers.h:
566 * src/modest-account-mgr-helpers.c:
567 (compare_option_strings_for_name),
568 (modest_server_account_data_get_option_value),
569 (modest_server_account_data_get_option_bool),
570 (modest_account_mgr_get_server_account_option):
571 Added helper functions for parsing the options GSList.
573 2007-04-16 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
576 display name is based on the supplied account name.
577 * src/modest-account-mgr.c:
578 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
579 with an inefficient, but good-enough, implementation.
581 * src/maemo/easysetup/modest-easysetup-wizard.c:
582 (create_page_account_details), (on_before_next), (create_account):
583 Check for existing display names rather than (non-user-visible) account names, and just
584 create and set a unique account name at the end.
586 * src/maemo/modest-account-settings-dialog.c:
587 (modest_account_settings_dialog_init),
588 (modest_account_settings_dialog_set_account_name),
589 (create_page_incoming): Show the display name, instead of the account name.
590 (on_response): Do some (not all) extra checks, as in the UI spec.
591 (save_configuration): Save the display name if it was changed.
593 2007-04-16 Murray Cumming <murrayc@murrayc.com>
595 * po/en_GB.po: Added needed logical ID and translation.
596 * src/widgets/modest-account-view.c: (on_account_default_toggled),
597 (init_view): Made the is-default column clicking work.
599 2007-04-16 Murray Cumming <murrayc@murrayc.com>
602 * src/maemo/easysetup/Makefile.am:
603 * src/maemo/easysetup/modest-easysetup-wizard.c:
604 (modest_easysetup_wizard_dialog_init):
605 * src/maemo/easysetup/provider-data-test.keyfile:
606 * src/maemo/easysetup/provider-data.keyfile:
607 Moved the provider data file to the new modest-providers-data package and used it from there.
609 2007-04-16 Murray Cumming <murrayc@murrayc.com>
611 * src/modest-local-folder-info.c:
612 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
613 N_() was already used on the static strings, but this just marks it for translation without
614 using the translation.
616 2007-04-06 Murray Cumming <murrayc@murrayc.com>
618 * src/maemo/modest-account-settings-dialog.c:
619 (create_page_incoming),
620 (modest_account_settings_dialog_set_account_name):
621 Added comments about the need for new API in ModestAccountMgr to handle the authentication
622 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
623 I will do this if nobody else gets there first.
625 2007-04-06 Murray Cumming <murrayc@murrayc.com>
627 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
628 Saved much of the incoming and outgoing data too, though I cannot yet see how to
629 save the security stuff.
631 2007-04-06 Murray Cumming <murrayc@murrayc.com>
633 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
634 Set the email address and user fullname, which I now see must be
637 * src/maemo/modest-account-settings-dialog.h:
638 * src/maemo/modest-account-settings-dialog.c:
640 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
641 leave-on-server and authentication.
642 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
645 2007-04-06 Murray Cumming <murrayc@murrayc.com>
648 * src/maemo/modest-account-settings-dialog.c:
649 * src/maemo/modest-account-settings-dialog.h:
650 Most (but not all) of the widgets are now present as specified by the UI spec.
651 No changes are yet saved, and some details are not properly shown yet.
653 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
655 2007-04-06 Murray Cumming <murrayc@murrayc.com>
657 * src/maemo/Makefile.am:
658 * src/maemo/modest-account-settings-dialog.c:
659 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
660 an existing account. Doesn't do much yet.
662 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
663 Open the accounts settings dialog when Edit is clicked.
665 2007-04-05 Murray Cumming <murrayc@murrayc.com>
667 * src/maemo/easysetup/Makefile.am:
668 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
670 * src/maemo/easysetup/modest-easysetup-wizard.c:
671 (modest_easysetup_wizard_dialog_init):
672 Try to get the source directory from the build system,
673 instead of hard-coding "./" into the source code, when opening our local
674 copies of the configuration files.
675 But this still fails when opening the wizard from the Accounts window,
676 maybe because the working directory seems to change at runtime.
677 So the wizard will fail the second time unless you copy the files into their
678 proper locations - see the stdout warnings for the paths.
680 (create_page_account_details),(on_before_next):
681 Check for existing non-server accounts instead of server accounts,
682 so the default account name is useful again, and to prevent trying to
685 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
686 Show the wizard when New is clicked.
688 * src/widgets/modest-account-view.c: (on_account_default_toggled),
689 (init_view): Show the column headers, and show the columns that are
690 specified in the UI specs. However, something in Maemo's GTK+ prevents
691 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
692 change the default account. This is despite unsetting the special properties.
694 2007-04-05 Murray Cumming <murrayc@murrayc.com>
696 * docs/reference/modest-design.sgml: Corrected spelling mistake.
697 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
698 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
699 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
700 to make that clearer.
701 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
703 2007-04-05 Murray Cumming <murrayc@murrayc.com>
705 * src/maemo/modest-account-view-window.c:
706 (modest_account_view_window_init),
707 (modest_account_view_window_new):
708 Use the same buttons as specified in the
709 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
710 the existing widgets, which never had a chance of working.
711 Put the ModestAccountView treeview in a scrolled window.
712 Do not repeat the initialization in both _init() and _new().
714 * src/widgets/modest-account-view.c: (update_account_view):
715 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
716 this widget and window shows no accounts.
718 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
720 2007-04-05 Murray Cumming <murrayc@murrayc.com>
722 * src/maemo/easysetup/modest-easysetup-wizard.c:
723 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
724 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
725 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
728 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
729 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
730 accounts exist yet, as in the UI spec.
732 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
734 2007-04-05 Murray Cumming <murrayc@murrayc.com>
736 * src/maemo/Makefile.am:
737 * src/maemo/modest-connection-specific-smtp-edit-window.c:
738 * src/maemo/modest-connection-specific-smtp-edit-window.h:
739 New window for editing connection-specific smtp details.
740 Not fully implemented.
742 * src/maemo/modest-connection-specific-smtp-window.c:
743 (modest_connection_specific_smtp_window_finalize) :
744 unref the tree model.
745 (on_button_edit): Show the edit window.
747 2007-04-05 Murray Cumming <murrayc@murrayc.com>
749 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
752 * src/maemo/Makefile.am:
753 * src/maemo/modest-connection-specific-smtp-window.c:
754 * src/maemo/modest-connection-specific-smtp-window.h:
755 New window for showing the list of connections, for connection-specific
756 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
757 * src/maemo/easysetup/modest-easysetup-wizard.c:
758 (create_page_custom_outgoing): Show the new window when the button is clicked.
760 2007-04-04 Murray Cumming <murrayc@murrayc.com>
762 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
763 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
764 * src/maemo/modest-msg-edit-window.c:
765 (modest_msg_edit_window_insert_image):
766 * src/modest-conf.c: (modest_conf_key_escape):
767 * src/modest-mail-operation.c:
768 (modest_mail_operation_send_new_mail):
769 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
770 (modest_ui_actions_on_new_account):
771 * src/widgets/modest-attachment-view.c: (update_filename_request):
772 * src/widgets/modest-mail-header-view.c:
773 Corrected warnings that were breaking the build, by commenting out unused variables,
774 and a function, and by including a header.
776 2007-04-04 Murray Cumming <murrayc@murrayc.com>
778 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
779 so we can #ifdef around platform-specific code when necessary.
780 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
781 to allow this to build for the GNOME platform too.
783 2007-04-04 Murray Cumming <murrayc@murrayc.com>
785 * src/maemo/easysetup/modest-easysetup-wizard.c:
786 Added util_increment_name() and used it in create_page_account_details()
787 to make sure that the default account name is always a new name.
789 (modest_easysetup_wizard_dialog_init),
790 (set_default_custom_servernames): Some minor memory management fixes.
792 2007-04-04 Murray Cumming <murrayc@murrayc.com>
796 * src/modest-runtime.c: (init_i18n): Restored the translation
797 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
798 are defined in config.h, and the translations are installed.
800 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
801 is defined for translation.
803 2007-04-03 Murray Cumming <murrayc@murrayc.com>
805 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
807 * src/maemo/easysetup/modest-easysetup-wizard.c:
808 (modest_easysetup_wizard_dialog_init):
809 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
810 Use realistic paths (though they should use $prefix generically) to the
811 mcc_mapping and provider-data.keyfile files which might work when they
812 are installed by the future version of the operator-wizard package,
813 and then fallback to paths in our source code, with an explanatory
816 2007-04-03 Murray Cumming <murrayc@murrayc.com>
820 * src/maemo/Makefile.am:
821 * src/maemo/easysetup/: Added files from the previously-exernal
822 osso-modest-easysetup.
823 * src/maemo/modest-main-window-ui.h:
824 * src/modest-ui-actions.c:
825 * src/modest-ui-actions.h:
826 Added modest_ui_actions_on_new_account() as a signal handler for the
827 New Account menu item. It shows the easysetup wizard.
828 * po/en_GB.po: Added additional needed logical IDs and translations.
830 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
831 Apparently ChangeLog is not used for some vague Nokia legal reasons.