1 2007-07-24 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-maemo-global-settings-dialog.c:
5 Avoid a crash (probably only in scratchbox) when strcmp()ing a
6 NULL when closing the dialog.
8 2007-07-24 Murray Cumming <murrayc@murrayc.com>
10 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
11 Remove the hacky send/receive that didn't work, and instead
12 refilter the treemodel to make the deleted email really vanish from
13 the UI (though the delete-from-menu code does has commented out
14 the code that does that). This fixes projects.maemo.org bug
17 2007-07-24 Murray Cumming <murrayc@murrayc.com>
19 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
20 Try a couple of tricks to force the treeview to update (
21 poke the folder, and do a send/receive refresh), but the deleted
22 email still appears with a strike-through instead of really being
25 2007-07-23 Murray Cumming <murrayc@murrayc.com>
27 * src/dbus_api/modest-dbus-callbacks.c:
28 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
29 because their ID is not human-readable (see the comment about
30 improvements needed to the osso-email-interface API) and
31 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
33 2007-07-23 Murray Cumming <murrayc@murrayc.com>
35 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
36 (add_folders_to_list), (on_dbus_method_get_folders),
37 (modest_dbus_req_filter):
38 * src/maemo/modest-maemo-utils.c:
39 (on_camel_account_get_supported_secure_authentication):
40 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
41 (on_header_view_focus_in):
42 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
43 * src/modest-formatter.c: (modest_formatter_create_body_part):
44 * src/modest-mail-operation.c: (recurse_folders),
45 (update_account_thread), (get_msgs_full_thread),
46 (modest_mail_operation_get_msgs_full),
47 (modest_mail_operation_xfer_msgs):
48 * src/modest-search.c: (search_mime_part_and_child_parts),
49 (modest_search_account), (modest_search_all_accounts):
50 * src/modest-tny-account.c:
51 (modest_tny_account_get_special_folder), (recurse_folders):
52 * src/modest-tny-local-folders-account.c:
53 (modest_tny_local_folders_account_query_passes):
54 * src/modest-tny-msg.c: (copy_mime_part),
55 (modest_tny_msg_find_body_part_from_mime_part):
56 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
57 (modest_tny_send_queue_try_to_send):
58 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
59 (_modest_ui_actions_open), (download_uncached_messages),
60 (reply_forward), (modest_ui_actions_on_copy),
61 (modest_ui_actions_on_details), (has_retrieved_msgs),
62 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
64 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
65 (_selected_msg_marked_as), (_msg_download_completed),
66 (_selected_msg_sent_in_progress):
67 * src/widgets/modest-attachments-view.c:
68 (modest_attachments_view_set_message):
69 * src/widgets/modest-msg-view.c: (find_cid_image):
70 * tests/check_folder-transfer.c: (find_folders):
71 * tests/check_update-account.c: (func):
72 * tests/dbus_api/test_get_folders.c: (main):
73 Checked all uses of tny_iterator_get_current(), making sure
74 that the object is unreferenced (3 or 4 places did not),
75 and adding checks for NULL.
77 2007-07-23 Murray Cumming <murrayc@murrayc.com>
79 * src/dbus_api/modest-dbus-callbacks.c:
80 (on_idle_open_default_inbox): Make sure that the application UI is
82 * src/maemo/easysetup/modest-easysetup-wizard.c:
83 (on_entry_invalid_character): Show the word whitespace instead
84 of (null) in the banner when whitespace was entered.
85 (show_error): Add a comment that this does not work in
86 Maemo Bora, though we do not know why.
88 2007-07-23 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-tny-account.c:
91 (modest_tny_account_get_special_folder): Use an if instead of
92 an assert for when the parent account name is NULL, because this
93 might be causing a crash in projects.maemo.org bug 63192.
94 * src/modest-mail-operation.c:
95 (modest_mail_operation_send_new_mail_cb),
96 (modest_mail_operation_remove_folder): unref the folder that is
97 returned from modest_tny_account_get_special_folder().
99 2007-07-23 Murray Cumming <murrayc@murrayc.com>
101 * src/modest-ui-actions.c:
102 (modest_ui_actions_on_password_requested):
103 Show mail_ib_login_cancelled info banner when the user cancels
104 the protected password dialog, to fix projects.maemo.org
107 2007-07-23 Murray Cumming <murrayc@murrayc.com>
109 * src/maemo/modest-account-settings-dialog.c:
110 (create_page_outgoing): Put this page in a GtkScrolledWindow,
111 matching the UI mock-up in the UI spec, and allowing access
112 to all widgets even when the on-screen keyboard is active.
114 2007-07-23 Murray Cumming <murrayc@murrayc.com>
116 Reverted this previous commit from Johannes,
117 because the scrollbars are always visible and because
118 I think we only need it on onepage of the account
119 settings, not the account wizard.
120 (I wrote the wrong instructions in the bug.)
122 * src/maemo/easysetup/modest-easysetup-wizard.c:
123 Added scrollbars to account wizard dialog.
124 Fixed projects.maemo.org NB #62744
126 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
128 * src/maemo/easysetup/modest-easysetup-wizard.c:
129 (create_page_user_details):
130 Use auto-cap for name (projects.maemo.org NB#63716)
131 * src/widgets/modest-account-view.c: (on_account_busy_changed):
133 2007-07-22 Armin Burgmeier <armin@openismus.com>
135 * src/maemo/modest-ui-actions.c: Use current account instead of
136 default account for creating viewer windows, so that the viewer
137 window knows to which account the viewed message belongs.
139 * src/maemo/modest-msg-view-window.c: Destroy the window when the
140 corresponding account is deleted. This fixes projects.maemo.org bug
143 2007-07-18 Armin Burgmeier <armin@openismus.com>
145 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
146 the dialog close after entering an invalid port number and clicking
147 OK. This fixes projects.maemo.org bug NB#63602.
149 2007-07-18 Armin Burgmeier <armin@openismus.com>
151 * src/modest-tny-account-store.c:
152 (get_server_accounts): Set parent modest account name for each
153 connection-specific transport account so that special folders of such
154 an account can be looked up. This fixes a crash when changing account
155 settings. This might also be related to projects.maemo.org bug
158 2007-07-16 Armin Burgmeier <armin@openismus.com>
160 * src/modest-ui-actions.c: Added a button to create a folder to the
161 move-to dialog. This fixes projects.maemo.org bug NB#.
163 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
165 * src/maemo/easysetup/modest-easysetup-wizard.c:
166 Added scrollbars to account wizard dialog.
167 Fixed projects.maemo.org NB #62744
169 2007-07-16 Murray Cumming <murrayc@murrayc.com>
171 * src/widgets/modest-msg-view.h:
172 * src/widgets/modest-msg-view.c:
173 Added modest_msg_view_get_message_is_empty() but this needs
175 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
176 Check if there is any text in the message yet.
177 But this needs to be implemented properly.
178 (modest_msg_edit_window_toggle_find_toolbar):
179 * src/maemo/modest-msg-view-window.c:
180 (modest_msg_view_window_toggle_find_toolbar):
181 Show a banner warning if there is no text to search, when
182 trying to start a search. This partially fixes
183 projects.maemo.org bug NB#62350.
185 2007-07-13 Murray Cumming <murrayc@murrayc.com>
187 * src/modest-mail-operation.c: (update_account_thread):
188 Initialized num_new_headers to fix the build.
190 2007-07-13 Murray Cumming <murrayc@murrayc.com>
192 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
193 Ignore modest accounts whose server accounts don't exist in gconf.
194 This prevents us trying to create TnyAccount instances for those
195 server accounts when the server account has been removed from gconf,
196 but the parent modest account has not yet been removed from modest.
197 I don't know why this is only noticeable now. It was probably just
198 a harmeless g_warning() anyway.
200 2007-07-13 Murray Cumming <murrayc@murrayc.com>
202 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
203 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
205 2007-07-12 Armin Burgmeier <armin@openismus.com>
207 * src/maemo/modest-main-window.c: Make default account appear bold
208 in view, tools/send & receive and toolbar/send & receive SCM menus.
209 This fixes projects.maemo.org bug NB#59010.
211 2007-07-12 Murray Cumming <murrayc@murrayc.com>
213 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
214 Add a short-cut, by checking if the folder store is an account.
215 This ensures that the Sort menu item and toolbar is dimmed for
216 the local-folders account root item, fixing
217 projects.maemo.org bug NB#62545.
219 2007-07-12 Murray Cumming <murrayc@murrayc.com>
221 * src/modest-tny-account-store.c: (get_password):
222 Show the password dialog (via the signal) only in the mainloop, via
223 an idle handler that we wait for. This could theoretically prevent
224 hangs, though I worry that it could introduce some too.
226 2007-07-12 Murray Cumming <murrayc@murrayc.com>
228 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
229 * src/maemo/modest-platform.c:
230 (modest_platform_connect_and_wait):
231 Take a TnyAccount* parameter and try to set it to online
232 (a TnyCamel-only API), because tinymail sets accounts to offline
233 when the user cancels a password dialog, and doesn't ask again until
234 it has been set to online.
235 However, this is commented out because it causes a hang now.
237 (modest_platform_connect_and_wait_if_network_account):
238 * src/modest-mail-operation.c:
239 (modest_mail_operation_update_account):
240 * src/modest-platform.h:
241 * src/modest-ui-actions.c: (_modest_ui_actions_open),
242 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
244 2007-07-12 Armin Burgmeier <armin@openismus.com>
246 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
248 * src/modest-mail-operation.c:
249 * src/modest-ui-actions.c: Check for already existing folder before
250 querying the server, show error message from camel if the request
251 still fails. This fixes projects.maemo.org bug NB#58701.
253 2007-07-12 Murray Cumming <murrayc@murrayc.com>
255 * src/modest-tny-account-store.h:
256 * src/modest-tny-account-store.c:
257 Added modest_tny_account_store_forget_password_in_memory(),
258 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
259 when creating a new account, so that new passwords will be used, instead of
260 us thinking that it's a second request as a result of a failed password again.
262 2007-07-12 Murray Cumming <murrayc@murrayc.com>
264 * src/dbus_api/modest-dbus-callbacks.c:
265 (on_idle_open_message): If the message is in drafts then open it
266 in an edit window instead of a view window. This fixes
267 projects.maemo.org bug NB#63005.
269 2007-07-12 Murray Cumming <murrayc@murrayc.com>
271 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
272 Avoided a harmless g_warning().
274 2007-07-12 Murray Cumming <murrayc@murrayc.com>
276 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
277 Pass the modest account name, not the TnyAccount display name to
278 modest_msg_view_window_new() so that the reply feature works,
279 fixing projects.maemo.org bug NB#62892.
281 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
282 (modest_msg_view_window_new_with_header_model):
283 * src/maemo/modest-msg-view-window.c:
284 (modest_msg_view_window_new_with_header_model),
285 (modest_msg_view_window_new):
286 * src/modest-ui-actions.c: (reply_forward):
287 * src/widgets/modest-msg-view-window.h:
288 * src/widgets/modest-window.c: (modest_window_set_active_account):
289 Rename an account parameter to modest_account_name to make this clearer.
291 2007-07-11 Murray Cumming <murrayc@murrayc.com>
293 * src/modest-ui-actions.h:
294 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
295 modest_do_message_delete().
296 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
297 Call modest_do_message_delete(), hoping that this would cause messages
298 to be really deleted from search instead of just marked with strike through.
299 Does not seem to help.
301 2007-07-11 Armin Burgmeier <armin@openismus.com>
303 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
304 priv->reselect to FALSE prior to calling
305 modest_folder_view_select_first_inbox_or_local() to prevent endless
306 recursion and thus a crash on startup.
308 2007-07-11 Armin Burgmeier <armin@openismus.com>
310 * src/maemo/modest-account-settings-dialog.h: Include
311 <gtk/gtknotebook.h> to fix the build (at least for me).
313 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
314 Use "New FolderN" as default suggested name if "New folder" already
315 exists, with N being the first free number, though never exceed "New
316 folder99" in which case we just fall back to "New Folder" even though
317 it already exists. This fixes projects.maemo.org bug NB#58663.
319 2007-07-11 Murray Cumming <murrayc@murrayc.com>
321 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
322 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
323 projects.maemo.org bug NB#62778.
325 2007-07-11 Murray Cumming <murrayc@murrayc.com>
327 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
328 Ignore the wrong (for now) secure-smtp setting in the presets -
329 just default to requiring secure authentication for SMTP, because
332 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
334 * src/widgets/modest-folder-view.c: (filter_row)
335 Do not show drafts folder (see UI specs)
337 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
339 * src/modest-ui-actions.c:
340 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
341 place and also not necessary.
343 * src/widgets/modest-folder-view.c: (filter_row)
344 Guess folder type and hide Sent & Outbox if necessary.
345 Fixed project.maemo.org NB#57328
347 2007-07-11 Murray Cumming <murrayc@murrayc.com>
349 * src/modest-ui-actions.h:
350 * src/modest-ui-actions.c:
351 (modest_ui_actions_on_delete_message):
352 Move some code into a new
353 modest_ui_actions_refresh_message_window_after_delete()
354 function so we can use it from elsewhere.
356 * src/dbus_api/modest-dbus-callbacks.c:
357 (on_idle_delete_message), (on_delete_message): Used an idle
358 handler, as we do for the other D-Bus method handlers.
359 Call modest_ui_actions_refresh_message_window_after_delete()
360 if the deleted message was open in a window. This fixed
361 projects.maemo.org bug NB#62862.
363 2007-07-11 Murray Cumming <murrayc@murrayc.com>
365 * src/modest-main.c: (main): Only show the UI at the start if
366 the showui command line option was given. For instance,
367 run-standalone src/modest showui
368 Otherwise, we wait for the top_application D-Bus method to
369 be sent by hildon-desktop when the application is selected
371 This allows us to run without a UI when osso-global-search
372 uses our D-Bus methods.
374 2007-07-11 Murray Cumming <murrayc@murrayc.com>
376 * src/dbus_api/modest-dbus-api.h: Added a define for a
377 top-application D-Bus method.
378 * src/dbus_api/modest-dbus-callbacks.c:
379 (on_top_application),
380 (modest_dbus_req_handler): Handle the top-application D-Bus
381 method, which might be an undocumented D-Bus signal sent by
382 hildon-desktop when it starts the application from the menu.
383 But I am not sure and I need to test it on the device, because
384 my scratchbox does not have the application in the menu now.
385 This method shows the main window, so that it can be invisible
386 when started, for instance, just for email searching from
389 * src/maemo/modest-main-window.c: (restore_settings),
390 (modest_main_window_new): Do not show the window immediately
391 upon creation. We show it later.
392 * src/modest-widget-memory.c: (save_settings_paned):
393 Try (unsuccessfully) to avoid saving the paned position when
394 it is not even visible.
395 (restore_settings_paned): Do not allow a silly paned position.
396 This seems necessary when not showing the window at first.
398 * tests/dbus_api/Makefile.am:
399 * tests/dbus_api/test_top_application.c: (main): Test for the
402 2007-07-10 Murray Cumming <murrayc@murrayc.com>
404 * src/modest-ui-dimming-rules.c:
405 (modest_ui_dimming_rules_on_new_msg),
406 (modest_ui_dimming_rules_on_reply_msg),
407 (modest_ui_dimming_rules_on_delete_msg),
408 (modest_ui_dimming_rules_on_details),
409 (modest_ui_dimming_rules_on_view_window_move_to),
410 (modest_ui_dimming_rules_on_view_previous),
411 (modest_ui_dimming_rules_on_view_next),
412 (_invalid_folder_for_purge): Added checks before
413 casting the window. This looks like an actual
414 logic error in _invalid_folder_for_purge(), because it
415 tries to use a ModestMainWindow as a message window.
417 2007-07-10 Murray Cumming <murrayc@murrayc.com>
419 * src/maemo/modest-account-settings-dialog.c:
420 (show_error): Use the same implementation as in
421 modest-easysetup-wizard.c:
422 (on_entry_invalid_character): The logical ID contains a %s.
423 Guessed what it should be.
424 (on_entry_max), (check_data), (on_response): Adapt to
425 changed show_error().
426 (create_page_account_details): Really call
427 modest_validating_entry_set_func() on the correct widgets.
428 * src/maemo/easysetup/modest-easysetup-wizard.c:
429 (on_entry_invalid_character): Fix the logical ID here too.
430 (create_page_account_details),
431 (create_page_user_details):
433 modest_validating_entry_set_func() on the correct widgets.
435 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
436 Do not try to use the account if it is NULL.
438 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
440 * src/modest-ui-actions.c: (create_move_to_dialog),
441 (modest_ui_actions_on_main_window_move_to),
442 (modest_ui_actions_on_msg_view_window_move_to):
443 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
444 (filter_row), (modest_folder_view_show_non_move_folders):
445 * src/widgets/modest-folder-view.h:
447 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
448 the Sent folder yet as it does not report the correct folder type.
450 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
452 * src/maemo/modest-msg-edit-window.c: (init_window):
455 2007-07-10 Murray Cumming <murrayc@murrayc.com>
457 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
458 Take a parent widget instead of a parent window, and
459 implement this with hildon_banner_show_information() instead.
460 Non-Maemo builds can just ifdef that there.
461 This fixed projects.maemo.org bug NB#62766.
463 (on_entry_invalid_character): Use show_error() again instead
464 of using hildon directly, and use the _CS() macro to use the correct
466 (create_account), (check_for_supported_auth_methods), (on_entry_max):
467 Pass a widget instead od a window to show_error().
469 2007-07-10 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
472 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
473 This allows us to show the server name in the error message, fixing
474 projects.maemo.org bug NB#62904.
475 Also, use the appropriate logical ID message for the account protocol.
477 2007-07-10 Murray Cumming <murrayc@murrayc.com>
479 * src/modest-tny-account-store.c: (on_idle_wrong_password):
480 A compilation fix, though the build wasn't broken for me.
482 2007-07-09 Murray Cumming <murrayc@murrayc.com>
484 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
485 Do not try to unref a NULL folder store, to avoid a runtime warning.
486 This seems to happen sometimes when changing accounts settings.
488 2007-07-09 Murray Cumming <murrayc@murrayc.com>
490 * src/modest-tny-account-store.c:
491 (modest_tny_account_store_instance_init),
492 (modest_tny_account_store_finalize),
493 (on_account_settings_hide), (on_idle_wrong_password):
494 Use a GHashTable to ensure that we only show one account settings
495 dialog per modest account. This avoids us having a dialog open for
496 both the store and transport accounts, or due to repeated get_password()
497 calls that shouldn't happen anyway.
499 2007-07-09 Murray Cumming <murrayc@murrayc.com>
501 * src/maemo/modest-maemo-utils.c: (on_hide),
502 (modest_maemo_show_dialog_and_forget): Handle the response, because
503 the window is not even hidden by default.
505 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
506 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
507 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
508 which seems to prevent some modality problems.
510 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
511 Ignore user cancellation errors.
513 * src/modest-account-mgr-helpers.h:
514 * src/modest-account-mgr-helpers.c:
515 Added modest_server_account_get_password() and
516 modest_server_account_get_has_password() to avoid direct use of
519 * src/maemo/modest-account-settings-dialog.h:
520 * src/maemo/modest-account-settings-dialog.c:
521 (modest_account_settings_dialog_init): Store the notebook so we can
523 Added modest_account_settings_dialog_switch_to_user_info().
525 * src/modest-tny-account-store.c:
526 (get_password): When the password in the account settings is wrong (we think),
527 show the relevant page of the account settings dialog, in the mainloop.
528 However, we currently get many of these at once because cancel does not
530 (forget_password): Do not forget the password
531 from the account settings, because this causes side-effects when
532 tinymail seems to call it at strange time, maybe because of how we
533 are cancelling get_password().
534 (modest_tny_account_store_alert): Ignore user cancellations.
536 2007-07-09 Murray Cumming <murrayc@murrayc.com>
538 * src/maemo/modest-maemo-utils.h:
539 * src/maemo/modest-maemo-utils.c:
540 Added modest_maemo_show_information_note_and_forget() for use instead of
541 gtk_dialog_run() when the response is not needed, to avoid an extra
542 mainloop which could cause a hang.
544 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
545 Use the logical IDs for the error message, though they are not
546 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
547 because gtk_dialog_run() caused a hang here (the window did not close).
548 This fixes projects.maemo.org bug NB#62646.
550 2007-07-09 Murray Cumming <murrayc@murrayc.com>
552 * src/modest-account-mgr-helpers.h:
553 * src/modest-account-mgr-helpers.c:
554 Added modest_account_mgr_get_store_protocol().
556 * src/maemo/modest-account-view-window.c:
557 (on_delete_button_clicked): Show different warning text depending on
558 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
559 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
562 2007-07-09 Murray Cumming <murrayc@murrayc.com>
564 * src/maemo/modest-msg-edit-window.c:
565 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
566 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
568 2007-07-07 Armin Burgmeier <armin@openismus.com>
570 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
571 ckdg_ib_maximum_characters_reached from correct package.
573 * src/modest-ui-actions.c: Show an error message when a folder could
574 not be created. Tinymail does not give us specific error codes about
575 what has gone wrong, so we assume that a folder with that name
576 already exists, though there might be other reasons.
578 2007-07-06 Murray Cumming <murrayc@murrayc.com>
580 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
581 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
582 give a more exact error message that can be partly translated.
584 2007-07-05 Murray Cumming <murrayc@murrayc.com>
586 * src/maemo/modest-address-book.c:
587 (select_email_addrs_for_contact): Specify a default window size for the
588 select-email-address dialog, so that it is probably big enough for the
589 title. This should fix projects.maemo.org bug NB#62277.
591 2007-07-05 Murray Cumming <murrayc@murrayc.com>
593 * src/maemo/easysetup/modest-easysetup-wizard.c:
594 (create_page_complete_easysetup): Use
595 gtk_widget_set_size() request to ensure that the text wraps
598 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
600 * src/maemo/easysetup/modest-easysetup-wizard.c:
601 (on_entry_invalid_character), (create_page_account_details),
602 (create_page_user_details):
603 Use new API of ModestValidatingEntry. But for some reason the banner is
604 not shown. I will have to investigate that further.
606 * src/widgets/modest-validating-entry.c: (on_insert_text),
607 (modest_validating_entry_set_func):
608 * src/widgets/modest-validating-entry.h:
609 Added a new callback function to be able to react to prevented
610 characters whitespaces to e.g show a banner.
612 2007-07-05 Armin Burgmeier <armin@openismus.com>
614 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
615 notification of HildonNumberEditor instead of remembering the port
616 number. Thanks to Johannes for pointing this out.
618 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
620 * src/maemo/easysetup/modest-easysetup-wizard.c:
621 Check if there are any user changes before showing a confirmation
622 dialog (projects.maemo.org NB#60946)
624 2007-07-05 Armin Burgmeier <armin@openismus.com>
626 * src/maemo/modest-account-settings-dialog.c: Remember custom port
627 number at the beginning of the dialog and set the modified flag at the
628 end if the port number has changed. This is necessary because
629 HildonNumberEditor does not support notification when the value has
632 2007-07-05 Murray Cumming <murrayc@murrayc.com>
634 * src/modest-ui-actions.c:
635 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
636 a connection before asking anything else. Correct the check for the destination
637 folder so that it succeeds when online.
638 This fixed projects.maemo.org bug NB#61645.
640 2007-07-05 Murray Cumming <murrayc@murrayc.com>
642 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
643 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
644 to fix projects.maemo.org bug NB#62439.
646 2007-07-05 Murray Cumming <murrayc@murrayc.com>
648 * src/modest-tny-account.c: (on_connection_status_changed):
649 Really do not use tny_device_force_offline() here. See the previous comment.
651 2007-07-04 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-tny-account.c: (on_connection_status_changed):
654 Do not use tny_device_force_offline() when tinymail says that something
655 went wrong with the connection. It seems to report this unnecessarily.
657 2007-07-04 Murray Cumming <murrayc@murrayc.com>
659 * src/maemo/modest-connection-specific-smtp-window.c:
660 (modest_connection_specific_smtp_window_init):
661 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
662 does not seem to have any effect in osso 1.1 (though it works in
663 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
665 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
667 * src/maemo/modest-connection-specific-smtp-window.c:
668 Fix UI specification problems with projects.meamo.org NB#60479
670 2007-07-04 Murray Cumming <murrayc@murrayc.com>
672 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
673 clue when this has failed, because the error dialog is not always shown
674 (at least in earlier version).
676 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
677 GError message, because the generic error dialog is not helpful.
679 'This message is not currently available (can't let a new connection go online)'
680 when trying to open an IMAP message.
682 (_modest_ui_actions_open): Offer a connection when some messages would
683 have to be downloaded and we are offline.
685 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
687 * src/widgets/modest-folder-view.c:
688 Don't check for MERGE type anymore as we use the correct type
690 NOTE: For the last two changes you need to update your tinymail copy
691 because of API changes!
693 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
695 * src/modest-tny-local-folders-account.c:
696 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
697 (see projects.maemo.org NB#61580)
699 2007-07-04 Murray Cumming <murrayc@murrayc.com>
701 * src/modest-tny-account.c: (on_connection_status_changed):
702 Commented out the call to modest_platform_connect_and_wait() because this
703 seems to always hang, and I would like to know if this is the only thing
704 that causes a hang when showing the connection dialog.
705 It is not very useful anyway.
707 2007-07-04 Murray Cumming <murrayc@murrayc.com>
709 * src/maemo/modest-msg-view-window.c:
710 (modest_msg_view_window_select_next_message):
712 * src/modest-platform.h:
713 * src/maemo/modest-platform.c:
714 Added modest_platform_connect_and_wait(), which calls
715 tny_maemo_conic_device_connect() always in the main thread, by calling it
716 in an idle handler and waiting for the idle handler to run. It should be
717 in the main thread because it uses GTK+ UI code. It just returns TRUE
718 if the device is already online.
720 There is some nasty code to ensure that subsequent calls to
721 modest_platform_connect_and_wait() just wait for the first one to finish,
722 by checking repeatedly in another idle handler. This is necessary,
723 because other threads (or even the main thread, via another idle handler)
724 can call modest_platform_connect_and_wait() while
725 modest_platform_connect_and_wait() is running.
727 (modest_platform_connect_and_wait_if_network_account),
728 (modest_platform_connect_and_wait_if_network_folderstore):
729 Convenience functions that calls modest_platform_connect_and_wait() if
730 the account or folder might want network access.
732 * src/modest-mail-operation.c:
733 (modest_mail_operation_update_account):
734 * src/modest-ui-actions.c: (download_uncached_messages),
735 (modest_ui_actions_on_rename_folder), (delete_folder),
736 (modest_ui_actions_on_main_window_move_to),
737 (modest_ui_actions_on_msg_view_window_move_to):
738 * src/widgets/modest-folder-view.c:
739 (drag_and_drop_from_folder_view):
740 Offer a connection if we are offline.
742 * src/modest-tny-account.c: (on_connection_status_changed):
743 Document this as only handling errors during network operations in progress,
744 and replace the idle code with a simple call to
745 modest_platform_connect_and_wait(), which does this instead.
747 2007-07-03 Murray Cumming <murrayc@murrayc.com>
749 * src/modest-tny-account.c:
750 (modest_tny_account_get_special_folder): (util_on_idle),
751 Handle the GError so we can see when tny_folder_store_get_folders()
752 fails, as it currently does while something else is connecting.
754 Added util_run_in_main_thread_and_wait()
755 which uses an idlen handler and mainloop to ensure that the function
756 is called in the main thread.
757 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
758 to make sure that we call attempt the connection in the mainloop only,
759 which might solve some hangs.
761 2007-07-03 Murray Cumming <murrayc@murrayc.com>
763 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
764 be found by their display name. This is never useful.
765 * src/modest-tny-account-store.c: (on_account_removed): Find the account
766 by its ID, instead of trying to use its ID as its display name.
768 * src/modest-tny-account-store.h:
769 * src/modest-tny-account.c:
770 (modest_tny_account_get_special_folder): Add a g_warning() when
771 tny_folder_store_get_folders() returns an empty list for the maildir.
773 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
774 Add a g_warning() when this returns NULL, because that it not allowed
777 2007-07-02 Armin Burgmeier <armin@openismus.com>
779 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
780 note when trying to cancel the wizard. This fixes projects.maemo.org
783 2007-07-02 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-tny-account.h:
786 * src/modest-tny-account.c:
787 (modest_tny_account_new_from_server_account),
788 (modest_tny_account_new_from_server_account_name),
789 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
790 because this must now be set before setting the proto. This is usd in
791 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
792 warning in camel_session_get_service() caused by
793 tny_camel_transport_account_prepare().
795 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
798 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
800 * src/maemo/modest-connection-specific-smtp-edit-window.c:
802 (modest_connection_specific_smtp_edit_window_init):
804 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
807 2007-06-29 Murray Cumming <murrayc@murrayc.com>
809 * src/modest-tny-account.c:
810 (modest_tny_account_new_from_server_account):
811 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
812 now uses to request a connection when it needs one, and which it uses
813 to tell us that something is wrong with the connection, so we can force
814 the accounts offline to prevent further problems.
817 * src/modest-init.c: (init_default_settings):
818 * src/modest-mail-operation.c:
819 (modest_mail_operation_update_account):
820 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
821 This should not be necessary anymore. Do not set the conf key that
822 determined this (it was always TRUE and not set anywhere else).
824 * src/modest-ui-actions.h: Remove unused and unimplemented
825 modest_ui_actions_on_online_toggle_toggled().
827 2007-06-29 Murray Cumming <murrayc@murrayc.com
829 * src/maemo/modest-main-window.c: (connect_signals):
830 Don't connect to delete_event twice. Maybe this was harmless.
832 2007-06-29 Murray Cumming <murrayc@murrayc.com
834 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
835 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
836 Debug output to give some more clue when a folder move is not allowed.
838 2007-06-28 Murray Cumming <murrayc@murrayc.com
840 * src/modest-tny-account.c: (on_modest_file_system_info),
841 (modest_tny_account_get_mmc_account_name):
842 Always call the callback, without checking whether the name has changed.
843 * src/widgets/modest-folder-view.c: (strings_are_equal),
844 (on_model_foreach_set_name), (on_get_mmc_account_name),
845 (text_cell_data): Compare the name here, and use the name from
846 the account rather than from the
847 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
848 if the name was changed after the account was added to the model.
849 That's a tinymail bug but not one that I want to fix now.
851 This finally fixes projects.maemo.org bug NB#59301.
853 2007-06-27 Armin Burgmeier <armin@openismus.com>
855 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
858 2007-06-27 Murray Cumming <murrayc@murrayc.com
860 * src/modest-tny-account.h:
861 * src/modest-tny-account.c:
862 Added modest_tny_account_get_mmc_account_name(), to set the memory
863 card name asynchronously for the given account and then notify.
864 (modest_tny_account_new_for_local_folders): Use this new function instead
865 of using hildon_file_system_info_async_new() directly.
867 * src/widgets/modest-folder-view.c: (text_cell_data):
868 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
869 gtk_tree_model_row_changed() when it is available.
871 This should fix projects.maemo.org bug NB#59301.
873 2007-06-27 Murray Cumming <murrayc@murrayc.com
875 * src/modest-mail-operation.c: (update_account_thread),
876 (get_msgs_full_thread): Fix typo failures in the revert
879 2007-06-27 Murray Cumming <murrayc@murrayc.com
881 * src/maemo/modest-maemo-global-settings-dialog.c:
882 (idle_select_default_focus):
883 * src/modest-mail-operation.c: (idle_notify_progress),
884 (idle_notify_progress_once), (set_last_updated_idle),
885 (update_account_thread), (get_msgs_full_thread):
886 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
887 * src/widgets/modest-header-view.c:
888 (idle_notify_headers_count_changed_destroy),
889 (idle_notify_headers_count_changed):
890 Reverted the additions of gdk_threads_enter/leave(), in case this
891 helps with a startup hang on the device.
893 2007-06-26 Armin Burgmeier <armin@openismus.com>
895 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
896 for supported secure authentication methods from server by
897 gtk_dialog_run(), saving CPU time and a potential race condition.
899 2007-06-26 Armin Burgmeier <armin@openismus.com>
901 * src/maemo/modest-maemo-utils.h:
902 * src/maemo/modest-maemo-utils.c: Added a
903 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
904 only error code to tell the calling code when the user canceled the
907 * src/maemo/modest-account-settings-dialog.h:
908 * src/maemo/modest-account-settings-dialog.c:
909 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
910 message if the retrieval of secure authentication methods was canceled
911 by the user. Perform the check before saving anything to configuration
912 to not end up with half-committed configuration changes, do not show
913 a "Saving to configuration failed" note when authentication methods
914 could not be retrieved.
916 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
919 2007-06-26 Murray Cumming <murrayc@murrayc.com>
921 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
922 Only return the first level of folders under accounts, because the
923 osso-global-search UI spec doesn't want the rest.
924 This fixed projects.maemo.org bug NB#61811.
926 2007-06-26 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-tny-account-store.c:
929 * src/modest-tny-account-store.h:
930 Added modest_tny_account_is_memory_card_account().
931 * src/maemo/modest-main-window.c: (create_details_widget):
932 Show the same information items for the memory card as we show for the
933 local-folders, to fix projects.maemo.org bug NB#59307.
935 2007-06-26 Murray Cumming <murrayc@murrayc.com>
937 * src/modest-tny-account-store.c: (get_password):
938 Added some checks for NULL to maybe prevent crashes, though I think
939 it was Philip's last commit that actually prevented the crash here
940 when creating a first new account.
941 But the new account is still not usable (no messages are shown)
942 until a restart of the application.
944 2007-06-26 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/modest-maemo-global-settings-dialog.c:
947 (idle_select_default_focus):
948 * src/modest-mail-operation.c: (idle_notify_progress),
949 (idle_notify_progress_once), (idle_notify_update_account_queue),
950 (set_last_updated_idle), (update_account_thread),
951 (notify_get_msgs_full), (get_msgs_full_destroyer),
952 (get_msgs_full_thread):
953 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
954 * src/widgets/modest-header-view.c:
955 (idle_notify_headers_count_changed_destroy),
956 (idle_notify_headers_count_changed):
957 Use gdk_threads_enter() and gdk_threads_enter_leave() in
958 all idle handlers, because some other thread could be blocking
959 the GDK lock, so that it can do GUI stuff.
961 2007-06-26 Murray Cumming <murrayc@murrayc.com>
963 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
964 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
965 (on_idle_send_receive), (on_idle_open_default_inbox):
966 * src/maemo/modest-msg-edit-window.c:
967 (modest_msg_edit_window_attach_file_noninteractive):
968 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
969 to prevent a hang. I don't quite understand why these are necessary,
970 beause we should already be in the main loop. I guess something outside
971 of the main loop is taking the lock.
973 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
974 we are really using URIs, and use files that are more likely to exist.
976 2007-06-26 Murray Cumming <murrayc@murrayc.com>
978 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
979 necessary because configure.ac now defines different variables.
981 2007-06-26 Murray Cumming <murrayc@murrayc.com>
983 * libmodest-dbus-client/libmodest-dbus-client.c:
984 * libmodest-dbus-client/libmodest-dbus-client.h:
985 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
986 libmodest_dbus_client_compose_mail() is what things actually use.
988 * src/dbus_api/modest-dbus-api.h:
989 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
990 * tests/dbus_api/Makefile.am:
991 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
994 2007-06-26 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-init.c: (modest_init_local_folders):
997 For memory-card (or other non local-folders) maildir accounts,
998 always create an Archive folder, so that there is somewhere to put
999 messages. This should be less confusing, because the user does not need
1000 to guess that the need to create a folder.
1002 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1004 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1005 Fixed icon size by using (50, 50) which is the same as defined by
1008 2007-06-25 Armin Burgmeier <armin@openismus.com>
1010 * src/widgets/modest-window-mgr.c:
1011 * src/modest-init.c:
1012 * configure.ac: Correctly recognize hildon-notify presence and fixed
1013 the build without it being installed.
1015 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1017 * libmodest-dbus-client/libmodest-dbus-client.c:
1018 (libmodest_dbus_client_search): Fix the build. Sorry.
1019 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1020 (reply_forward_cb): Initialize variables to fix the build.
1022 * src/modest-tny-account-store.c:
1023 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1024 comparison (a silly typo) so that email search results can be opened
1025 when there are more than one account.
1027 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1029 * libmodest-dbus-client/libmodest-dbus-client.c:
1030 (libmodest_dbus_client_search),
1031 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1032 instead of 1 second, because the search gets folders and messages from
1033 the server, which can take a long time. When it times out,
1034 osso-global-search will report no results.
1036 We need to specify whether we should search only cached information
1037 (maybe with a user preference), and the osso-email-search-plugin
1038 API should really be improved to allow that option, and to allow results
1039 to be delivered asynchronously in batches.
1041 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1043 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1044 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1045 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1047 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1049 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1050 that is an empty string. D-Bus seems to give us these instead of NULL.
1052 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1054 * src/dbus_api/modest-dbus-callbacks.c:
1055 * src/maemo/easysetup/modest-easysetup-wizard.h:
1056 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1057 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1058 (modest_connection_specific_smtp_edit_window_init):
1059 * src/maemo/modest-maemo-global-settings-dialog.c:
1061 * src/maemo/modest-maemo-utils.c:
1062 (modest_maemo_utils_setup_images_filechooser):
1063 * src/maemo/modest-main-window.c: (create_details_widget):
1064 * src/maemo/modest-msg-edit-window.c:
1065 (modest_msg_edit_window_attach_file_noninteractive),
1066 (modest_msg_edit_window_color_button_change),
1067 (modest_msg_edit_window_set_zoom):
1068 * src/modest-mail-operation.c: (update_account_thread):
1069 * src/modest-tny-account-store.c:
1070 * src/modest-tny-account.c:
1071 * src/widgets/modest-global-settings-dialog.c:
1072 * src/widgets/modest-window.h:
1074 Fixed build on bora!
1076 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1078 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1079 * src/modest-search.c: (modest_search_folder),
1080 (modest_search_all_accounts): Actually search only in the specified folder,
1081 doing a simple match on the folder ID.
1082 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1083 and added some documentation.
1085 2007-06-22 Armin Burgmeier <armin@openismus.com>
1087 * src/maemo/modest-maemo-utils.h:
1088 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1089 modest_maemo_utils_get_supported_secure_authentication_methods.
1091 * src/maemo/easysetup/modest-easysetup-wizard.c:
1092 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1093 one occured, not just "Server does not support secure authentication".
1095 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1097 * src/modest-tny-account-store.c: (get_password):
1098 Restored the call to tny_account_set_user() because Philip seems to have
1099 stopped this from crashing (by not using the freed string). It still does
1100 not work, but now we can test it.
1102 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1104 * src/maemo/modest-msg-edit-window.c: (init_window):
1105 Comment out use of an uninitialzed GtkScrolledWindow variable,
1106 to fix the build and stop a crash. Yet again.
1108 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1110 * src/modest-tny-account-store.c: (get_password):
1111 Remove the call to tny_account_set_user() because this actually crashes.
1112 As mentioned in the last commit, it is known to not work anyway.
1114 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1116 * src/modest-tny-account-store.c: (get_password):
1117 Use tny_account_set_username() to tell tinymail that the username might
1118 have changed too. But tinymail ignores this: see projects.maemo.org
1120 * src/modest-ui-actions.c:
1121 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1122 reset the connection when changing the username, and improve the comments.
1123 Save the changed username to gconf at least, so it is used when Modest is
1126 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1128 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1129 Do not use a query, so that we get all folders, including for POP and
1130 local-folders. They work as search criteria too.
1131 This fixes projects.maemo.org bug NB#57740.
1133 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1135 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1136 Comment out the use of hildon_notification_set_sound() because it is
1137 not declared, to fix the build. Warnings are serious, people.
1139 2007-06-21 Armin Burgmeier <armin@openismus.com>
1141 * src/maemo/modest-maemo-utils.h:
1142 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1143 modest_maemo_utils_get_supported_secure_authentication_methods()
1144 to query authentication methods for a specific user. This should fix
1145 projects.maemo.org bug NB#61369.
1147 * src/maemo/easysetup/modest-easysetup-wizard.c:
1148 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1151 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1153 * libmodest-dbus-client/libmodest-dbus-client.h:
1154 * libmodest-dbus-client/libmodest-dbus-client.c:
1155 (modest_dbus_message_iter_get_search_hit),
1156 (libmodest_dbus_client_search):
1157 Reorganised and commented this.
1158 Removed modest_search_hit_free() from the public API because it
1161 Added libmodest_dbus_client_get_folders() and
1162 modest_folder_result_list_free().
1164 * src/dbus_api/modest-dbus-api.h:
1165 * src/dbus_api/modest-dbus-callbacks.c:
1166 (modest_dbus_req_filter): Commented. Moved most code to
1167 on_dbus_method_search() and added on_dbus_method_get_folders().
1169 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1170 of the extra D-Bus handler.
1172 * tests/dbus_api/Makefile.am:
1173 * tests/dbus_api/test_get_folders.c: New test for
1174 libmodest_dbus_client_get_folders(). This seems to return an empty list
1175 at the moment. That could be the same error that causes the message list
1176 to be empty sometimes.
1177 This should help with projects.maemo.org bug NB#57740.
1179 2007-06-21 Armin Burgmeier <armin@openismus.com>
1181 * src/modest-mail-operation.c: Do not call
1182 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1183 notify the operation's end after having set the status to CANCELED for
1184 the operation queue to listen on. This fixes a deadlock when there
1185 were mail operations in the queue during its finalization.
1187 * src/modest-singletons.c: Reordered uninitialization of the account
1188 manager to happen after the mail operation queue was uninitialized
1189 because the mail operation's in the queue might still try to access
1190 the account manager (see modest_mail_operation_notify_end()). This
1191 fixes a potential crash when terminating the application.
1193 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1195 * src/modest-search.c:
1196 (search_mime_part_and_child_parts): Moved some code here so we
1197 can search recursively in child folders.
1198 (modest_search_folder): Search in the message as a mime part, instead
1199 of just its child mime parts.
1200 (read_chunk), (search_mime_part_ogs):
1201 Check how many bytes were read, to prevent an endless loop.
1202 Searching in message bodies now works. This finishes the fix for
1203 projects.maemo.org bug NB#61007.
1205 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1207 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1208 Add a g_warning when the item is not a folder.
1210 * src/modest-ui-dimming-rules.c:
1211 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1212 when selected item is not a folder (for instance, an account), because
1213 the UI spec only talks about folders.
1214 I am not sure what the UI spec wants, so this might not totally fix
1215 projects.maemo.org bug NB#60794.
1217 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1219 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1220 (load_from_file): Sort the list. The unsorted list would be more noticeable
1221 in non-English locales.
1223 * src/maemo/modest-msg-edit-window.c:
1224 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1225 warning and fix the build.
1227 * src/maemo/modest-progress-bar-widget.c:
1228 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1229 avoid a g_warning, and probably to avoid a crash.
1231 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1233 * src/modest-search.c: (modest_search_folder): Check for a GError
1234 when calling tny_folder_get_headers(), to show that this is not the cause
1237 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1239 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1240 Actually set the body query instead of the subject query.
1242 * src/modest-search.c: (search_mime_part_ogs),
1243 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1244 which would probably cause it to fail if we got this far.
1246 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1247 to simplify the code.
1248 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1249 be causing search-in-body to fail.
1251 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1253 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1255 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1256 Better debug message when the folder cannot be found.
1257 This should help with fixing projects.maemo.org bug #61287.
1258 * src/modest-search.c: (add_hit): Do not leak the furl string.
1260 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1262 * src/modest-ui-actions.c:
1263 (modest_ui_actions_on_folder_selection_changed):
1264 Do not special-case TNY_MERGE_FOLDER here, because
1265 modest_tny_folder_get_account() already does that. This fixes
1266 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1267 shown when the Outbox was selected).
1269 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1271 * libmodest-dbus-client/libmodest-dbus-client.c:
1272 (_dbus_iter_get_string_or_null): Initialize the string variable in
1273 case this helps with Dirk's crash.
1275 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1277 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1278 though it is not implemented yet (this function is maybe not even used),
1279 to avoid breaking ABI in future.
1280 * libmodest-dbus-client/libmodest-dbus-client.c:
1281 (get_attachments_string): Moved some code into this generic function.
1282 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1283 sends email. It is maybe not used.
1284 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1285 (on_send_mail): Use attachments.
1287 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1288 * src/maemo/modest-msg-edit-window.c:
1289 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1290 a filename before using it, to fix projects.maemo.org bug NB#58233.
1292 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1294 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1295 Initialize the continue_download variable to fix the build, and probably
1296 to fix randome behaviour.
1298 2007-06-18 Armin Burgmeier <armin@openismus.com>
1300 * src/modest-tny-send-queue.h:
1301 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1302 the queue so we can later show it in the UI. Replaced
1303 modest_tny_send_queue_msg_is_being_sent() by
1304 modest_tny_send_queue_get_msg_status().
1306 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1308 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1309 gpointer. This probably was not harmful, but just to be sure.
1311 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1313 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1314 Fix the build, but leave the function broken on Bora, because
1315 hildon_uri_action_get_service() does not exist.
1316 osso_uri_action_get_service() does not exist either, it seems.
1318 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1320 * src/modest-tny-account.c:
1321 (modest_tny_account_new_from_server_account):
1322 Uncommented the url debug output again, because it is useful for
1323 debugging, as I said in the comment.
1325 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1327 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1329 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1330 for Mameo Bora, to fix the build.
1332 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1335 Fixed build with hildon < 0.99
1337 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1338 Check if the selected account is busy instead of checking all accounts
1340 * src/modest-account-mgr-priv.h:
1341 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1342 (modest_account_mgr_init), (compare_account_name),
1343 (modest_account_mgr_set_account_busy),
1344 (modest_account_mgr_account_is_busy):
1345 * src/modest-account-mgr.h:
1346 Added busy information to the account manager. It possible to
1347 set an account to busy or not busy now.
1349 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1350 (modest_mail_operation_update_account),
1351 (modest_mail_operation_notify_end):
1352 Set the account to busy/not busy depending on the operation state.
1354 * src/widgets/modest-account-view.c:
1355 (modest_account_view_finalize), (get_last_updated_string),
1356 (update_account_view), (on_account_busy_changed), (init_view):
1357 Show string "Refreshing..." if the account is currently busy.
1359 All this fixes projects.maemo.org bug NB#59711
1361 2007-06-14 Armin Burgmeier <armin@openismus.com>
1363 * src/widgets/modest-attachments-view.h:
1364 * src/widgets/modest-attachments-view.c: Added
1365 modest_attachments_view_has_attachments() and fixed coordinate
1366 transformation in get_att_view_at_coords(). This fixes attachment
1369 * src/widgets/modest-msg-view.c: Make use of
1370 modest_attachments_view_has_attachments() to decide whether to show
1371 attachments in the header.
1373 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1375 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1376 (on_change), (on_combo_security_changed),
1377 (modest_connection_specific_smtp_edit_window_init),
1378 (modest_connection_specific_smtp_edit_window_set_connection),
1379 (modest_connection_specific_smtp_edit_window_is_dirty):
1380 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1381 * src/maemo/modest-connection-specific-smtp-window.c:
1384 Show an comfirmation dialog for the smpt-edit-window if there are
1385 unsaved changes and the user hits cancel.
1386 (projects.maemo.org bug NB#60479)
1388 2007-06-14 Armin Burgmeier <armin@openismus.com>
1390 * src/maemo/easysetup/modest-easysetup-wizard.c:
1391 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1392 address" info in banner instead of node, and select all the text as
1393 per UI spec. This fixes projects.maemo.org bug NB#60550.
1395 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1397 reviewed by: <delete if not using a buddy>
1399 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1400 * src/modest-ui-actions.c: (folder_refreshed_cb):
1402 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1404 * src/widgets/modest-folder-view.c: (filter_row):
1405 Explictly filter out the per-account outbox accounts. I don't know why
1406 these only sometimes show up, but now they should never show up in the UI.
1407 This should fix projects.maemo.org bug NB#60160.
1409 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1411 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1412 when the toolbar does not exist yet.
1413 * src/modest-widget-memory.c: (save_settings_header_view):
1414 Added g_warnings() to help us to discover when we are trying to set
1415 an empty columns list in gconf.
1417 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1419 * src/modest-init.h:
1420 * src/modest-init.c:
1421 Added modest_init_get_default_header_view_column_ids().
1423 * src/modest-widget-memory.c: (restore_settings_header_view):
1424 Use the new function to get defaults, if the gconf key is empty,
1425 instead of not creating any columns. This seems to fix the
1426 empty right-hand pane problems.
1428 * src/widgets/modest-header-view.h: Improved documentation.
1430 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1432 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1433 Revert the use of the display name as the account name, because this
1434 is generally wrong and would break the code that follows.
1436 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1438 * src/maemo/easysetup/modest-easysetup-wizard.c:
1439 (check_for_supported_auth_methods), (on_before_next),
1442 More correct fix for projects.maemo.org bug NB# 58991
1443 Do not longer accept AUTH_PASSWORD as secure method and choose
1444 correct method when creating the account.
1446 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1448 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1449 Fixed projects.maemo.org bug NB# 58991
1451 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1453 * src/modest-init.c: (modest_init_init_core),
1454 (modest_init_local_folders): Fixed compilation errors.
1456 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1458 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1459 Remove unnecessary lib/include, though it is good in principle when needed.
1461 * src/modest-init.c: (modest_init_one_local_folder),
1462 (modest_init_local_folders):
1463 * src/modest-init.h: Initialize the .modest library for memory cards,
1464 instead of just doing nothing for them. This should allow us to create
1465 folders there, fixing projects.maemo.org bug NB#59297.
1467 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1469 * libmodest-dbus-client/libmodest-dbus-client.c:
1470 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1471 (libmodest_dbus_client_compose_mail),
1472 (libmodest_dbus_client_open_message),
1473 (libmodest_dbus_client_send_and_receive),
1474 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1476 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1477 (on_idle_open_message), (modest_dbus_req_handler),
1478 (search_result_to_message), (modest_dbus_req_filter):
1479 * src/modest-search.c: (add_hit), (modest_search_folder),
1480 (modest_search_all_accounts): Improved debug messages.
1482 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1484 * src/modest-tny-account-store.c:
1485 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1488 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1491 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1493 * src/modest-tny-account-store.c: (get_server_accounts):
1494 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1495 even when there are no accounts, so that the Outbox folder is always
1496 visible. This fixes projects.maemo.org bug NB#60158.
1498 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1500 * src/maemo/modest-main-window.c: (create_details_widget):
1501 Use the mcen_va_never logical ID.
1503 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1505 * src/dbus_api/modest-dbus-api.h:
1506 * src/dbus_api/modest-dbus-callbacks.c:
1507 (on_idle_open_default_inbox), (on_open_default_inbox),
1508 (modest_dbus_req_handler):
1509 Added a new OpenDefaultInbox method.
1511 * libmodest-dbus-client/libmodest-dbus-client.h:
1512 * libmodest-dbus-client/libmodest-dbus-client.c:
1513 Added libmodest_dbus_client_open_default_inbox() to call the new
1514 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1515 though it should maybe be used by a new osso-email-interface function.
1517 * tests/dbus_api/Makefile.am:
1518 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1521 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1523 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1524 NULL, so that the signals get all the keys. This should not actually
1525 change any behaviour because we currently update everything when anything
1528 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1530 * src/widgets/modest-folder-view.c: (text_cell_data),
1531 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1532 (find_inbox_iter): If tinymail tells us that the folder is
1533 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1534 This causes the inbox to be selected at startup, fixing part of
1535 projects.maemo.org bug NB#56305.
1537 * src/modest-ui-dimming-rules.c:
1538 (modest_ui_dimming_rules_on_tools_smtp_servers):
1539 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1540 the SMTP servers menu item.
1541 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1542 that the SMTP Servers menu item is dimmed when there are no accounts,
1543 as a future version of the UI spec will require. This fixes
1544 projects.maemo.org bug NB#56305.
1546 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1548 * src/maemo/modest-maemo-utils.c:
1549 (modest_maemo_utils_get_supported_secure_authentication_methods):
1550 Added label to dialog instead of unreadable title
1552 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1553 (modest_main_window_new):
1554 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1557 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1558 * src/modest-account-mgr.h:
1559 Added method to avoid code duplication
1561 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1562 (modest_ui_actions_on_send_receive):
1563 Use modest_account_mgr_has_accounts
1565 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1567 * src/maemo/easysetup/modest-presets.c:
1568 (modest_presets_get_info_server_security): Do not report secure auth
1570 * src/modest-protocol-info.c: Use the defines for the gconf key names
1571 for secure authentication. This was not working because we were writing
1572 Password and reading password, and the check was case sensitive.
1573 With this, gmail now works for receiving and sending when created via
1576 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1578 * src/maemo/easysetup/modest-presets.c:
1579 (modest_presets_get_info_server_security): Correct the key name for
1580 SecureSmtp, because it seems to be case-sensitive.
1581 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1582 Do not try to get the 0th notebook page if there are 0 pages, to
1583 avoid a g_warning().
1585 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1587 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1588 Prevent use of the new notification feature for now, because it currently
1589 shows one dialog for each new email, which is annoying.
1591 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1593 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1594 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1595 when no country was selected, so that we show the global ones.
1596 * src/maemo/easysetup/modest-presets.c:
1597 (modest_presets_get_providers): Return only the global providers, not
1598 all providers when mmc=0 was requested.
1600 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1602 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1603 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1604 provider ID in the combo.
1606 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1607 Do not show the page numbers, because it would be confusing when we add
1608 the 2 extra pages for the custom setup, when the user chooses the "Other"
1609 provider. This fixes projects.maemo.org bug NB#59028
1611 * src/modest-init.c: (modest_init_init_core),
1612 (modest_init_local_folders):
1613 * src/modest-init.h:
1614 * src/modest-tny-account.c:
1615 (modest_tny_account_new_for_local_folders): Do not create default folders
1616 for the memory card. This should fix projects.maemo.org bug NB#59328.
1618 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1620 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
1621 Free the changed_conf_keys string items. They are already freed in the
1622 idle handler if that runs first.
1624 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1626 * src/modest-ui-actions.c:
1627 (modest_ui_actions_on_password_requested): Check that the server name
1628 is not NULL, because I just saw a password dialog with (null) as the
1631 * src/modest-tny-folder.[h|c]: Added
1632 modest_tny_folder_is_memory_card_folder().
1633 * src/modest-ui-dimming-rules.c:
1634 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
1635 menu item for memory cards, as per the UI spec (section 7.4). This should
1636 fix projects.maemo.org bug NB#59297.
1638 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
1640 * src/maemo/modest-main-window.c: (sync_accounts_cb):
1641 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
1642 is another problem with the code, see Murray's comment at line 772)
1644 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1646 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
1647 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1648 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
1649 (load_from_file), (easysetup_country_combo_box_init),
1650 (easysetup_country_combo_box_get_active_country_ids),
1651 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
1652 instead of just one ID, to avoid duplicate country names in the UI.
1654 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
1655 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1656 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
1657 a single ID, avoiding duplicate providers.
1658 * src/maemo/easysetup/modest-easysetup-wizard.c:
1659 (on_combo_account_country): Adapt to use a list.
1661 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1663 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
1664 keys changed in the last X seconds.
1666 * src/modest-account-mgr.h:
1667 * src/modest-account-mgr.c: (on_timeout_notify_changes),
1668 (on_key_change), (modest_account_mgr_class_init),
1669 (modest_account_mgr_init), (modest_account_mgr_finalize):
1670 As the keys are changed, save them in a GSList* and signal that GSList*
1671 further every X seconds, to batch changes, to allow us to do just one
1672 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
1673 bug NB#56941 and other (UI-blocking) delays when changing account settings.
1675 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
1676 changed signal signature.
1678 * src/modest-conf.c: (modest_conf_set_list),
1679 (modest_conf_on_change): Reenable notification.
1681 (modest_conf_maemo_fake_on_change): Comment out the hack that
1682 notified immediately instead of asynchronously.
1684 * src/widgets/modest-account-view.h:
1685 * src/widgets/modest-account-view.c:
1686 (update_account_view): Select the previously-selected account ID,
1687 if possible. This fixes projects.maemo.org bug NB#56933.
1689 (on_account_changed), (on_account_removed),
1690 (modest_account_view_select_account):
1692 Remove the block/unblock functions
1693 because they were not useful.
1695 * src/maemo/modest-account-view-window.c:
1696 (on_delete_button_clicked), (on_edit_button_clicked),
1697 (on_new_button_clicked): Remove the use of the non-working block/unblock.
1699 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1701 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1702 Improve the error dialog to show Incorrect Account Settings, which seems
1703 clearer, and say that the internal error message (to be removed from the
1704 dialog later) is often misleading.
1705 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
1707 * src/modest-tny-account.c:
1708 (modest_tny_account_new_from_server_account): Uncomment the printf of the
1709 URL because this is so useful for debugging on the device.
1711 * src/widgets/modest-serversecurity-combo-box.c:
1712 (modest_serversecurity_combo_box_fill): Correct a logical ID.
1714 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1716 * src/modest-mail-operation.c:
1717 (modest_mail_operation_send_new_mail):
1718 Added a comment about a nasty but apparently harmless message. Details
1719 added to the wiki g_warnings() page.
1721 2007-06-08 Murray Cumming <murrayc@murrayc.com>
1723 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
1724 (modest_tny_send_queue_class_init):
1725 Do not use the priv struct because it is empty, to avoid g_warnings
1726 about a non-existant priv struct.
1728 * src/modest-tny-account-store.c:
1729 (modest_tny_account_store_get_server_account),
1730 (modest_tny_account_store_get_transport_account_for_open_connection
1731 ): Do not try to get transport server accounts for local folders,
1732 because they don't have any. This avoids a g_warning().
1734 * src/maemo/modest-main-window.c:
1735 (modest_main_window_notify_send_receive_initied),
1736 (on_configuration_key_changed):
1737 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
1738 * src/modest-defs.h:
1739 * src/modest-mail-operation.c:
1740 (modest_mail_operation_update_account):
1741 * src/modest-tny-account-store.h:
1742 * src/modest-tny-account.c:
1743 (modest_tny_account_get_special_folder),
1744 (modest_tny_account_new_for_local_folders),
1745 (modest_tny_account_new_for_per_account_local_outbox_folder):
1746 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
1747 * src/modest-tny-local-folders-account.c:
1748 (add_account_folders_to_merged_folder):
1749 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1750 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
1751 (modest_ui_actions_on_send):
1752 * src/widgets/modest-folder-view.c: (update_model):
1753 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
1754 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
1755 modest_tny_account_store_get_tny_account_by_account() to
1756 modest_tny_account_store_get_server_account() to make the code clearer.
1758 2007-06-07 Marcus Bauer <marcusb@openismus.com>
1760 * src/dbus_api/modest-dbus-api.h:
1761 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
1762 * src/maemo/modest-msg-edit-window.c:
1763 (modest_msg_edit_window_attach_file_noninteractive):
1764 added g_warning in case the file to be attached does not exist
1765 * tests/dbus_api/test_compose_mail.c: (main):
1766 removed obsolete comment, added generic files as test case
1768 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1770 * src/modest-tny-account-store.c: (get_server_accounts):
1771 Create the local folders account only once, not once for each outbox, and
1772 not only when there are some outboxes.
1774 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1776 * src/widgets/modest-folder-view.c: (update_model): Comment out some
1777 code that is causing a crash at startup. Sergio says that he is fixing this.
1779 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
1781 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1782 * src/maemo/modest-account-settings-dialog.c:
1783 (create_page_outgoing),
1784 (modest_account_settings_dialog_set_account_name),
1785 (save_configuration):
1786 - Fixed handling of the "Use secure authentication" toggle to comply with
1787 the ui specification. See also projects.maemo.org bug NB#58400
1789 - Restore the Secure connection setting combo correctly when loading
1792 * src/maemo/modest-maemo-utils.c:
1793 (on_camel_account_get_supported_secure_authentication),
1794 (modest_maemo_utils_get_supported_secure_authentication_methods):
1795 Fixed a crasher if operation is canceled
1797 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
1798 (modest_protocol_info_auth_is_secure):
1799 * src/modest-protocol-info.h:
1801 Added two new methods to determine if a protocol/auth method is secure/encrypted in
1802 the sense of the "Use secure authentication" toggle.
1804 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1806 * src/modest-tny-account-store.h:
1807 * src/modest-tny-account-store.c:
1808 Added modest_tny_account_store_get_local_folders_account().
1810 * src/modest-tny-folder.h:
1811 * src/modest-tny-folder.c:
1812 (modest_tny_folder_get_account):
1813 Added this replacement for tny_folder_get_account() which returns
1814 the local-folders account for TnyMergeFolders, to avoid the
1815 warning about the unimplemented get_account_func() vfunc().
1817 (modest_tny_folder_get_rules),
1818 * src/modest-ui-actions.c:
1819 (modest_ui_actions_on_folder_selection_changed):
1820 * src/modest-mail-operation.c:
1821 (modest_mail_operation_remove_folder),
1822 (modest_mail_operation_xfer_folder),
1823 (modest_mail_operation_rename_folder),
1824 (modest_mail_operation_get_msg),
1825 (modest_mail_operation_get_msgs_full),
1826 (modest_mail_operation_remove_msg),
1827 (modest_mail_operation_xfer_msgs),
1828 (modest_mail_operation_refresh_folder):
1829 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
1831 2007-06-07 Murray Cumming <murrayc@murrayc.com>
1833 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
1834 (modest_server_account_set_security):
1835 * src/modest-defs.h: Add comments explaining that our
1836 UI spec means TLS when it says Normal, so these do not look like errors.
1838 * src/modest-tny-account.c:
1839 (modest_tny_account_new_from_server_account): Use the new tinymail
1840 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
1841 for TLS. This should fix projects.maemo.org bug NB#58460.
1843 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1845 * src/maemo/easysetup/modest-easysetup-wizard.c:
1846 (create_account): Correct the position of the gconf sanity check warning.
1847 (on_button_edit_advanced_settings): Show the dialog immediately, instead
1848 of using the g_idle_add() hack, because this does not seem to be necessary
1849 on osso 1.1. It might even work on Maemo Bora if the problems were actually
1850 caused by something other than maemo's gconf.
1851 This fixes projects.maemo.org bug #59022.
1853 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-account-mgr-helpers.c:
1856 (modest_account_mgr_get_default_account): Do not check that the account
1857 exists if there is no default account (NULL), to fix a runtime warning.
1859 2007-06-06 Murray Cumming <murrayc@murrayc.com>
1861 * src/widgets/modest-folder-view.c: (update_model):
1862 Do not unref the treemodel before we have finished with it.
1863 This prevents a valgrind warning and an occasional crash at startup.
1865 2007-06-06 Marcus Bauer <marcusb@openismus.com>
1867 * libmodest-dbus-client/libmodest-dbus-client.h:
1868 added libmodest_dbus_client_compose_mail()
1869 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1871 added functions needed for SendAsMail() functionality
1872 * src/maemo/modest-msg-edit-window.c:
1873 (modest_msg_edit_window_attach_file_noninteractive):
1874 non interactively attaching files to message edit window
1875 * src/widgets/modest-msg-edit-window.h:
1876 * tests/dbus_api/Makefile.am:
1877 added test_compose_mail.c
1878 * tests/dbus_api/test_compose_mail.c: (main):
1880 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1882 * src/modest-account-view.c:
1883 Fixed bug projects.maemo.org bug NB#59307
1885 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1887 * src/maemo/easysetup/modest-easysetup-wizard.c:
1888 (get_serverport_incoming), (on_before_next), (create_account):
1889 * src/maemo/modest-account-settings-dialog.c:
1890 (modest_account_settings_dialog_set_account_name):
1891 * src/maemo/modest-maemo-utils.c:
1892 (on_camel_account_get_supported_secure_authentication_status),
1893 (on_camel_account_get_supported_secure_authentication),
1894 (on_secure_auth_cancel),
1895 (modest_maemo_utils_get_supported_secure_authentication_methods):
1897 Implemented security authentication for settings and easysetup.
1899 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1901 * src/maemo/modest-main-window.c: (create_details_widget):
1902 Show the total size for memory card accounts too, instead of showing
1903 the name again. Fixes bug projects.maemo.org bug NB#59307.
1905 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1908 * src/modest-tny-simple-folder-store.c:
1909 * src/modest-tny-simple-folder-store.h: Removed.
1911 * src/modest-tny-local-folders-account.h
1912 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1913 for the local-folders maildir, with an extra TnyMergedFolder containing
1914 the folders of the per-account outbox store accounts.
1915 * src/modest-tny-account-store.c: (get_server_accounts):
1916 Add the outboxes to the special local folders account after creating it.
1918 * src/modest-tny-account.c:
1919 (modest_tny_account_new_for_local_folders): Create the derived
1920 account when creating the main local-folders account.
1922 * src/maemo/modest-main-window.c: (create_details_widget),
1923 (modest_main_window_set_contents_style):
1924 Adapted to the use of the derived account instead of the folder store.
1926 * src/modest-ui-actions.c:
1927 (modest_ui_actions_on_folder_selection_changed):
1928 * src/modest-ui-dimming-rules.c:
1929 (modest_ui_dimming_rules_on_new_folder):
1930 * src/widgets/modest-folder-view.c: (text_cell_data),
1931 (icon_cell_data), (filter_row), (update_model),
1932 (get_cmp_rows_type_pos):
1935 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1936 Do not get the priv struct, because no priv struct has been set,
1937 to avoid a runtime warning.
1939 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1940 #ifelse with #else, to fix a warning, to fix the build.
1943 2007-06-05 Christian Kellner <ckellner@openismus.com>
1945 * libmodest-dbus-client/libmodest-dbus-client.c:
1946 Fix small typo in doc (why do you always see them
1947 AFTER committing stuff?)
1950 2007-06-05 Christian Kellner <ckellner@openismus.com>
1952 * libmodest-dbus-client/libmodest-dbus-client.c:
1953 (libmodest_dbus_client_search):
1954 Initialize hit list with NULL. Also set folder list
1955 to "" if NULL was supplied.
1958 2007-06-03 Christian Kellner <ckellner@openismus.com>
1960 * libmodest-dbus-client/libmodest-dbus-client.c:
1961 (modest_search_hit_list_free):
1962 Make it save to call it with NULL.
1964 * src/dbus_api/modest-dbus-callbacks.c:
1965 * src/modest-search.c:
1966 Return full ModestSearchHits as the search result list not TnyHeader
1967 since can't be around withouth the correspoding TnyFolder.
1969 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1971 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1972 Added currently commented code to check for secure auth
1974 * src/maemo/modest-account-settings-dialog.c: (on_response),
1975 (save_configuration), (show_ok):
1976 Fixed projects.maemo.org bugs NB #59248 and #59251
1978 * src/maemo/modest-maemo-utils.c:
1979 (on_camel_account_get_supported_secure_authentication_status),
1980 (on_camel_account_get_supported_secure_authentication),
1981 (modest_maemo_utils_get_supported_secure_authentication_methods):
1982 * src/maemo/modest-maemo-utils.h:
1983 Moved get_supported_secure_authentication() method here to be able
1984 to use it from easysetup wizard.
1986 * src/modest-pair.c: (on_pair_compare_as_string):
1987 Should compare string with first part of pair and not
1988 strcmp pairs which will crash.
1990 * src/modest-protocol-info.c:
1991 (modest_protocol_info_protocol_is_store):
1992 * src/modest-protocol-info.h:
1993 Added modest_protocol_info_get_auth_protocol_name()
1995 2007-06-03 Armin Burgmeier <armin@openismus.com>
1997 * src/modest-mail-operation.c:
1998 (modest_mail_operation_get_msgs_full): Set priv->account also when
1999 only retrieving a single message. This avoids a crash when canceling
2002 (modest_mail_operation_notify_end): Do not explicitely remove the
2003 operation from the queue but only emit the progress_changed signal.
2004 The queue itself listens to that signal to remove the operation when
2005 it is finished. This reduces coupling and removes a potential deadlock
2006 when modest_mail_operation_notify_end() is called from the queue
2007 itself. If that is a problem performance-wise, I would suggest to
2008 implement a status-changed signal or something.
2010 * src/modest-mail-operation-queue.c: Make sure to never call a
2011 function from another file while the queue is locked. This (hopefully)
2012 fixes another deadlock when exiting the application while retrieving
2015 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2017 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2018 Fixed build if libogs is not available
2020 2007-06-03 Christian Kellner <ckellner@openismus.com>
2022 * libmodest-dbus-client/libmodest-dbus-client.h:
2023 * libmodest-dbus-client/libmodest-dbus-client.c:
2024 (libmodest_dbus_client_delete_message):
2025 Implement deletion of messages (Client side).
2027 (modest_search_hit_free),
2028 (modest_search_hit_list_free):
2029 Utility functions to free the result hits.
2031 * src/dbus_api/modest-dbus-api.h:
2032 * src/dbus_api/modest-dbus-callbacks.c:
2033 (on_delete_message),
2034 (modest_dbus_req_handler):
2035 Implement deletion of messages (Server side).
2037 * tests/dbus_api/test_search.c: (main):
2040 * tests/dbus_api/Makefile.am:
2041 * tests/dbus_api/test_delete_message:
2042 Add little test for the message deletion logic
2044 2007-06-03 Armin Burgmeier <armin@openismus.com>
2046 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2047 when the operation queue was not empty. projects.maemo.org bug
2050 2007-06-03 Armin Burgmeier <armin@openismus.com>
2052 * src/widgets/modest-account-view.c
2053 (on_account_default_toggled): Toggle default account column
2054 explicitely instead of waiting for gconf notification (which is
2055 currently ignored). This should fix projects.maemo.org bug NB#56910
2056 for now. It should probably be removed when gconf notifications are
2059 2007-06-03 Christian Kellner <ckellner@openismus.com>
2061 * libmodest-dbus-client/libmodest-dbus-client.c:
2062 Removed debugging spew.
2064 * src/dbus_api/modest-dbus-callbacks.c:
2065 Added debugging info.
2067 * src/modest-search.c:
2068 (modest_search_all_accounts):
2069 Use tny_account_store_get_accounts () on the account store
2070 to get all accounts which is the way to get all accounts.
2072 * tests/dbus_api/test_search.c: (main):
2073 Make it possible to supply the search term on the command line.
2075 2007-06-03 Christian Kellner <ckellner@openismus.com>
2077 * libmodest-dbus-client/libmodest-dbus-client.c:
2078 * libmodest-dbus-client/libmodest-dbus-client.h:
2079 Implement searching for mesages over raw dbus. (Client side)
2081 * src/dbus_api/Makefile.am:
2082 * src/dbus_api/modest-dbus-api.h:
2083 * src/dbus_api/modest-dbus-callbacks.c:
2084 * src/dbus_api/modest-dbus-callbacks.h:
2085 Search framework (Server side). Also implement on_idle_open_message().
2087 * src/maemo/modest-platform.c: (modest_platform_init):
2088 Prepare for raw dbus/osso rpc interaction.
2090 * src/modest-search.h:
2091 Changed minsize from unspecific guint to guint32.
2093 * src/modest-search.c:
2095 Added strange hack which magically made tnymail work.
2097 (modest_search_folder),
2098 (modest_search_account),
2099 (modest_search_all_accounts):
2100 Implement helper functions to search all accounts, specific account
2103 * tests/dbus_api/Makefile.am:
2104 * tests/dbus_api/test_open_message.c:
2105 Read url to open from commandline.
2107 * tests/dbus_api/test_search.c:
2108 Implement small test for dbus search stuff
2110 2007-06-02 Armin Burgmeier <armin@openismus.com>
2112 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2113 include account type and account title. This fixes projects.maemo.org
2116 * src/maemo/modest-account-view-window.c: Set a title for the window.
2118 2007-06-02 Armin Burgmeier <armin@openismus.com>
2120 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2121 incoming and outgoing server name based on email address and server
2122 types as long as the names have not been edited manually. This fixes
2123 projects.maemo.org bug NB#58671.
2125 2007-06-02 Armin Burgmeier <armin@openismus.com>
2127 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2128 server type cannot be changed in future to the incoming details page
2129 when creating an account. This fixes projects.maemo.org bug NB#59029.
2131 2007-06-02 Armin Burgmeier <armin@openismus.com>
2133 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2134 and assigned max width chars so that they wrap instead of being
2135 truncated. Fixes projects.maemo.org bug NB#56126.
2137 2007-06-02 Armin Burgmeier <armin@openismus.com>
2139 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2140 introductory note to the connection specific smtp servers dialog, as
2141 section 8.12 of the email UI specification requires. This fixes
2142 projects.maemo.org bug NB#59212.
2144 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2146 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2147 Check for running mail operations, and offer to cancel them, as per the UI
2148 spec. This fixes projects.maemo.org bug NB#59041 .
2149 However, I suspect that tinymail may still use the network connection
2150 in ways that we cannot detect or cancel. But it should at least adapt to
2151 changes fairly well.
2153 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2155 * src/modest-tny-account-store.c: (recreate_all_accounts),
2156 (get_cached_accounts), (get_server_accounts): Do more sensible
2157 ref-counting of the temporarily-cached outbox accounts list. This seems
2158 to fix a crash when entering the password when the password was wrong.
2160 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2162 * src/gnome/modest-main-window.c: (connect_signals):
2163 * src/modest-tny-account-store.c: (get_password),
2164 (modest_tny_account_store_alert): Added comments and clues and
2165 commented-out code about how we currently fail to deal with connection
2166 errors and wrong passwords, and how we should.
2168 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2170 * src/widgets/modest-retrieve-combo-box.c:
2171 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2172 This fixes projects.maemo.org bug NB#58472 .
2174 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2176 * src/maemo/easysetup/modest-easysetup-wizard.c:
2177 (create_page_complete_easysetup):
2178 (create_page_complete_custom): Correct the last commit,
2179 putting the correct sentences in the correct pages.
2181 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/easysetup/modest-easysetup-wizard.c:
2184 (create_page_complete_custom): Show the second sentence of text
2185 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2188 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2190 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2191 Set the leave-on-server conf key by default. This fixes
2192 projects.maemo.org bug NB#59258 .
2194 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/modest-account-view-window.c:
2197 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2198 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2201 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2203 * src/maemo/easysetup/modest-easysetup-wizard.c:
2204 (create_caption_new_with_asterisk):
2205 * src/maemo/modest-account-settings-dialog.c:
2206 (create_caption_new_with_asterisk):
2207 Uncomment the code to add the asterisk, because they are no longer in the
2208 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2209 (update_incoming_server_title): Add an asterisk here too.
2211 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2213 * src/maemo/modest-maemo-global-settings-dialog.c:
2214 (current_connection): Check that we are even connected before trying to
2215 get the current connection name, to prevent a warning.
2217 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2218 Change the comments because tny_maemo_conic_device_connect() is now meant to
2220 * src/modest-mail-operation.c:
2221 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2222 make sure we have a connection and fail if we can't connect.
2224 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2226 * src/maemo/modest-main-window.c:
2227 (on_account_store_connecting_finished): Do not try to get the
2228 connection ID if we are not really connected. I am surprised that
2229 this signal handler is called when we are not connected.
2231 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2233 * src/modest-error.h:
2234 * src/modest-ui-actions.c:
2235 (modest_ui_actions_get_msgs_full_error_handler):
2236 Renamed an enum, added comments, added an enum
2237 for retrieve-limit errors.
2239 * src/modest-mail-operation.c: (foreach_add_item),
2240 (internal_folder_observer_update), (update_account_thread),
2241 (modest_mail_operation_get_msgs_full):
2242 (modest_mail_operation_update_account),
2243 Added comments about how this works, and some code that should
2244 (but does not) check the retrieve-limit. See the TODO comment.
2246 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2248 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2249 Initialize help_id to fix the build. Warnings are good.
2251 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2253 * src/widgets/modest-hbox-cell-renderer.c:
2254 (modest_hbox_cell_renderer_append):
2255 * src/widgets/modest-vbox-cell-renderer.c:
2256 (modest_vbox_cell_renderer_append):
2257 Fix the last commit by doing an extra ref.
2259 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2261 * src/widgets/modest-hbox-cell-renderer.c:
2262 (modest_hbox_cell_renderer_append):
2263 * src/widgets/modest-vbox-cell-renderer.c:
2264 (modest_vbox_cell_renderer_append):
2265 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2266 to fix the build with Maemo Bora.
2267 However, there seems to be a remaining crash, probably due to reference
2270 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2272 * src/modest-tny-account.c:
2273 (modest_tny_account_new_for_local_folders):
2274 Use hildon_file_system_info_async_new() to get a better name for
2275 the memory card account, setting it as the account name.
2276 The timing seems to work, but this is probably
2277 not the best place to do this. See the TODO comment.
2278 * src/maemo/modest-main-window.c: (create_details_widget):
2279 * src/widgets/modest-folder-view.c: (text_cell_data):
2280 Use the tny account name instead of hardcoding a name.
2282 2007-05-30 Christian Kellner <ckellner@openismus.com>
2284 * src/modest-search.c: (modest_search):
2285 Correctly set part_search_func even if we have already parsed
2286 the query and thus a valid OgsTextSearcher object.
2288 2007-05-30 Christian Kellner <ckellner@openismus.com>
2291 Search and check for libogs.
2294 Incooparte the ogs build env.
2296 * src/modest-mime-part-search-stream.c:
2297 * src/modest-mime-part-search-stream.h:
2298 Removed since we do the real searching now in modest-search.c.
2300 * src/modest-search.c:
2301 * src/modest-search.h:
2302 Implement support for ogs. We use that if available and requested
2303 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2304 should now handle the corner case when the search term is spread
2305 across multiple reads.
2306 Also the logic in modest_search () was corrected to search all
2307 requested fields until one is found.
2309 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2311 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2313 * src/modest-init.h:
2314 * src/modest-init.c: Made modest_init_local_folders() take a
2315 path and be public so we can iniitialize maildir folders on
2318 * src/modest-local-folder-info.h:
2319 * src/modest-local-folder-info.c:
2320 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2322 * src/modest-tny-account.c:
2323 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2324 still means the standard local-folders path on the local volume.
2326 * src/modest-tny-account-store.c:
2327 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2328 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2329 all accounts when that happens.
2330 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2331 this too, so it shows up in the treeview.
2333 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2335 * src/maemo/modest-maemo-global-settings-dialog.c:
2336 (current_connection):
2337 * src/widgets/modest-global-settings-dialog.c:
2338 (current_connection_default):
2339 Use the enum values instead of 0, 1 and -1,
2340 to make the code clearer.
2342 * src/modest-account-mgr-helpers.c:
2343 (modest_account_mgr_get_connection_specific_smtp): Make this code
2346 * src/modest-runtime.h:
2347 * src/modest-runtime.c:
2348 Added modest_runtime_remove_all_send_queues().
2349 * src/maemo/modest-main-window.c:
2350 (on_account_store_connecting_finished): Recreate the send queues,
2351 using the appropriate transport accounts for this new connection.
2352 Some futher adapting might be needed if the old send queues are not
2353 automatically stopped at this point.
2355 * src/modest-tny-account-store.c: (get_server_accounts):
2356 Create the connection-specific transport accounts, so that they can
2357 be found later by their ID.
2359 * src/modest-tny-account.h:
2360 * src/modest-tny-account.c:
2361 Added modest_tny_account_new_from_server_account_name().
2362 modest_tny_account_new_from_server_account(): Do not create the
2363 send queues here, because they will be
2364 recreated anyway when the connection changes for the first time.
2366 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2368 * src/modest-local-folder-info.h:
2369 * src/modest-local-folder-info.c:
2370 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2371 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2372 tbox_folder): Take a modest account name instead of a server TnyAccount,
2373 so we can have per-modest-account rather than per-transport-account
2375 We must make sure that we change or recreate the exisitng send queues
2376 when the connection changes for connection-specific transport accounts.
2378 * src/modest-tny-account-store.c:
2379 (create_per_account_local_outbox_folders): Create outboxed per modest
2380 account, not per transport account.
2382 * src/modest-tny-account.h:
2383 * src/modest-tny-account.c:
2384 (modest_tny_account_get_special_folder): For outboxes, get the
2385 parent modest account name. The account is ignored for other folders.
2386 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2387 modest account name rather than a server TnyAccount.
2389 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2391 * src/modest-tny-account.c:
2392 (modest_tny_account_new_from_server_account):
2393 Call modest_runtime_get_send_queue() immediately after creating transport
2394 accounts, so that they start trying to send email from the outbox as soon
2395 as possible at startup. This is probably what we want.
2397 * src/modest-mail-operation.c: (update_account_thread):
2398 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2399 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2400 * src/modest-tny-send-queue.h:
2401 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2402 (modest_ui_actions_on_send):
2403 Added comments about how sending works, though it needs some more work.
2405 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2407 * src/modest-tny-account.c:
2408 (modest_tny_account_get_special_folder): Add TODO because this fails when
2409 the network is busy.
2410 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2411 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2412 Do not try to show this window when there is no active account. The UI
2413 specs does not tell us what to do in this case.
2415 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2419 * src/maemo/Makefile.am:
2420 * src/widgets/Makefile.am: Some dist fixes.
2422 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2424 * src/maemo/modest-connection-specific-smtp-window.c:
2425 (on_button_edit): Make the code clearer, to prevent a double free.
2427 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2429 * src/maemo/modest-account-settings-dialog.c:
2430 (modest_account_settings_dialog_set_account_name),
2431 Check the connection-specific smtp servers checkbox if there are any.
2433 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2434 (modest_connection_specific_smtp_edit_window_init):
2435 Start with a suitable port number.
2437 * src/modest-account-mgr-helpers.h:
2438 * src/modest-account-mgr-helpers.c: Added
2439 modest_account_mgr_get_has_connection_specific_smtp().
2441 (modest_account_mgr_set_connection_specific_smtp),
2442 (modest_account_mgr_remove_connection_specific_smtp),
2443 (modest_account_mgr_get_has_connection_specific_smtp),
2444 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2445 connection-specific smtp server accounts in the account, rather than
2446 the server account conf dir.
2448 This fixes bug projects.maemo.org bug NB#58263 .
2450 * src/modest-tny-account-store.c:
2451 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2452 if there are no server accounts yet, to prevent an infinite loop when there
2453 are no accounts. Document that one must be called before the other.
2455 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2457 * src/modest-account-mgr-helpers.c:
2458 (modest_account_mgr_get_default_account): Make sure that at least
2459 one account is always the default, if there are any enabled accounts.
2460 This is just a sanity check that shouldn't be necessary.
2462 * src/modest-account-mgr-priv.c:
2463 (_modest_account_mgr_account_from_key): Unescape the conf key to
2464 get the real account name. For instance, this is an issue if a space
2465 was in the account name, which can happen because the account name
2466 is generated from the display name.
2467 (_modest_account_mgr_get_account_keyname): Always escape the
2469 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2470 Unescape the conf keys to get the real account names.
2472 For instance, previously the is-default radio button in the accounts
2473 list was not checked for any accounts at first. This fixes that,
2474 and might fix several similar bugs.
2476 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2478 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2479 Removed some debug printfs.
2481 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2483 Modest on-disk outbox directories are now here, for instance:
2484 $HOME/.modest/outboxes/<account-id-1>/outbox
2485 $HOME/.modest/outboxes/<account-id-2>/outbox
2487 $HOME/.modest/local-folders/outbox
2488 so we can have a separate outbox for each account.
2489 But they are shown as one outbox in the GtkTreeView, by using a
2490 TnyMergeFolder in a ModestTnySimpleFolderStore.
2493 * src/modest-tny-simple-folder-store.c:
2494 * src/modest-tny-simple-folder-store.h:
2495 Added ModestTnySimpleFolderStore, used to contain folders from
2496 other folder stores, such as other accounts.
2498 * src/modest-tny-outbox-account.h:
2499 * src/modest-tny-outbox-account.c:
2500 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2501 used for the per-account local outbox folders.
2503 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2504 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2505 only use this (internally) now for the non-outbox local folders.
2507 * src/modest-init.h:
2508 * src/modest-init.c: Added modest_init_one_local_folder(), for
2509 setting up the directory structure for each local folder.
2511 * src/modest-local-folder-info.c:
2512 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2513 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2515 * src/modest-local-folder-info.h:
2516 * src/modest-tny-account-store.c: (on_account_removed),
2517 (on_account_changed), (create_per_account_local_outbox_folders),
2518 (get_server_accounts), (modest_tny_account_store_get_accounts),
2519 (modest_tny_account_store_get_tny_account_by_account),
2520 (modest_tny_folder_store_is_virtual_local_folders):
2522 * src/modest-tny-account.h:
2523 * src/modest-tny-account.c:
2524 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2525 to create an on-disk per-account local outbox folder for each
2527 (create_per_account_local_outbox_folders): Create a local outbox folder
2528 for each transport account.
2529 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2530 for all local folders.
2532 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2533 instead of using g_object_get/set() directly. It is clearer.
2535 (modest_tny_folder_store_get_message_count),
2536 (modest_tny_folder_store_get_local_size
2537 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2538 because we now use these with non-acount folder stores.
2540 (modest_tny_account_get_special_folder),
2541 (modest_tny_account_new_from_server_account),
2542 (modest_tny_account_new_from_account):
2543 (recurse_folders): Adjust to the new outbox system.
2545 * src/modest-tny-folder.h:
2546 * src/modest-tny-folder.c:
2547 (modest_tny_folder_is_local_folder),
2548 (modest_tny_folder_get_local_folder_type),
2549 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2551 * src/widgets/modest-main-window.h:
2552 * src/maemo/modest-main-window.c: (create_details_widget),
2553 (modest_main_window_set_contents_style): Show details for any folder store,
2556 (modest_tny_folder_get_rules):
2557 Remove the const. C does not support constness enough for this.
2559 * src/modest-ui-actions.c:
2560 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2561 make all outboxes appear as one, in the usual local-folders tree node.
2563 (set_active_account_from_tny_account),
2564 (modest_ui_actions_on_folder_selection_changed):
2565 * src/widgets/modest-folder-view.c: (text_cell_data),
2566 (icon_cell_data), (filter_row),
2567 (add_account_folders_to_merged_folder),
2568 (add_account_folders_to_simple_folder_store), (),
2569 (get_cmp_rows_type_pos), (cmp_rows),
2570 (modest_folder_view_set_account_id_of_visible_server_account):
2571 Adjust to the new outbox system, using generic folder stores and folders
2572 in the GtkTreeModel.
2574 2007-05-23 Christian Kellner <ckellner@openismus.com>
2576 * src/modest-mail-operation.c:
2577 (modest_mail_operation_update_account):
2578 Use info->max_size instead of unintialized local var [small
2579 build fix]. (Added TODO to review that change since I don't
2582 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2584 * libmodest-dbus-client/libmodest-dbus-client.c:
2585 (libmodest_dbus_client_compose_mail): function added
2586 * src/dbus_api/modest-dbus-api.h:
2587 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2588 (on_compose_mail): Implementation of the SendAsMail functionality
2590 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2592 * src/modest-account-mgr.c:
2593 (modest_account_mgr_add_server_account): Set the secure-connection
2594 conf key for transport accounts as well as store accounts. I don't know
2595 why the if was there. For instance, this makes sure that we use SSL
2596 for the gmail preset from the easysetup wizard.
2598 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2600 * src/gnome/modest-main-window.c:
2601 (on_account_store_connecting_finished), (connect_signals):
2602 * src/maemo/modest-main-window.c:
2603 (on_account_store_connecting_finished), (connect_signals),
2604 (modest_main_window_new):
2605 Handle TnyAccountStore::connecting-finished instead of
2606 TnyDevice::connection-changed, because we cannot actually perform
2607 operations on accounts until TnyAccountStore has itself responded to
2608 the TnyDevice::connection-changed signal. This prevents a GError from
2610 Do not try to update at startup, because we (at least on scratchbox)
2611 already do an update at startup when the device goes online.
2612 This prevents a GError from tinymail.
2613 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2614 Added TODO about stopping simultaneous operations.
2616 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2618 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2619 * src/modest-mail-operation-queue.c:
2620 (modest_mail_operation_queue_remove):
2621 * src/modest-tny-account-store.c: When GErrors happen, give more clues
2622 about where they happened.
2624 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2626 * src/modest-ui-actions.c:
2627 (modest_ui_actions_on_password_requested): Make sure that the remember
2628 output parameter is always TRUE.
2630 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2633 Show a OK/Cancel dialog if the error is a question, though we still do not
2634 know anything more about what we are asking the user.
2635 * src/widgets/modest-folder-view.c: (on_drag_data_received):
2636 Fix an uninitialized variable (helper). This is a logic error, however.
2638 2007-05-21 Christian Kellner <ckellner@openismus.com>
2640 * src/modest-search.h:
2641 Correct bit shifting in the ModestSearchFlags enum.
2643 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2645 * src/modest-tny-account.c:
2646 (modest_tny_account_new_from_server_account): Do not use the lsub and
2647 check-all hard-coded IMAP options when using POP.
2649 2007-05-21 Murray Cumming <murrayc@murrayc.com>
2651 * src/modest-tny-account.c:
2652 (modest_tny_account_new_from_server_account):
2653 Use NULL for the secure-auth method for POP when Password auth has been
2654 specified by the user, as we already do for IMAP. "auth=Login" causes
2655 an error from camel or the server.
2657 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2659 * src/maemo/modest-account-settings-dialog.c:
2660 (create_page_account_details),
2661 (modest_account_settings_dialog_set_account_name):
2662 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
2663 for the leave-on-server checkbox, rathr than just the checkbox, when
2664 the protocol is not POP.
2666 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2668 * src/widgets/modest-account-view.c:
2669 * src/widgets/modest-account-view.h:
2670 Added modest_account_view_select_account() which will be useful later
2671 to asynchronously re-select the edited account.
2673 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2675 * src/maemo/modest-account-settings-dialog.c:
2676 (modest_account_settings_dialog_set_account_name):
2677 Automatically choose the port numbers based on the secure authentication
2678 methods, if they have not been chosen before.
2679 This fixes projects.maemo.org bug NB#56273 .
2681 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2683 * src/maemo/modest-main-window-ui.h:
2684 * src/modest-ui-actions.c:
2685 * src/modest-ui-actions.h:
2686 Connect the Tools/SMTP Servers menu item to
2687 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
2688 SMTP servers dialog, as in the UI specification and saves changes when it
2689 is closed. This fixed projects.maemo.org bug NB#56305 .
2691 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2693 * src/maemo/modest-connection-specific-smtp-window.c:
2694 (modest_connection_specific_smtp_window_init):
2695 Use gtk_window_set_default_size() to make this window big enough, so
2696 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
2698 2007-05-17 Murray Cumming <murrayc@murrayc.com>
2700 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2701 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2702 (modest_connection_specific_smtp_edit_window_init),
2703 Do not try to connect to a combobox signal before the combobox exists.
2704 This fixes the cras in projects.maemo.org bug NB#56288 .
2705 (modest_connection_specific_smtp_edit_window_get_settings):
2706 Remove the server_account_name parameter which was being checked for NULL
2707 though it was not used.
2709 * src/maemo/modest-connection-specific-smtp-window.c:
2710 (modest_connection_specific_smtp_window_fill_with_connections),
2711 (on_button_edit), (modest_connection_specific_smtp_window_init):
2712 Correct the number of treemodel columns to prevent a warning.
2713 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
2714 libconic does not work.
2716 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2718 * src/modest-tny-account.c:
2719 (modest_tny_account_new_from_server_account):
2720 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
2721 SMTP when "None" was chosen by the user. However, with my SMTP server that
2722 does not support ANONYMOUS, the emails do not leave the Outbox and I see
2725 2007-05-16 Murray Cumming <murrayc@murrayc.com>
2727 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
2728 to explain the memory management issue with the ID in the ModestPair.
2730 * src/gnome/modest-account-assistant.c: (add_receiving_page),
2731 (add_sending_page), (modest_account_assistant_finalize):
2732 * src/gnome/modest-gnome-global-settings-dialog.c:
2733 (create_updating_page), (create_composing_page):
2734 * src/gnome/modest-msg-edit-window.c: (get_transports),
2735 (init_window), (modest_msg_edit_window_finalize),
2736 (modest_msg_edit_window_get_msg_data):
2737 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
2738 * src/gnome/modest-transport-widget.c:
2739 (modest_transport_widget_finalize), (smtp_configuration):
2740 * src/maemo/modest-maemo-global-settings-dialog.c:
2741 (create_updating_page), (create_composing_page):
2742 * src/maemo/modest-msg-edit-window.c: (get_transports),
2743 (init_window), (modest_msg_edit_window_finalize),
2744 (modest_msg_edit_window_get_msg_data),
2745 (modest_msg_edit_window_free_msg_data):
2746 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
2747 (modest_store_widget_finalize):
2748 * src/maemo/modest-transport-widget.c:
2749 (modest_transport_widget_finalize), (smtp_configuration):
2750 * src/modest-main.c: (send_mail):
2751 * src/widgets/modest-combo-box.h:
2752 * src/widgets/modest-global-settings-dialog-priv.h:
2753 * src/widgets/modest-global-settings-dialog.c:
2754 (modest_global_settings_dialog_finalize):
2755 * src/widgets/modest-msg-edit-window.h:
2756 Whenever using modest_combo_box_new(), keep the ModestPairList alive
2757 as long as the combo box, to prevent use of freed memory for the ID.
2759 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2761 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
2762 get_accounts(), to make this clearer. Do not check for the enabled gconf
2763 key, because we do not use this for server accounts (at least, not yet).
2764 This allows us to send email again.
2766 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2768 * src/maemo/modest-platform.c:
2769 (on_modest_conf_update_interval_changed), (modest_platform_init):
2770 Only respond to this particular key change. All these strcmp()s cannot be
2773 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2775 * src/maemo/modest-maemo-global-settings-dialog.c:
2776 (current_connection): Prevent a crash in scratchbox when
2777 ny_maemo_conic_device_get_current_iap_id() returns NULL.
2778 * src/maemo/modest-platform.c:
2779 (on_modest_conf_update_interval_changed), (modest_platform_init):
2780 Get the update interval from gconf and reset it when the gconf key changes.
2782 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2784 * src/modest-protocol-info.c:
2785 * src/modest-protocol-info.h: Adde enum-specific get functions,
2786 instead of using a ModestProtocolType enum parameter.
2788 * src/gnome/modest-account-assistant.c:
2789 * src/gnome/modest-store-widget.c:
2790 * src/gnome/modest-store-widget.h:
2791 * src/gnome/modest-transport-widget.c:
2792 * src/gnome/modest-transport-widget.h:
2793 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
2794 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
2795 * src/maemo/easysetup/modest-easysetup-wizard.c:
2796 * src/maemo/modest-account-settings-dialog.c:
2797 * src/maemo/modest-account-settings-dialog.h:
2798 * src/maemo/modest-store-widget.c:
2799 * src/maemo/modest-store-widget.h:
2800 * src/maemo/modest-transport-widget.c:
2801 * src/maemo/modest-transport-widget.h:
2802 * src/modest-account-mgr-helpers.c:
2803 * src/modest-account-mgr-helpers.h:
2804 * src/modest-account-mgr.c:
2805 * src/modest-account-mgr.h:
2806 * src/modest-tny-account.c:
2807 * src/modest-tny-folder.c:
2808 * src/widgets/modest-account-view.c:
2809 * src/widgets/modest-retrieve-combo-box.c:
2810 * src/widgets/modest-retrieve-combo-box.h:
2811 * src/widgets/modest-secureauth-combo-box.c:
2812 * src/widgets/modest-serversecurity-combo-box.c:
2813 * src/widgets/modest-serversecurity-combo-box.h:
2814 * tests/check_account-mgr.c:
2815 Use the specific functions, and use the re-renamed enum values for GNOME too.
2817 2007-05-15 Murray Cumming <murrayc@murrayc.com>
2819 * src/modest-pair.h:
2820 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
2821 so we can get the second based on the first.
2823 * src/maemo/modest-account-settings-dialog.h:
2824 * src/maemo/modest-account-settings-dialog.c:
2825 Added get_supported_secure_authentication_methods(), though it is mostly
2826 commented-out for now until the necessary API is committed to tinymail.
2827 (modest_account_settings_dialog_set_account_name),
2828 (save_configuration): Request the supported authentication methods from the
2829 server, so we can choose a working method.
2831 * src/modest-tny-account-store.h:
2832 * src/modest-tny-account-store.c:
2833 (modest_tny_account_store_get_session): Rename from
2834 tny_account_store_get_session().
2836 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2838 * src/modest-protocol-info.h: Split the ModestProtocol enum
2839 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
2840 There was no need to have these unrelated values in one enum.
2842 * src/: many files: Adapted to changed enum. This makes the code a bit
2843 clearer, and the compiler could catch some errors.
2845 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2847 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2848 Show the detailed internal camel error message when an error happens
2849 during the configuration, so that our testers can give us more clues.
2850 For instance, in projects.maemo.org bug NB#56910 .
2852 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2854 * src/modest-tny-account.c:
2855 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
2856 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
2858 2007-05-14 Murray Cumming <murrayc@murrayc.com>
2860 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2861 * src/maemo/modest-account-settings-dialog.c:
2862 (modest_account_settings_dialog_set_account_name),
2863 (save_configuration): For the incoming secure authentication checkbox,
2864 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
2865 the UI specification. PLAIN does not seem to be supported for most IMAP
2866 servers anyway, and I am not sure what it would mean.
2867 However, we probably need to discover which of the secure-authentication
2868 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
2869 * src/modest-account-mgr-helpers.c:
2870 (modest_account_mgr_get_server_account_data):
2872 * src/modest-tny-account.c:
2873 (modest_tny_account_new_from_server_account):
2874 Use tny_account_set_mech() to set secure-authentication methods,
2875 with some special-casing for IMAP, based on my observations of how
2878 * src/modest-account-mgr-helpers.h:
2879 * src/modest-account-mgr.c:
2880 * src/modest-defs.h: Comment that the URI is only used for local folders.
2882 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2885 parameter const, just to be neat.
2886 * src/modest-text-utils.c: (modest_text_utils_inline):
2887 End g_strconcat() with NULL, as its documentation says. This is almost
2888 certainly the cause of my crash at startup on the device. Interestingly,
2889 valgrind doesn't tell us about these errors.
2891 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2893 * scripts/build-packages: Added more precise comments about how to use
2894 this script, though I still get this error:
2895 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2896 error building tinymail
2898 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2900 * src/maemo/modest-main-window.c: (on_account_update):
2901 Very slight cleanup, hoping to make it simpler to discover what causes
2902 a crash here sometimes.
2904 * src/modest-tny-account.c:
2905 (modest_tny_account_new_from_server_account): Set the port. Added
2906 comments about the options and a TODO comment because I need to find out
2907 how to specify the secure authentication method.
2909 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2911 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2912 changed CFlags paths form modest to libmodest
2914 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2916 * src/modest-account-mgr-helpers.c:
2917 (modest_account_mgr_get_server_account_data),
2918 (modest_account_mgr_free_server_account_data):
2919 * src/modest-account-mgr-helpers.h:
2920 * src/modest-account-mgr.c:
2921 (modest_account_mgr_add_server_account):
2922 * src/modest-defs.h:
2923 * src/modest-tny-account.c:
2924 (modest_tny_account_new_from_server_account):
2925 Determine the options for tny_camel_account_add_option() here,
2926 based on the settings, rather than storing them directly in gconf.
2928 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2930 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2931 Show a more friendly error dialog now that we expect (from the tinymail
2932 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2934 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2936 * src/maemo/modest-main-window.c: (on_account_update): Check that
2937 account_name is not NULL, to prevent a crash at startup that I am
2938 seeing on the N800. I do wonder why it is NULL.
2940 * src/maemo/easysetup/modest-easysetup-wizard.c:
2941 (create_page_user_details):
2942 * src/maemo/modest-account-settings-dialog.c:
2943 (create_page_user_details), (create_page_outgoing):
2944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2945 (modest_connection_specific_smtp_edit_window_init):
2946 * src/modest-ui-actions.c:
2947 (modest_ui_actions_on_password_requested):
2948 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2949 might do something useful with the on-screen keyboard.
2951 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2953 * src/maemo/modest-main-window.c: (on_account_update):
2954 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2955 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2957 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2959 * src/modest-tny-account-store.c: (on_account_changed):
2960 Correct the signature of this signal handler.
2962 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2964 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2965 Show a HildonNote instead of a GtkDialog for Maemo.
2967 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2969 * src/widgets/modest-account-view.h:
2970 * src/widgets/modest-account-view.c: (on_account_changed),
2971 (on_account_removed). Added a boolean flag, set/unset by
2972 modest_account_view_block_conf_updates(),
2973 modest_account_view_unblock_conf_updates() to prevent unnecessary
2974 updates, but this is not very useful because the gconf notifications are
2975 so delays (maybe only on Maemo Bora).
2976 So auto-updating is turned off, and these functions do an explicit
2977 update when necessary.
2978 However, something else is still doing too much work when adding/removing
2979 accounts, probably in another part of the application.
2981 * src/maemo/modest-account-view-window.c:
2982 (on_delete_button_clicked), (on_edit_button_clicked),
2983 (on_new_button_clicked): Use the new functions.
2985 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2987 * src/modest-account-mgr-helpers.c:
2988 (modest_account_mgr_set_first_account_as_default):
2989 Sort the list of names alphabetically-by-title, so we choose the first one
2991 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2992 alphabetically by the title.
2994 This fixes projects.maemo.org bug NB#56418 .
2996 * src/modest-account-mgr-priv.c:
2997 (_modest_account_mgr_account_from_key):
2998 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2999 avoid a valgrind error, and possible random behaviour.
3001 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3003 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3004 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3005 tinymail documentation to say that this can be expected.
3006 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3007 pretty, and should not happen, but I would prefer to know when it does.
3009 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3011 * configure.ac: When using the older hildon version, probably on Bora,
3012 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3014 * src/widgets/modest-attachment-view.c:
3015 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3018 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3020 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3021 Implemented the prototype. Can be tested with
3022 tests/dbus_api/test_open_message:
3024 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3026 * src/modest-tny-account-store.c:
3027 (modest_tny_account_store_instance_init), (get_password):
3028 * src/modest-ui-actions.c:
3029 (modest_ui_actions_on_password_requested):
3030 Do not store the password in gconf, because this function is called
3031 for non-remembered passwords. Actually use the cached (in the hash map)
3032 password instead of releasing it.
3033 The password will now not be remembered if it is asked via the protected
3034 password dialog, as per the UI spec.
3036 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3038 * src/modest-defs.h:
3039 * src/modest-account-mgr-helpers.h:
3040 * src/modest-account-mgr-helpers.c:
3041 Added modest_server_account_get_username_has_succeeded(),
3042 modest_server_account_set_username_has_succeeded().
3043 (modest_server_account_set_username),
3044 Reset the has-succeeded flag if the username changes.
3046 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3047 * src/maemo/modest-connection-specific-smtp-window.c:
3048 (modest_connection_specific_smtp_window_save_server_accounts):
3049 Use modest_server_account_set_username() instead of using
3050 modest_conf_set_string() directly, so that the has-succeeded flag is always
3053 * src/modest-ui-actions.c:
3054 (modest_ui_actions_on_password_requested): Dim the username entry if
3055 the username has ever worked, as per the UI spec.
3057 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3059 * src/modest-tny-account-store.c: (get_password):
3060 * src/modest-ui-actions.c:
3061 (modest_ui_actions_on_password_requested):
3062 Allow the username to be changed too, though there is more work to
3063 be done on exactly how this behaves.
3065 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3067 * src/modest-account-mgr-helpers.h:
3068 * src/modest-account-mgr-helpers.c:
3069 Added modest_account_mgr_get_display_name(),
3070 modest_server_account_get_username(),
3071 modest_server_account_set_username(),
3072 modest_server_account_set_password(),
3073 modest_server_account_get_hostname() functions so we do not need to
3074 use the conf API directly.
3076 * src/maemo/modest-main-window.c: (connect_signals):
3077 Actually connect ot the ModestAccountStore::request-password signal,
3078 so that we show the dialog when the password is requested by Tinymail,
3079 for isntance if it is empty.
3081 * src/modest-marshal.list:
3082 * src/modest-tny-account-store.c:
3083 (modest_tny_account_store_class_init), (get_password),
3084 (modest_tny_account_store_alert):
3085 * src/modest-tny-account-store.h:
3086 * src/modest-ui-actions.h:
3087 * src/modest-ui-actions.c:
3088 (modest_ui_actions_on_password_requested):
3089 Change the signal parameters, so it is obvious that we are providing
3090 the non human-readable server name, and receiving both the username
3091 and password, though changing of the username is not yet implemented.
3092 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3093 for the GNOME version.
3095 This should fix the projects.maemo.org bug NB#56209, though it does not
3096 work on Bora, because the gconf_client_get() for the password fails
3097 immediately after we save it with gconf_client_set().
3099 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3102 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3103 caused an undefined symbol error:
3104 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3106 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3108 * src/modest-tny-account-store.c:
3109 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3110 using a GError instead of a string message, so we can translate it in
3113 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3115 * src/maemo/modest-address-book.c:
3116 (modest_address_book_check_names):
3117 * src/maemo/modest-msg-view-window.c:
3118 (modest_msg_view_window_clipboard_owner_change):
3119 * src/modest-init.c: (modest_init_init_ui):
3120 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3121 (update_folders_cb), (modest_mail_operation_update_account):
3122 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3123 (modest_ui_actions_on_msg_attachment_clicked),
3124 (modest_ui_actions_on_msg_recpt_activated):
3125 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3126 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3127 (modest_msg_view_search_next):
3128 * src/widgets/modest-recpt-editor.c:
3129 (modest_recpt_editor_on_button_release_event),
3130 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3131 g_message(). At this point we should only be seeing interesting errors on
3132 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3134 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3136 (modest_wizard_dialog_force_title_update):
3137 * src/maemo/easysetup/modest-wizard-dialog.h:
3138 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3139 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3140 can update the title when appropriate. Otherwise the title is wrong if the
3141 pages are added after adding the notebook to the dialog.
3142 This must be a problem in HildonWizardDialog too.
3143 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3145 * src/maemo/easysetup/modest-easysetup-wizard.c:
3146 (create_subsequent_customsetup_pages),
3147 (create_subsequent_easysetup_pages):
3148 Call modest_wizard_dialog_force_title_update() so that the title is
3149 correct even with GTK+ < 2.10.
3150 This fixes projects.maemo.org bug NB#56145 .
3152 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3154 * src/maemo/modest-platform.c:
3155 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3156 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3159 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3161 * src/widgets/modest-window.h:
3162 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3163 and modest_window_save_state(), which invokes it.
3165 * src/widgets/modest-window-mgr.h:
3166 * src/widgets/modest-window-mgr.c:
3167 Added modest_window_mgr_save_state_for_all_windows(), which calls
3168 the save_state vfunc on all registered windows, if implemented.
3170 * src/gnome/modest-msg-edit-window.c:
3171 * src/gnome/modest-msg-view-window.c:
3172 * src/maemo/modest-msg-edit-window.c:
3173 * src/maemo/modest-msg-view-window.c:
3174 * src/maemo/modest-main-window.c:
3175 Specify the existing save_settings functions as implementations of
3176 ModestWindow::save_state_func().
3178 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3179 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3180 enabling hibernation, for instance.
3182 We may need to do the same thing for restoring settings.
3185 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3187 * src/widgets/modest-window-mgr.c:
3188 * src/widgets/modest-window-mgr.h:
3189 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3190 modest_window_mgr_get_hibernation_is_prevented().
3192 * src/maemo/modest-main-window.c:
3193 (on_hildon_program_is_topmost_notify): Prevent hibernation
3194 (possible when the application goes to the background in the WM),
3195 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3197 * src/maemo/easysetup/modest-easysetup-wizard.c:
3198 (modest_easysetup_wizard_dialog_init):
3199 * src/maemo/modest-account-settings-dialog.c:
3200 (modest_account_settings_dialog_init):
3201 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3202 (modest_connection_specific_smtp_edit_window_init):
3203 * src/maemo/modest-connection-specific-smtp-window.c:
3204 (modest_connection_specific_smtp_window_init):
3205 * src/maemo/modest-signature-editor-dialog.c:
3206 (modest_signature_editor_dialog_init):
3207 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3208 prevent hibernation while any of these account settings dialogs are open.
3210 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3212 * src/maemo/Makefile.am:
3213 * src/maemo/modest-osso-state-saving.c:
3214 * src/maemo/modest-osso-state-saving.h: Added
3215 modest_osso_load_state() and modest_osso_save_state() though they do
3216 nothing now. They should iterate through all the open windows and load/save
3218 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3219 save state when closing.
3221 * src/maemo/modest-main-window.c:
3222 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3223 Add a notification handler for the HildonProgram::is-topmost property,
3224 so we can allow hibernation when the application goes into the background.
3225 But we still need to detect when the accounts setup windows are open so
3226 we can stop hibernation when they are open.
3227 To do this, I also added the main window the HildonProgram. This might have
3228 other side-effects/benefits, and should maybe be done for other windows.
3230 * src/maemo/modest-osso-autosave-callbacks.h:
3231 * src/maemo/modest-osso-autosave-callbacks.c:
3232 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3233 though it does not do anything yet, and we might never need this to do
3234 anything. For instance, we already save drafts.
3236 * src/maemo/modest-platform.c: (modest_platform_init):
3237 Specify the libosso auto-save callback.
3239 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3241 * src/maemo/modest-platform.c:
3242 (modest_platform_set_update_interval):
3243 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3244 aparently stays valid between application instances, so we can use this
3245 to remove and reset it later. According to a maemo-developers email from
3248 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3250 * configure.ac: Depend on libalarm for Maemo.
3252 * src/dbus_api/modest-dbus-api.h:
3253 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3254 (on_send_receive), (modest_dbus_req_handler):
3255 Handle a SEND_RECEIVE D-Bus method.
3257 * libmodest-dbus-client/libmodest-dbus-client.c:
3258 (libmodest_dbus_client_send_and_receive):
3259 * libmodest-dbus-client/libmodest-dbus-client.h:
3260 Add C convenience functions for calling the new D-Bus method.
3262 * src/modest-platform.h:
3263 * src/gnome/modest-platform.c:
3264 * src/maemo/modest-platform.c:
3265 Added modest_platform_set_update_interval(), which uses the
3266 alarmd API on Maemo.
3267 (modest_platform_init),
3268 Call modest_platform_set_update_interval(), using a hard-coded
3269 interval for now (until the global settings dialog is implemented),
3270 though I am not sure that this makes sense yet.
3272 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3274 * src/dbus_api/modest-dbus-callbacks.c:
3275 (modest_osso_cb_hw_state_handler):
3276 * src/dbus_api/modest-dbus-callbacks.h:
3277 * src/maemo/modest-platform.c: (modest_platform_init):
3278 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3279 in case this has some effect on the ability for Maemo to ping the
3282 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3284 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3285 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3286 warning. It is probably a logic error, but I need to fix the build.
3288 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3290 * src/modest-account-mgr.h:
3291 * src/modest-account-mgr.c:
3292 (modest_account_mgr_account_names): Add a gboolean enabled_only
3293 parameter, so we can get lists of onlt the enabled accounts.
3295 (modest_account_mgr_add_account),,
3296 (modest_account_mgr_account_with_display_name_exists):
3297 * src/maemo/modest-msg-edit-window.c: (get_transports):
3298 * src/modest-account-mgr-helpers.c:
3299 (modest_account_mgr_set_first_account_as_default):
3300 * src/modest-init.c: (init_default_account_maybe):
3301 * src/modest-tny-account-store.c: (get_accounts):
3302 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3303 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3304 * tests/check_account-mgr.c: (START_TEST):
3305 Provide the extra parameter, as appropriate.
3307 * src/widgets/modest-account-view.c: (update_account_view):
3308 Do not show disabled accounts (meaning that there is no way to
3309 enable/disable accounts in the UI (the feature is not in our UI
3310 specification), so we can use this internally only to mark unfinished
3311 or temporary account data.
3313 * src/maemo/easysetup/modest-easysetup-wizard.c:
3314 (create_account): Add boolean enable parameter, so we can specify FALSE
3315 to create the temporary account.
3316 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3317 (on_before_next): When finishing, when there is a temporary account, just
3319 Also, use a timeout to delay the showing of the dialog until gconf is likely
3320 to return correct information, due to a maemo gconf bug that is fixed in
3321 osso 1.1, but not yet in Bora.
3322 However, the dialog stays on screen after it is destroyed.
3324 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3325 for invalid data when cancelling. Use a hildon note instead of a dialog
3326 to complain about invalid data. Do not show the account-saved note if the
3327 account is disabled (a temporary account that will not really be saved for use
3330 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3332 * src/modest-account-mgr-helpers.h:
3333 * src/modest-account-mgr-helpers.c:
3334 Added modest_account_mgr_unset_default_account(),
3335 Added modest_account_mgr_set_first_account_as_default().
3337 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3338 If it was the default account, unset the default account name.
3340 * src/maemo/modest-account-view-window.c:
3341 (on_delete_button_clicked): If it was the default account,
3342 set the first remaining account as the default instead.
3344 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3345 a NULL account or a NULL default account, to prevent a crash. This should
3346 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3349 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3351 * src/widgets/modest-recpt-editor.c:
3352 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3353 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3354 TODO comment for this. This fixes the build.
3356 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3357 be the best place for it. This will in future update all auto-update accounts,
3358 rather than just the current/default account, when that gconf key exists.
3359 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3360 if there are no accounts, before calling do_send_receive().
3361 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3363 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3364 * src/maemo/modest-main-window-ui.h:
3365 * src/maemo/modest-main-window.c: (on_connection_changed),
3366 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3367 directly, becaue the signal handler does more.
3369 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3371 * src/modest-account-mgr-helpers.c:
3372 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3373 for the case that the account does not exist.
3375 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3376 (equivalent to the modest account name) rather than the tinymail account name
3377 (equivalent to the modest account title - human readable) to get the account data.
3378 Check for null account data to prevent the crash, and add a TODO comment saying that
3379 this needs fixing because it is using the server account name instead of the account name.
3381 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3383 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3384 * src/maemo/modest-account-settings-dialog.c: (show_error),
3386 Use hildon_note_new_information() for informative and error messages,
3387 which seems to be expected for Maemo applications (no documentation that I know of
3388 says this). I am surprised that there is no distinction between info and error
3391 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3393 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3394 it is easy to find where this is used.
3396 * src/maemo/easysetup/modest-easysetup-wizard.c:
3397 (create_page_welcome), (create_page_account_details),
3398 (create_page_user_details), (create_page_complete_easysetup),
3399 (create_page_custom_incoming), (create_page_custom_outgoing),
3400 (create_page_complete_custom):
3401 * src/maemo/modest-account-settings-dialog.c:
3402 (create_page_account_details), (create_page_user_details),
3403 (create_page_incoming), (create_page_outgoing):
3404 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3405 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3406 (modest_connection_specific_smtp_edit_window_init):
3407 * src/maemo/modest-connection-specific-smtp-window.c:
3408 (modest_connection_specific_smtp_window_init):
3409 * src/maemo/modest-signature-editor-dialog.c:
3410 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3411 and scrolling policy as per the Email Application Layout Guide, if I have
3414 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3416 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3417 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3418 which were empty, because these vfuncs have been removed from TnyAccountStore.
3419 This fixes the build.
3421 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3423 * src/maemo/modest-main-window.c:
3424 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3425 showing/hiding it. Added TODO because it probably should not be NULL.
3426 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3427 because unnecessary g_warnings() make degugging difficult.
3429 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3431 * src/maemo/modest-msg-edit-window.c:
3432 (modest_msg_edit_window_select_color),
3433 (modest_msg_edit_window_select_background_color): 2 const corrections and
3434 moving 2 #endifs before closing brackets, to fix the build.
3436 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3438 * src/maemo/easysetup/modest-easysetup-wizard.h:
3439 * src/maemo/easysetup/modest-easysetup-wizard.c:
3440 (modest_easysetup_wizard_dialog_finalize),
3441 (on_button_edit_advanced_settings), (create_page_complete_custom),
3442 (on_response), (create_account):
3443 Implement the Advanced Settings edit button, by saving the account information,
3444 for the Advanded Settings dialog to use directly from gconf, and removing it
3445 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3446 Bug #5533 in the projects.maemo.org bugzilla.
3448 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3450 * src/maemo/modest-msg-view-window.c:
3451 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3452 when opening a message window.
3454 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3456 * src/maemo/easysetup/modest-easysetup-wizard.c:
3457 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3460 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3461 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3462 gconf settings. I probably added more checks than necessary, but that is safer.
3464 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3465 variable to fix the build, but this seems to be used when it is still NULL.
3467 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3469 * src/modest-platform.h:
3470 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3471 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3472 * src/modest-main.c: Implement this function so we can avoid using
3473 maemo-specific API from cross-platform code.
3475 * src/modest-tny-account-store.c:
3476 (get_smtp_specific_transport_account_for_open_connection):
3477 * src/modest-ui-actions.c: (check_for_connection),
3478 (modest_ui_actions_on_item_not_found):
3479 Use modest_platform_connect_and_wait() and put #idefs around other
3480 maemo-specific code, because only maemo currently has a way to
3481 identify connection names.
3483 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3485 * src/modest-tny-account-store.h:
3486 * src/modest-tny-account-store.c:
3487 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3488 the connection-specific SMTP server settings in the configuration.
3490 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3492 * src/maemo/modest-main-window.c: (on_connection_changed),
3494 * src/modest-main.c: (main), (start_ui), (send_mail):
3495 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3496 that is what is intended.
3498 * src/modest-ui-actions.c: (action_send), (action_receive),
3499 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3500 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3501 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3502 SMTP server is used when it is specified.
3504 (modest_ui_actions_on_send_receive):
3505 Check that a connection is open before proceeding.
3506 Receive and then send, instead of vice-versa, as per the specification.
3508 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3510 * src/modest-mail-operation.c:
3511 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3512 though I guess it should be something other than NULL.
3514 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3516 * src/maemo/easysetup/modest-easysetup-wizard.c:
3517 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3518 combo twice, to avoid an g_warning and to make it visible again.
3519 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3520 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3521 (already intended) dereference when detaching, because we then recreate the menu.
3522 But I am not sure why the warning was happening, and it is possible that this is a memory
3525 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3527 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3528 and uri_parse_mailto() utility functions.
3529 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3531 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3533 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3535 * src/dbus_api/modest-dbus-api.h:
3536 * src/dbus_api/modest-dbus-callbacks.c:
3537 Use an idle callback to execute the modest code in the application's own thread.
3538 Remove the helloworld example method.
3539 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3540 parsed, and the open-message method is not implemented because this is not yet implemented in
3542 * libmodest-dbus-client/libmodest-dbus-client.c:
3543 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3544 (libmodest_dbus_client_open_message):
3545 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3547 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3548 body without crashing.
3550 * tests/dbus_api/Makefile.am:
3551 * tests/dbus_api/test_mail_to.c:
3552 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3554 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3556 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3557 Added file to fix the build. Sorry.
3559 * src/dbus_api/Makefile.am:
3560 * src/dbus_api/modest-dbus-api.h:
3561 * src/dbus_api/modest-dbus-callbacks.h:
3562 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3563 (modest_dbus_req_handler):
3564 Put constants in a separate header so it can be reused by the
3565 client library, without duplication
3567 * libmodest-dbus-client/Makefile.am:
3568 * libmodest-dbus-client/libmodest-dbus-client.c:
3569 (libmodest_dbus_client_call_helloworld),
3570 (libmodfest_dbus_client_send_mail),
3571 (libmodfest_dbus_client_mailto),
3572 (libmodfest_dbus_client_open_message):
3573 * libmodest-dbus-client/libmodest-dbus-client.h:
3574 (Partly) Implement a send_mail D-Bus method.
3576 * tests/dbus_api/Makefile.am:
3577 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3578 the send_email D-Bus method.
3580 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3584 * libmodest-dbus-client/Makefile.am:
3585 * libmodest-dbus-client/libmodest-dbus-client.c:
3586 * libmodest-dbus-client/libmodest-dbus-client.h:
3587 * tests/dbus_api/Makefile.am:
3588 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3589 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3591 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3593 * src/maemo/easysetup/modest-easysetup-wizard.c:
3594 (create_page_account_details):
3595 * src/maemo/modest-account-settings-dialog.c:
3596 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3597 widgets, because this might not be the default in future versions of the Maemo GTK+.
3598 However, I can not not get capitalization to work even in a simple test case.
3600 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3602 * src/maemo/easysetup/modest-easysetup-wizard.c:
3603 (create_page_custom_incoming), (create_page_custom_outgoing):
3604 * src/maemo/modest-account-settings-dialog.c:
3605 (create_page_account_details), (create_page_incoming),
3606 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3607 instead of using gtk_check_button_with_label(), so they are aligned like the other
3608 widgets, as per the UI spec.
3610 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3612 * src/maemo/easysetup/modest-easysetup-wizard.c:
3613 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3614 * src/widgets/modest-validating-entry.c:
3615 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3616 Modest prefix instead of an EasySetup prefix.
3618 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3620 * src/widgets/modest-validating-entry.h:
3621 * src/widgets/modest-validating-entry.c: (on_insert_text),
3622 Added easysetup_validating_entry_set_max_func(), used to set a callback
3623 to call when the max number of characters is reached. GtkEntry has a max-length
3624 already but is silent about it.
3626 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
3627 (create_page_account_details), (create_page_user_details),
3629 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
3630 (create_page_account_details), (create_page_user_details),
3631 (create_page_outgoing):
3632 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
3633 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
3634 the UI spec, when the user tries to enter more than the max number of characters.
3636 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3638 * src/maemo/easysetup/modest-easysetup-wizard.c:
3639 (create_page_user_details), (create_page_custom_incoming),
3640 (create_page_custom_outgoing):
3641 * src/maemo/modest-account-settings-dialog.c:
3642 (create_page_user_details), (create_page_incoming),
3643 (create_page_outgoing):
3644 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3645 (modest_connection_specific_smtp_edit_window_init):
3646 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
3647 not appropriate. Bad Maemo-specific defaults!.
3649 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3651 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
3652 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
3653 (modest_signature_editor_dialog_set_settings):
3654 Disable the label and textview when the checkbox is disabled, and use the
3655 specified (UI spec) default signature text.
3657 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3659 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3660 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
3662 * src/modest-defs.h:
3663 * src/modest-account-mgr-helpers.h:
3664 * src/modest-account-mgr-helpers.c:
3665 Added modest_account_mgr_get/set_signature(), using new gconf keys.
3667 * src/maemo/Makefile.am:
3668 * src/maemo/modest-signature-editor-dialog.c:
3669 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
3672 * src/maemo/modest-account-settings-dialog.h:
3673 * src/maemo/modest-account-settings-dialog.c:
3674 (modest_account_settings_dialog_finalize), (on_button_signature),
3675 (save_configuration): Use the new dialog when the Edit button is pressed, and
3676 save the changes if necessary, as per the UI spec.
3678 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3680 * src/maemo/Makefile.am:
3681 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
3682 based on maemo-develoers email from Dirk.
3684 * src/maemo/easysetup/modest-easysetup-wizard.c:
3685 (create_page_welcome), (create_page_account_details),
3686 (create_page_user_details), (create_page_complete_easysetup),
3687 (create_page_custom_incoming), (create_page_custom_outgoing),
3688 (create_page_complete_custom),
3689 (modest_easysetup_wizard_dialog_init):
3690 * src/maemo/modest-account-settings-dialog.c:
3691 (create_page_account_details), (create_page_user_details),
3692 (create_page_incoming), (create_page_outgoing),
3693 (modest_account_settings_dialog_init):
3694 * src/maemo/modest-connection-specific-smtp-window.c:
3695 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
3697 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3699 * src/maemo/easysetup/modest-easysetup-wizard.c:
3700 (create_page_account_details), (create_page_custom_outgoing),
3701 (create_page_complete_custom):
3702 * src/maemo/modest-account-settings-dialog.c:
3703 (create_page_user_details), (create_page_incoming),
3704 (create_page_outgoing):
3705 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3706 (modest_connection_specific_smtp_edit_window_init):
3707 Use the correct (UI spec) port min/max, and use horizontal separators,
3710 2007-04-23 Murray Cumming <murrayc@murrayc.com>
3712 * src/maemo/easysetup/modest-easysetup-wizard.c:
3713 (set_default_custom_servernames):
3714 * src/maemo/modest-account-settings-dialog.c:
3715 (create_page_incoming), (on_combo_outgoing_security_changed),
3716 (on_combo_incoming_security_changed), (create_page_outgoing),
3717 (modest_account_settings_dialog_set_account_name),
3718 (save_configuration):
3719 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3720 (on_combo_security_changed),
3721 (modest_connection_specific_smtp_edit_window_init),
3722 (modest_connection_specific_smtp_edit_window_set_connection),
3723 (modest_connection_specific_smtp_edit_window_get_settings):
3724 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
3727 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3730 * src/maemo/easysetup/modest-easysetup-wizard.c:
3731 (create_page_custom_outgoing), (create_page_complete_custom):
3732 * src/maemo/modest-account-settings-dialog.c:
3733 (create_page_user_details), (create_page_outgoing):
3734 * src/maemo/modest-account-view-window.c: (button_box_new):
3735 Use changed logical IDs as per the most recent UI spec:
3736 mcen_bd_emailsetup_edit -> mcen_bd_edit
3737 mcen_bd_emailsetup_delete -> mcen_bd_delete
3738 mcen_bd_emailsetup_close -> mcen_bd_close
3740 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3744 * src/dbus_api/Makefile.am:
3745 * src/dbus_api/modest-dbus-callbacks.c:
3746 * src/dbus_api/modest-dbus-callbacks.h:
3747 * src/maemo/modest-platform.c: (modest_platform_init):
3748 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
3750 * tests/Makefile.am:
3751 * tests/dbus_api/Makefile.am:
3752 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
3754 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3756 * src/maemo/modest-account-settings-dialog.c:
3757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3758 Removed unnecessary includes.
3760 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3762 * src/maemo/easysetup/modest-easysetup-wizard.c:
3763 * src/maemo/modest-account-settings-dialog.c:
3764 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3765 * src/widgets/Makefile.am:
3766 * src/widgets/modest-easysetup-secureauth-combo-box.c:
3767 * src/widgets/modest-easysetup-secureauth-combo-box.h:
3768 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
3769 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
3770 * src/widgets/modest-secureauth-combo-box.c:
3771 * src/widgets/modest-secureauth-combo-box.h:
3772 * src/widgets/modest-serversecurity-combo-box.c:
3773 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
3774 made the GObject names more consistent with the rest of the Modest code.
3776 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3778 * src/maemo/easysetup/Makefile.am:
3779 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3780 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
3781 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3782 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3783 * src/maemo/easysetup/modest-easysetup-wizard.c:
3784 * src/maemo/easysetup/modest-validating-entry.c:
3785 * src/maemo/easysetup/modest-validating-entry.h:
3786 * src/maemo/modest-account-settings-dialog.c:
3787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3788 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
3789 widgets/ because they are used outside of easysetup too. After checking in,
3790 svn will allow me to rename them too.
3792 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3794 * src/gnome/modest-msg-edit-window.c:
3795 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
3796 linker error, to fix the build on the GNOME platform.
3797 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
3798 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
3799 ifdefed out to avoid a warning.
3801 2007-04-20 Murray Cumming <murrayc@murrayc.com>
3803 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
3804 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
3805 some alternative for GTK+ 2.6.
3807 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3809 * src/maemo/modest-address-book.c: Added include to avoid a warning.
3811 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
3812 specified for EmailAccountsDialog in UI spec.
3814 * src/maemo/easysetup/modest-easysetup-wizard.c:
3815 * src/maemo/easysetup/modest-easysetup-wizard.h:
3816 * src/maemo/modest-account-settings-dialog.c:
3817 * src/maemo/modest-account-settings-dialog.h:
3818 Reuse a member window widget for the connection-specific SMTP server accounts,
3819 so we can tell it to create/save the accounts only if we actually save changes.
3821 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3822 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3823 (modest_connection_specific_smtp_edit_window_get_settings):
3824 Return a struct instance for temporarily remembering the entered data.
3826 * src/maemo/modest-connection-specific-smtp-window.h:
3827 * src/maemo/modest-connection-specific-smtp-window.c:
3828 (modest_connection_specific_smtp_window_finalize),
3829 (modest_connection_specific_smtp_window_fill_with_connections),
3831 (modest_connection_specific_smtp_window_save_server_accounts),
3832 (update_model_server_names): Do not actually save data until asked,
3833 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
3835 (on_selection_changed),
3836 (modest_connection_specific_smtp_window_init): Disable the edit
3837 button when nothing is selected.
3839 * src/modest-account-mgr-helpers.c:
3840 * src/modest-account-mgr-helpers.h:
3841 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
3844 2007-04-19 Murray Cumming <murrayc@murrayc.com>
3846 * src/modest-account-mgr-helpers.h:
3847 * src/modest-account-mgr-helpers.c:
3848 (modest_account_mgr_get_unused_account_name),
3849 (modest_account_mgr_get_unused_account_display_name): Added these
3850 utility functions, to avoid code duplication.
3852 * src/maemo/easysetup/modest-easysetup-wizard.c:
3853 (create_page_account_details), (create_account):
3854 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3855 (on_combo_security_changed),
3856 (modest_connection_specific_smtp_edit_window_init),
3857 (modest_connection_specific_smtp_edit_window_save_settings):
3858 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3859 * src/maemo/modest-connection-specific-smtp-window.c:
3860 (modest_connection_specific_smtp_window_finalize),
3861 (modest_connection_specific_smtp_window_fill_with_connections),
3862 (on_button_edit), (modest_connection_specific_smtp_window_init):
3863 * src/maemo/modest-connection-specific-smtp-window.h:
3864 Implementing saving of connection-specific server accounts.
3866 But I need to refactor this so we can save the data for each
3867 possible connection-specific account and only actually create the server accounts
3868 when the easysetup finished, or the OK button is pressed on the account settings
3871 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3873 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3874 (on_combo_security_changed):
3875 (modest_connection_specific_smtp_edit_window_init):
3876 Auto-fill the port number as in the account settings.
3878 (modest_connection_specific_smtp_edit_window_set_connection):
3879 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3880 * src/maemo/modest-connection-specific-smtp-window.c:
3881 (fill_with_connections), (on_button_edit),
3882 (modest_connection_specific_smtp_window_init):
3883 Turn the edit window into a dialog to simplify the code, and
3884 set a WM hint as in a GtkDialog, because only a popup can be on top of
3885 another window in Maemo, and popups usually have no WM decoration.
3887 * src/modest-defs.h:
3888 * src/modest-account-mgr-helpers.c:
3889 (modest_account_mgr_set_connection_specific_smtp),
3890 (modest_account_mgr_remove_connection_specific_smtp),
3891 (modest_account_mgr_get_connection_specific_smtp):
3892 * src/modest-account-mgr-helpers.h: Some functions to write the
3893 connection-specific SMTP server information. Not yet used.
3896 * src/widgets/modest-folder-view.c: (text_cell_data):
3897 Fix a warning about an uninitialized variable.
3898 (on_configuration_key_changed): Put an #ifdef around the use
3899 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3901 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3903 * src/maemo/modest-account-settings-dialog.h:
3904 * src/maemo/modest-account-settings-dialog.c:
3905 Added connect_for_modified() utility function to mark the new modified boolean.
3907 (create_page_account_details), (create_page_user_details),
3908 (create_page_incoming), (create_page_outgoing), (on_response),
3909 (modest_account_settings_dialog_init),
3910 (modest_account_settings_dialog_set_account_name):
3911 Only warn about unsaved changes when there are actually unsaved changes.
3913 * src/modest-account-mgr-helpers.c:
3914 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3915 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3916 to get the data from there in future.
3918 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3920 * src/modest-defs.h:
3922 * src/modest-account-mgr-helpers.h:
3923 * src/modest-account-mgr-helpers.c:
3924 Store the security account setting in a single conf key instead of using
3925 the options list, so that the list is left for just the to-be-removed camel hack,
3926 and because gconf_client_set_list() is failing for some reason.
3928 * src/modest-account-mgr.c:
3929 (modest_account_mgr_add_server_account):
3930 * src/maemo/modest-account-settings-dialog.c:
3931 (modest_account_settings_dialog_set_account_name),
3932 (save_configuration): Use the renamed functions.
3935 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3937 * src/widgets/Makefile.am:
3938 * src/widgets/modest-limit-retrieve-combo-box.c:
3939 * src/widgets/modest-limit-retrieve-combo-box.h:
3940 * src/widgets/modest-retrieve-combo-box.c:
3941 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3942 the account settings dialog.
3944 * src/modest-defs.h:
3945 * src/modest-account-mgr-helpers.h:
3946 * src/modest-account-mgr-helpers.c:
3947 (modest_server_account_get_option_secure_auth),
3948 (modest_server_account_set_option_secure_auth):
3949 * src/modest-account-mgr.c:
3950 (modest_account_mgr_add_server_account):
3951 Use the existing AUTH_MECH conf key for the secure-auth setting,
3952 instead of putting it in the list options, because this was actually used already.
3954 * src/maemo/modest-account-settings-dialog.c:
3955 (create_page_account_details),
3956 (modest_account_settings_dialog_set_account_name),
3957 (save_configuration):
3958 * src/maemo/modest-account-settings-dialog.h:
3959 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3960 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3962 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3964 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3965 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3966 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3968 * src/modest-defs.h:
3969 * src/maemo/modest-account-settings-dialog.c:
3970 (create_page_incoming), (on_combo_outgoing_security_changed),
3971 (on_combo_incoming_security_changed), (create_page_outgoing),
3972 (modest_account_settings_dialog_set_account_name),
3973 (save_configuration): Load/Save the port number, and change it when the
3974 security combo changes, to suitable defaults.
3976 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3978 * src/modest-account-mgr.c:
3979 (modest_account_mgr_add_server_account): Set the security and secure-auth
3980 options, and add a comment saying that the other camel-specific options should be
3983 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3985 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3987 * src/modest-tny-account-store.c: (account_list_free),
3988 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3989 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3992 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3994 * src/modest-protocol-info.c:
3995 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3996 is required by our UI spec. Maybe something in our implementation will use this eventually.
3997 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3998 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3999 instead of the previous 0 placeholder.
4001 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4002 secure-auth settings.
4003 * src/modest-account-mgr-helpers.h:
4004 * src/modest-account-mgr-helpers.c:
4005 (modest_server_account_data_get_option_secure_auth),
4006 (modest_server_account_set_option_secure_auth),
4007 (modest_server_account_data_get_option_security),
4008 (modest_server_account_set_option_security): Added this API for getting and setting the security
4009 and secure-auth settings.
4011 * src/maemo/modest-account-settings-dialog.h:
4012 * src/maemo/modest-account-settings-dialog.c:
4013 (modest_account_settings_dialog_finalize), (check_data),
4014 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4015 about changing titles.
4016 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4017 (save_configuration): Save the security and secure-auth settings.
4019 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4020 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4022 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4024 * src/modest-defs.h:
4025 * src/modest-account-mgr.c:
4026 (modest_account_mgr_add_server_account):
4027 Added and used defines for the options key and value pair strings,
4028 that are used so far, though they do not seem to correspond to anything in our
4029 UI specs or ModestProtocol enum.
4031 * src/modest-account-mgr-helpers.h:
4032 * src/modest-account-mgr-helpers.c:
4033 (compare_option_strings_for_name),
4034 (modest_server_account_data_get_option_value),
4035 (modest_server_account_data_get_option_bool),
4036 (modest_account_mgr_get_server_account_option):
4037 Added helper functions for parsing the options GSList.
4039 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4041 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4042 display name is based on the supplied account name.
4043 * src/modest-account-mgr.c:
4044 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4045 with an inefficient, but good-enough, implementation.
4047 * src/maemo/easysetup/modest-easysetup-wizard.c:
4048 (create_page_account_details), (on_before_next), (create_account):
4049 Check for existing display names rather than (non-user-visible) account names, and just
4050 create and set a unique account name at the end.
4052 * src/maemo/modest-account-settings-dialog.c:
4053 (modest_account_settings_dialog_init),
4054 (modest_account_settings_dialog_set_account_name),
4055 (create_page_incoming): Show the display name, instead of the account name.
4056 (on_response): Do some (not all) extra checks, as in the UI spec.
4057 (save_configuration): Save the display name if it was changed.
4059 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4061 * po/en_GB.po: Added needed logical ID and translation.
4062 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4063 (init_view): Made the is-default column clicking work.
4065 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4068 * src/maemo/easysetup/Makefile.am:
4069 * src/maemo/easysetup/modest-easysetup-wizard.c:
4070 (modest_easysetup_wizard_dialog_init):
4071 * src/maemo/easysetup/provider-data-test.keyfile:
4072 * src/maemo/easysetup/provider-data.keyfile:
4073 Moved the provider data file to the new modest-providers-data package and used it from there.
4075 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4077 * src/modest-local-folder-info.c:
4078 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4079 N_() was already used on the static strings, but this just marks it for translation without
4080 using the translation.
4082 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4084 * src/maemo/modest-account-settings-dialog.c:
4085 (create_page_incoming),
4086 (modest_account_settings_dialog_set_account_name):
4087 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4088 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4089 I will do this if nobody else gets there first.
4091 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4093 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4094 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4095 save the security stuff.
4097 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4099 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4100 Set the email address and user fullname, which I now see must be
4103 * src/maemo/modest-account-settings-dialog.h:
4104 * src/maemo/modest-account-settings-dialog.c:
4106 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4107 leave-on-server and authentication.
4108 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4111 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4114 * src/maemo/modest-account-settings-dialog.c:
4115 * src/maemo/modest-account-settings-dialog.h:
4116 Most (but not all) of the widgets are now present as specified by the UI spec.
4117 No changes are yet saved, and some details are not properly shown yet.
4119 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4121 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4123 * src/maemo/Makefile.am:
4124 * src/maemo/modest-account-settings-dialog.c:
4125 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4126 an existing account. Doesn't do much yet.
4128 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4129 Open the accounts settings dialog when Edit is clicked.
4131 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4133 * src/maemo/easysetup/Makefile.am:
4134 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4136 * src/maemo/easysetup/modest-easysetup-wizard.c:
4137 (modest_easysetup_wizard_dialog_init):
4138 Try to get the source directory from the build system,
4139 instead of hard-coding "./" into the source code, when opening our local
4140 copies of the configuration files.
4141 But this still fails when opening the wizard from the Accounts window,
4142 maybe because the working directory seems to change at runtime.
4143 So the wizard will fail the second time unless you copy the files into their
4144 proper locations - see the stdout warnings for the paths.
4146 (create_page_account_details),(on_before_next):
4147 Check for existing non-server accounts instead of server accounts,
4148 so the default account name is useful again, and to prevent trying to
4151 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4152 Show the wizard when New is clicked.
4154 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4155 (init_view): Show the column headers, and show the columns that are
4156 specified in the UI specs. However, something in Maemo's GTK+ prevents
4157 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4158 change the default account. This is despite unsetting the special properties.
4160 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4162 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4163 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4164 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4165 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4166 to make that clearer.
4167 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4169 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4171 * src/maemo/modest-account-view-window.c:
4172 (modest_account_view_window_init),
4173 (modest_account_view_window_new):
4174 Use the same buttons as specified in the
4175 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4176 the existing widgets, which never had a chance of working.
4177 Put the ModestAccountView treeview in a scrolled window.
4178 Do not repeat the initialization in both _init() and _new().
4180 * src/widgets/modest-account-view.c: (update_account_view):
4181 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4182 this widget and window shows no accounts.
4184 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4186 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4188 * src/maemo/easysetup/modest-easysetup-wizard.c:
4189 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4190 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4191 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4194 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4195 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4196 accounts exist yet, as in the UI spec.
4198 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4200 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4202 * src/maemo/Makefile.am:
4203 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4204 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4205 New window for editing connection-specific smtp details.
4206 Not fully implemented.
4208 * src/maemo/modest-connection-specific-smtp-window.c:
4209 (modest_connection_specific_smtp_window_finalize) :
4210 unref the tree model.
4211 (on_button_edit): Show the edit window.
4213 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4215 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4218 * src/maemo/Makefile.am:
4219 * src/maemo/modest-connection-specific-smtp-window.c:
4220 * src/maemo/modest-connection-specific-smtp-window.h:
4221 New window for showing the list of connections, for connection-specific
4222 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4223 * src/maemo/easysetup/modest-easysetup-wizard.c:
4224 (create_page_custom_outgoing): Show the new window when the button is clicked.
4226 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4228 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4229 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4230 * src/maemo/modest-msg-edit-window.c:
4231 (modest_msg_edit_window_insert_image):
4232 * src/modest-conf.c: (modest_conf_key_escape):
4233 * src/modest-mail-operation.c:
4234 (modest_mail_operation_send_new_mail):
4235 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4236 (modest_ui_actions_on_new_account):
4237 * src/widgets/modest-attachment-view.c: (update_filename_request):
4238 * src/widgets/modest-mail-header-view.c:
4239 Corrected warnings that were breaking the build, by commenting out unused variables,
4240 and a function, and by including a header.
4242 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4244 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4245 so we can #ifdef around platform-specific code when necessary.
4246 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4247 to allow this to build for the GNOME platform too.
4249 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4251 * src/maemo/easysetup/modest-easysetup-wizard.c:
4252 Added util_increment_name() and used it in create_page_account_details()
4253 to make sure that the default account name is always a new name.
4255 (modest_easysetup_wizard_dialog_init),
4256 (set_default_custom_servernames): Some minor memory management fixes.
4258 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4262 * src/modest-runtime.c: (init_i18n): Restored the translation
4263 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4264 are defined in config.h, and the translations are installed.
4266 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4267 is defined for translation.
4269 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4271 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4273 * src/maemo/easysetup/modest-easysetup-wizard.c:
4274 (modest_easysetup_wizard_dialog_init):
4275 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4276 Use realistic paths (though they should use $prefix generically) to the
4277 mcc_mapping and provider-data.keyfile files which might work when they
4278 are installed by the future version of the operator-wizard package,
4279 and then fallback to paths in our source code, with an explanatory
4282 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4286 * src/maemo/Makefile.am:
4287 * src/maemo/easysetup/: Added files from the previously-exernal
4288 osso-modest-easysetup.
4289 * src/maemo/modest-main-window-ui.h:
4290 * src/modest-ui-actions.c:
4291 * src/modest-ui-actions.h:
4292 Added modest_ui_actions_on_new_account() as a signal handler for the
4293 New Account menu item. It shows the easysetup wizard.
4294 * po/en_GB.po: Added additional needed logical IDs and translations.