Perform some cleanup

[wifihood] / wifimap / gps.py

diff --git a/wifimap/gps.py b/wifimap/gps.py
index 409400c..e83e7b1 100644 (file)
--- a/wifimap/gps.py
+++ b/wifimap/gps.py
@@ -2,10 +2,6 @@
 
 import location
 
-try :
-    import hildon
-except :
-    hildon = False
 import gobject
 
 class GPSObject ( gobject.GObject ) :
@@ -15,9 +11,9 @@ class GPSObject ( gobject.GObject ) :
         self._parent = widget
         self._debug = False
         self.control = location.GPSDControl.get_default()
+        self.device = location.GPSDevice()
         # properties : maincontext_pointer preferred_interval preferred_method
         self.method = location.METHOD_GNSS
-        self.device = None
         self.gps_state = False
         self.gps_info = "NO_FIX 0 0 NaN NaN NaN NaN NaN NaN NaN"
         self.update_handler = None
@@ -49,15 +45,13 @@ class GPSObject ( gobject.GObject ) :
             self.interval = location.INTERVAL_60S
         elif interval == "120" :
             self.interval = location.INTERVAL_120S
+        else :
+            self.interval = location.INTERVAL_DEFAULT
 
     def do_start ( self ) :
-        if not self.device :
-            self.control.set_properties(preferred_method=self.method)
-            self.device = location.GPSDevice()
-        if self.update_handler :
-            if hildon :
-                hildon.hildon_banner_show_information( self._parent , "icon_path" , "GPS already started" )
-        else :
+        self.control.set_properties(preferred_method=self.method,                                                  
+                                    preferred_interval=self.interval)                                              
+        if not self.update_handler :
             self.update_handler = self.device.connect_object("changed", GPSObject.do_update , self)
             self.control.start()
 
@@ -67,42 +61,24 @@ class GPSObject ( gobject.GObject ) :
             # FIXME : Is this removal OK?
             del self.update_handler
             self.update_handler = None
-        self.device.stop()
         self.control.stop()
 
     def do_update ( self ) :
 
         if self.device :
             if self.device.status == location.GPS_DEVICE_STATUS_NO_FIX :
-            #    if self.gps_state == "FIX" or self.gps_state == "DGPS" :
-            #      if hildon :
-            #        banner = hildon.hildon_banner_show_information( self._parent , "icon_path" , "Lost GPS fix" )
-            #        banner.set_timeout( 1500 )
                 self.gps_state = "NO_FIX"
             elif self.device.status == location.GPS_DEVICE_STATUS_FIX :
-            #    if self.gps_state == "NO_FIX" :
-            #      if hildon :
-            #        banner = hildon.hildon_banner_show_information( self._parent , "icon_path" , "Got GPS fix" )
-            #        banner.set_timeout( 1500 )
                 self.gps_state = "FIX"
                 self.ngps += 1
                 self.refresh_infowin()
             elif self.device.status == location.GPS_DEVICE_STATUS_DGPS_FIX :
-            #    if self.gps_state == "NO_FIX" :
-            #      if hildon :
-            #        banner = hildon.hildon_banner_show_information( self._parent , "icon_path" , "Got differential GPS fix" )
-            #        banner.set_timeout( 1500 )
                 self.gps_state = "DGPS"
 
             self.gps_info = "%s %d %d %s %s %s %s %s %s %s" % ( self.gps_state , self.device.satellites_in_use , self.device.satellites_in_view , self.device.fix[2] , self.device.fix[4] , self.device.fix[5] , self.device.fix[7] , self.device.fix[9] , self.device.fix[11] , self.device.fix[13] )
             self.satellites = self.device.satellites
             self.cell_info = self.device.cell_info
 
-        #    if self._debug :
-        #      if hildon :
-        #        banner = hildon.hildon_banner_show_information( self._parent , "icon_path" , "GPS info : %s" % self.gps_info )
-        #        banner.set_timeout( 300 )
-
     def set_infowin ( self , statuswin ) :
         self.status = statuswin